Author Topic: Fix for Loss of Consensus with Withdraw Vesting Balance  (Read 580 times)

0 Members and 1 Guest are viewing this topic.

Offline bytemaster

Fix for Loss of Consensus with Withdraw Vesting Balance
« on: October 27, 2015, 10:42:31 pm »
Ben and I have discovered the root cause for the loss of consensus and have a temporary fix that can be used by all witnesses.

The problem was a single field which we failed to serialize when saving chain state to disk.  Any node that didn't replay the chain on startup would have this field reset to 0.

We will be releasing a fix for this along with several other fixes by the end of the week.   In the meantime, all full nodes should always replay the blockchain on startup by using the --replay-chain argument.

For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 3297
    • View Profile
    • Steemit Blog
  • BitShares: abit
  • GitHub: abitmore
Re: Fix for Loss of Consensus with Withdraw Vesting Balance
« Reply #1 on: October 28, 2015, 08:32:00 am »
Restarted.
A node with Debug build took 461 seconds to re-index.
Another node running with Release build took 126 seconds to re-index.

Do we still need to restart if it's already started with --replay-blockchain? Do we need to restart with --replay-blockchain every day or somewhat interval?

Here are some new info while restarting.
Code: [Select]
   82.551%   346000 of 419135
1401613ms th_a       db_update.cpp:244             check_for_blackswan  ] Black Swan detected:
   Least collateralized call: 75.71602860647396938  0.01320724314791250
   Settle Price:              0.00025496653564220  3922.08333333333348492
   Max:                       0.00025496653564220   3922.08333333333348492

1401614ms th_a       db_update.cpp:244             check_for_blackswan  ] Black Swan detected:
   Least collateralized call: 759.92759999999998399  0.00131591483188662
   Settle Price:              0.00003505287141438  28528.33333333333212067
   Max:                       0.00003505287141438   28528.33333333333212067
« Last Edit: October 28, 2015, 08:37:19 am by abit »
BTS account: abit
BTS committee member: abit
BTS witness: in.abit

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12636
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc
Re: Fix for Loss of Consensus with Withdraw Vesting Balance
« Reply #2 on: October 28, 2015, 09:07:00 am »
Those are supposedly RUB and SEK .. It may have been caused by a malious price from yahoo but I can't tell for sure ..
Give BitShares a try! Use the http://testnet.bitshares.eu provided by http://bitshares.eu powered by ChainSquad GmbH

Offline bytemaster

Re: Fix for Loss of Consensus with Withdraw Vesting Balance
« Reply #3 on: October 28, 2015, 12:51:15 pm »
Those are supposedly RUB and SEK .. It may have been caused by a malious price from yahoo but I can't tell for sure ..

Total amount of value involved in those swans is less than $10.   
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12636
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc
Re: Fix for Loss of Consensus with Withdraw Vesting Balance
« Reply #4 on: October 28, 2015, 01:28:30 pm »
Those are supposedly RUB and SEK .. It may have been caused by a malious price from yahoo but I can't tell for sure ..

Total amount of value involved in those swans is less than $10.   
How can we restart the markets then?
Give BitShares a try! Use the http://testnet.bitshares.eu provided by http://bitshares.eu powered by ChainSquad GmbH

Offline maqifrnswa

  • Hero Member
  • *****
  • Posts: 661
    • View Profile
Re: Fix for Loss of Consensus with Withdraw Vesting Balance
« Reply #5 on: October 28, 2015, 02:13:46 pm »
Are the tags correct?
2.0.151027 is a lower version number than the previous release 2.15.294

that causes problems for people with automated version checking, and is different than the previously announced versioning system
maintains an Ubuntu PPA: https://launchpad.net/~showard314/+archive/ubuntu/bitshares [15% delegate] wallet_account_set_approval maqifrnswa true [50% delegate] wallet_account_set_approval delegate1.maqifrnswa true

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 3297
    • View Profile
    • Steemit Blog
  • BitShares: abit
  • GitHub: abitmore
Re: Fix for Loss of Consensus with Withdraw Vesting Balance
« Reply #6 on: October 28, 2015, 02:20:27 pm »
Are the tags correct?
2.0.151027 is a lower version number than the previous release 2.15.294

that causes problems for people with automated version checking, and is different than the previously announced versioning system
Apparently 294 which is day-of-year is harder to read. 151027 is a date but easier to read.
I wonder why not use 2.15.1027 for better compatibility.
BTS account: abit
BTS committee member: abit
BTS witness: in.abit

Offline bytemaster

Re: Fix for Loss of Consensus with Withdraw Vesting Balance
« Reply #7 on: October 28, 2015, 06:43:57 pm »
Are the tags correct?
2.0.151027 is a lower version number than the previous release 2.15.294

that causes problems for people with automated version checking, and is different than the previously announced versioning system
Apparently 294 which is day-of-year is harder to read. 151027 is a date but easier to read.
I wonder why not use 2.15.1027 for better compatibility.

We would like to reserve the 2.X  as the hard fork number. 
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.