Author Topic: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io  (Read 24070 times)

0 Members and 1 Guest are viewing this topic.

Offline lakerta06

Here is a new one, but I am not sure which way to go:

On page http://invictus.io/bitshares-ags.php the term "Allied developers" is seen twice. I think both "a" and "d" shoud be in lower case. Or if "Allied Developers" is a proper noun (which I do not think so), then it should be both uppercase.

So I went the lowercase way and created a pull request:

https://github.com/super3/invictus.io/pull/78

Let me know if it should be the other way around.

rejected with no comment  ???

Guess it was a style choice to have Allied developers.

Lol  :)

Offline jernau

  • Full Member
  • ***
  • Posts: 78
    • View Profile
Here is a new one, but I am not sure which way to go:

On page http://invictus.io/bitshares-ags.php the term "Allied developers" is seen twice. I think both "a" and "d" shoud be in lower case. Or if "Allied Developers" is a proper noun (which I do not think so), then it should be both uppercase.

So I went the lowercase way and created a pull request:

https://github.com/super3/invictus.io/pull/78

Let me know if it should be the other way around.

rejected with no comment  ???

Guess it was a style choice to have Allied developers.
PTS: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW

Offline lakerta06

Here is a new one, but I am not sure which way to go:

On page http://invictus.io/bitshares-ags.php the term "Allied developers" is seen twice. I think both "a" and "d" shoud be in lower case. Or if "Allied Developers" is a proper noun (which I do not think so), then it should be both uppercase.

So I went the lowercase way and created a pull request:

https://github.com/super3/invictus.io/pull/78

Let me know if it should be the other way around.

rejected with no comment  ???

Offline jernau

  • Full Member
  • ***
  • Posts: 78
    • View Profile
I've made two changes in this pull request: https://github.com/super3/invictus.io/pull/80 (username themanifold). One is a grammar typo, the other is to create some favicons. Everyone loves favicons.
PTS: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW

Offline lakerta06

Here is a new one, but I am not sure which way to go:

On page http://invictus.io/bitshares-ags.php the term "Allied developers" is seen twice. I think both "a" and "d" shoud be in lower case. Or if "Allied Developers" is a proper noun (which I do not think so), then it should be both uppercase.

So I went the lowercase way and created a pull request:

https://github.com/super3/invictus.io/pull/78

Let me know if it should be the other way around.

Offline Amazon

  • Hero Member
  • *****
  • Posts: 830
    • View Profile
    • Bitshares Forum
Forum Donation: PforumPLfVQXTi4QpQqKwoChXHkoHcxGuA

Offline phabit

  • Newbie
  • *
  • Posts: 18
    • View Profile

https://github.com/super3/invictus.io/pull/72

Done.  Please credit phabit for this one.

Thanks - very generous! I'll learn to use github when I get a spare moment.
PTS : PoPcJAzDM5WMnTfBLuMpXSpbW8hjPV1c7d

38PTSWarrior

  • Guest
« Last Edit: January 29, 2014, 02:16:30 am by 38PTSWarrior »

Offline Amazon

  • Hero Member
  • *****
  • Posts: 830
    • View Profile
    • Bitshares Forum
Till the pull request #74, I am going to pay as follows:

xeroc       PdbNaeWMsB2JXWWURwxVNA2jdZEmpuUaME 1
gigawatt           Pstkk1gZCxc4GEwS1eBAykYwVmcubU1P8L 9
jernau      PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW 12
lakerta06           PeyQbhgPJra5Cts7sEXN5ccQoTsLtGxFT8 4
toast      PtoastsCnAW4JfoSFbjvZjSBRPUB9qBoSU 1
Troglodactyl   Pt2FcsBjnnbjAuVLghytyYmeKyqykVZhf5 8
phabit              PoPcJAzDM5WMnTfBLuMpXSpbW8hjPV1c7d 1
38PTSWarrior   PmJwbQBFssGK1yd1GLQb8hHswzyRkqqNzB 1
nametooshort   PvDZqsSyAsCDYNyYCfwZmy19EVohxnbnKB 1
todofixthis   PZ32Dv8NA1CBNtYyu5Z14qWNL6VWDSP4HC 16

todofixthis, you changed lots of inconsistency, I will count your total contribution as 16 PTS. Please let me know if you think it is fair and also PM me your address.
currencydebt, could you please PM me your github id or pull request number.

It is hard to match forum ID and github ID. If your pull request #<=74 and got merged but not listed above, please PM me.
« Last Edit: January 29, 2014, 01:53:02 pm by Amazon »
Forum Donation: PforumPLfVQXTi4QpQqKwoChXHkoHcxGuA

Offline lakerta06


Offline bytemaster


PTS addy is in the pull request description.

Oops... I really hope I get credit for each typo I fixed and not just 1 PTS per pull request! /:

Sure thing, you get one per typo found/fixed.  I am going to delegate the task of paying these bounties out to Amazon. 

Thanks for everyone who has worked on this while we were busy in Miami.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline nametooshort

  • Jr. Member
  • **
  • Posts: 46
    • View Profile
Even if writing Protoshare address in signature is not something good,
PvDZqsSyAsCDYNyYCfwZmy19EVohxnbnKB

Offline 70231f697a2b3c2b

  • Full Member
  • ***
  • Posts: 61
    • View Profile

PTS addy is in the pull request description.

Oops... I really hope I get credit for each typo I fixed and not just 1 PTS per pull request! /:
« Last Edit: January 28, 2014, 05:19:45 am by todofixthis »

Offline Troglodactyl

  • Hero Member
  • *****
  • Posts: 960
    • View Profile
Hi all,
Don't have the time to work out how to use github right now, but just spotted the link on http://invictus.io/bitshares-pts.php to the beeeer mining pool isn't correct - it's points to http://pts.beeeeer.org/, but should be http://ptsweb.beeeeer.org.

Someone who knows how to do it, feel free to submit a fix, and share the bounty with me (PoPcJAzDM5WMnTfBLuMpXSpbW8hjPV1c7d)!  :D

https://github.com/super3/invictus.io/pull/72

Done.  Please credit phabit for this one.

Offline phabit

  • Newbie
  • *
  • Posts: 18
    • View Profile
Hi all,
Don't have the time to work out how to use github right now, but just spotted the link on http://invictus.io/bitshares-pts.php to the beeeer mining pool isn't correct - it's points to http://pts.beeeeer.org/, but should be http://ptsweb.beeeeer.org.

Someone who knows how to do it, feel free to submit a fix, and share the bounty with me (PoPcJAzDM5WMnTfBLuMpXSpbW8hjPV1c7d)!  :D

« Last Edit: January 27, 2014, 11:34:16 pm by phabit »
PTS : PoPcJAzDM5WMnTfBLuMpXSpbW8hjPV1c7d