Bids not executing against shorts

[xeroc]

*agreed*
I'd love to have seen the faces of the devs once they figured that one out

[emski]

And now that block #451500 is finally in the past...

I find the above post the funniest thing ever posted on this forum!

I completely agree with you!

[tonyk]

And now that block #451500 is finally in the past...

I find the above post the funniest thing ever posted on this forum!

[Riverhead]

Thanks to whoever sold me the bitBTC !!!!

Come on guys, come sell me some bitBTC for bitUSD, offering great rate 500 bitUSD/bitBTC....

OK, I'll byte (  ). Let me see what I can do.


As for not being able to execute short purchases that could make this a problem .

If you do not have bitBTC already do not bother.

I might be crazy and stupid but I can place a bid order without a guide...

If I can short bitBTC into existence for $475 each and your offering $500 why wouldn't I do it? What am I missing?


I am not crazy or stupid but I can't place a short order without a guide

Right now you cannot... I would have created them for myself if I could...

Ah, of course. /facepalm

[bytemaster]

https://github.com/dacsunlimited/bitsharesx/releases/tag/0.4.13-RC1

Fix for this... 24 hours till fork.

[tonyk]

Thanks to whoever sold me the bitBTC !!!!

Come on guys, come sell me some bitBTC for bitUSD, offering great rate 500 bitUSD/bitBTC....

OK, I'll byte (  ). Let me see what I can do.


As for not being able to execute short purchases that could make this a problem .

If you do not have bitBTC already do not bother.

I might be crazy and stupid but I can place a bid order without a guide...

If I can short bitBTC into existence for $475 each and your offering $500 why wouldn't I do it? What am I missing?


I am not crazy or stupid but I can't place a short order without a guide

Right now you cannot... I would have created them for myself if I could...

[Riverhead]

Come on guys, come sell me some bitBTC for bitUSD, offering great rate 500 bitUSD/bitBTC....

OK, I'll byte (  ). Let me see what I can do.


As for not being able to execute short purchases that could make this a problem .

If you do not have bitBTC already do not bother.

I might be crazy and stupid but I can place a bid order without a guide...

If I can short bitBTC into existence for $475 each and your offering $500 why wouldn't I do it? What am I missing?


I am not crazy or stupid but I can't place a short order without a guide

[tonyk]

Come on guys, come sell me some bitBTC for bitUSD, offering great rate 500 bitUSD/bitBTC....

OK, I'll byte (  ). Let me see what I can do.


As for not being able to execute short purchases that could make this a problem .

If you do not have bitBTC already do not bother.

I might be crazy and stupid but I can place a bid order without a guide...

[Riverhead]

Come on guys, come sell me some bitBTC for bitUSD, offering great rate 500 bitUSD/bitBTC....

OK, I'll byte (  ). Let me see what I can do.


As for not being able to execute short purchases that could make this a problem .

[tonyk]

Come on guys, come sell me some bitBTC for bitUSD, offering great rate 500 bitUSD/bitBTC....

[srcgpsmp]

I am having the same issue here.
how do I fix this? is there something I need to do or it is known problem that will be solved in the next client update?

[tonyk]

I'm not that sure anymore. The interest can be included in any future version. There is no need to upgrade now for it to work starting Wednesday. So my new answer is: Ask Bytemaster.

Ask Bytemaster
He is sick/ill, as far as I know... and my losses/winning are swinging at 1/4 -1/1 my monthly salary every 2-3 hours, because I can not place/execute my orders...

You must be having a lot of fun then (:. This must be pretty exciting ...

I do not complain recently...     (other than the stupidity with Bitshares Music, that is),   I am having a blast.

I have 6x return on my, after BTSX launch investments, and  18x on my Jan-Feb AGS donations...

And BTSX is only at $0.04, a good 10x-25x to go in the not so distant future....

[emski]

I'm not that sure anymore. The interest can be included in any future version. There is no need to upgrade now for it to work starting Wednesday. So my new answer is: Ask Bytemaster.

Ask Bytemaster
He is sick/ill, as far as I know... and my losses/winning are swinging at 1/4 -1/1 my monthly salary every 2-3 hours, because I can not place/execute my orders...

You must be having a lot of fun then (:. This must be pretty exciting ...

[tonyk]

I'm not that sure anymore. The interest can be included in any future version. There is no need to upgrade now for it to work starting Wednesday. So my new answer is: Ask Bytemaster.

Ask Bytemaster
He is sick/ill, as far as I know... and my losses/winning are swinging at 1/4 -1/1 my monthly salary every 2-3 hours, because I can not place/execute my orders...

[emski]

I'm not that sure anymore. The interest can be included in any future version. There is no need to upgrade now for it to work starting Wednesday. So my new answer is: Ask Bytemaster.

[tonyk]

There is no way, this is the best way to place your orders... 

As fun as this exercise was and as funny as toast's post is, I have to ask:

"Is 0.4.12-RC2 coming soon?"

0.4.12 is already out. RC means release candidate and 0.4.12-RC1 precedes 0.4.12. The next version should be 0.4.13-RC1 (or 0.4.14-RC1 due to superstitions). -RC suffix might be omitted  if developers feel there is no need for testing.

And for the question "where is the next version?" - It should be out by Tuesday (assuming interest is scheduled for Wednesday).

Thanks for the lesson. Will keep it mind the next time I ask.
So, to the point, you think then next version  is coming Today (Tuesday) ?

[emski]

There is no way, this is the best way to place your orders... 

As fun as this exercise was and as funny as toast's post is, I have to ask:

"Is 0.4.12-RC2 coming soon?"

0.4.12 is already out. RC means release candidate and 0.4.12-RC1 precedes 0.4.12. The next version should be 0.4.13-RC1 (or 0.4.14-RC1 due to superstitions). -RC suffix might be omitted  if developers feel there is no need for testing.

And for the question "where is the next version?" - It should be out by Tuesday (assuming interest is scheduled for Wednesday).

[jsidhu]

I assume is fixed by this commit:  https://github.com/BitShares/bitshares_toolkit/commit/eec87d8fa136fecea74c68574e4062ab63559846

That inequality flipping from <= to > makes me nervous...

I think at the very least update the block comment... thats the hard part of having meaningful comments that change as logic changes..  I like to name my variables as descriptive as possible.

Looking at the code... the primary logic comparison (mtrx.bid_price > max_short_bid) that the current bid price is greater than 1h average or median is true regardless of what max_short_bid is because if the secondary comparison is true (mtrx.ask_price > max_short_bid) than the primary is true by extension of the check to ensure bid_price > ask_price.

Thus we have reverted the logic from if mtrx.ask_price <= max_short_bid then don't execute this order,  to the opposite of mtrx.ask_price > max_short_bid then don't execute this order.

So isn't this code saying now, for a short order, that if the bid&ask are > than the median/average then don't execute this order? Is that the intended behaviour?

[tonyk]

There is no way, this is the best way to place your orders... 

As fun as this exercise was and as funny as toast's post is, I have to ask:

"Is 0.4.12-RC2 coming soon?"

[GaltReport]

Now, THAT is funny.

[toast]

[theoretical]

I assume is fixed by this commit:  https://github.com/BitShares/bitshares_toolkit/commit/eec87d8fa136fecea74c68574e4062ab63559846

That inequality flipping from <= to > makes me nervous...

[bytemaster]

Code: [Select]

>> blockchain_market_order_book BTC BTSX

                  BIDS (* Short Order)                                       |                                   ASKS                                 
TOTAL                     QUANTITY                                     PRICE | PRICE                                        QUANTITY                     TOTAL   COLLATERAL
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.99999999 BTC            12,775.99990 BTSX               0.000078271760 BTC*| 0.000078263933 BTC                  12,777.27760 BTSX            0.99999999 BTC
0.99999999 BTC            12,776.00000 BTSX               0.000078271760 BTC*| 0.000080000000 BTC                  12,500.00000 BTSX            1.00000000 BTC
0.00999999 BTC            135.00000 BTSX                  0.000074074074 BTC*| 0.000083333333 BTC                   4,318.56954 BTSX            0.35988079 BTC
Is this known too?

Same issue.

[GaltReport]

I made a short at the top of the book, 26.75 which was above median and average price.  The short showed up in the GUI order list confirming it is OK price-feed-wise.

Then I made a bid for the same quantity at price of 26.7501.  The bid did not execute.  Why?

Same here.  I bid the EXACT price of my short when it was at the top of the sell orders and it sat their more than 5 10 minutes.  This is not a different price with a different ending nonvisible decimal point.  The prices were the same.

[tonyk]

Code: [Select]

>> blockchain_market_order_book BTC BTSX

                  BIDS (* Short Order)                                       |                                   ASKS                                 
TOTAL                     QUANTITY                                     PRICE | PRICE                                        QUANTITY                     TOTAL   COLLATERAL
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.99999999 BTC            12,775.99990 BTSX               0.000078271760 BTC*| 0.000078263933 BTC                  12,777.27760 BTSX            0.99999999 BTC
0.99999999 BTC            12,776.00000 BTSX               0.000078271760 BTC*| 0.000080000000 BTC                  12,500.00000 BTSX            1.00000000 BTC
0.00999999 BTC            135.00000 BTSX                  0.000074074074 BTC*| 0.000083333333 BTC                   4,318.56954 BTSX            0.35988079 BTC
Is this known too?

[bytemaster]

I made a short at the top of the book, 26.75 which was above median and average price.  The short showed up in the GUI order list confirming it is OK price-feed-wise.

Then I made a bid for the same quantity at price of 26.7501.  The bid did not execute.  Why?

Known issue, grumble grumble.... fix has already been implemented.

[theoretical]

I made a short at the top of the book, 26.75 which was above median and average price.  The short showed up in the GUI order list confirming it is OK price-feed-wise.

Then I made a bid for the same quantity at price of 26.7501.  The bid did not execute.  Why?