BitShares Forum

Main => General Discussion => Topic started by: xeroc on June 23, 2017, 06:11:10 am

Title: [CLOSED][1000bitUSD BOUNTY] - Update testnet codebase to bitshares codebase
Post by: xeroc on June 23, 2017, 06:11:10 am
UPDATE: This bounty has been claimed by @pc! Do not waste your time on it!

Original post:



Hey there,

I have started working on some more python code and wanted to test it on the testnet until I realized that the current testnet graphene code fell behind the code base of bitshares quite a bit. In order to build code that works best with bitshares, I am looking for some assistance in updating the testnet code base to be compatible with the bitshares code base.

I tried my self to merge or cherry pick the commits, but the replay failed at some point. Since I am not a C++ dev and don't have the required insights in the backend, I hereby offer a

Bounty of $1000 (to be paid in bitUSD)

The tasks are:

Requirement:

Looking forward to some discussion and feedback.

Fabian Schuh
CEO of ChainSquad GmbH
Title: Re: [CLOSED][1000bitUSD BOUNTY] - Update testnet codebase to bitshares codebase
Post by: pc on June 23, 2017, 08:06:49 am
Looking into this
Title: Re: [CLOSED][1000bitUSD BOUNTY] - Update testnet codebase to bitshares codebase
Post by: rnglab on June 25, 2017, 08:09:53 am
This is highly needed.

As far as I know, ChainSquad has no profits form the public testnet management, and it benefits BitShares as a whole. It's a fundamental for development, testing and for projects seeking for a platform to adopt.

On the other hand it's a relief for BitShares to have ChainSquad on charge of it, so I think worker proposals to have the testnet always up to date would be as fair as convenient for everyone.

Title: Re: [CLOSED][1000bitUSD BOUNTY] - Update testnet codebase to bitshares codebase
Post by: pc on June 25, 2017, 08:10:40 am
Done: https://github.com/pmconrad/graphene/tree/testnet

There's a new testnet-specific hardfork that deals with two differences to main net ("BIT" assets and proposal validation). Also, hardfork 385 has never been part of graphene and was therefore not in the old testnet code.

Built and synched successfully up to current head block.

I had to adapt the timeouts in https://github.com/bitshares/bitshares-core/blob/master/libraries/net/include/graphene/net/config.hpp#L48 and https://github.com/bitshares/bitshares-core/blob/master/libraries/net/node.cpp#L1368 in order to sync the large blocks from the recent throughput test. This is a known issue and unrelated to the testnet itself (can't find the github issue, but I remember someone complaining about a similar problem).

Edit: PR created https://github.com/BitSharesEurope/testnet/pull/2
Title: Re: [CLOSED][1000bitUSD BOUNTY] - Update testnet codebase to bitshares codebase
Post by: cusknee on June 25, 2017, 10:48:57 am
I love seeing these things getting done! Fabulous!
Title: Re: [CLOSED][1000bitUSD BOUNTY] - Update testnet codebase to bitshares codebase
Post by: xeroc on June 25, 2017, 11:39:45 am
Done: https://github.com/pmconrad/graphene/tree/testnet

There's a new testnet-specific hardfork that deals with two differences to main net ("BIT" assets and proposal validation). Also, hardfork 385 has never been part of graphene and was therefore not in the old testnet code.

Built and synched successfully up to current head block.

I had to adapt the timeouts in https://github.com/bitshares/bitshares-core/blob/master/libraries/net/include/graphene/net/config.hpp#L48 and https://github.com/bitshares/bitshares-core/blob/master/libraries/net/node.cpp#L1368 in order to sync the large blocks from the recent throughput test. This is a known issue and unrelated to the testnet itself (can't find the github issue, but I remember someone complaining about a similar problem).

Edit: PR created https://github.com/BitSharesEurope/testnet/pull/2
Wonderful piece of work! Thanks!
Going forward, business/paymemt stuff goes per mail
Title: Re: [CLOSED][1000bitUSD BOUNTY] - Update testnet codebase to bitshares codebase
Post by: xeroc on June 25, 2017, 11:42:01 am
This is highly needed.

As far as I know, ChainSquad has no profits form the public testnet management, and it benefits BitShares as a whole. It's a fundamental for development, testing and for projects seeking for a platform to adopt.

On the other hand it's a relief for BitShares to have ChainSquad on charge of it, so I think worker proposals to have the testnet always up to date would be as fair as convenient for everyone.
I am considering this, but for now, i mostly need the testnet updated for my own development stuff .. like stakemachine and an uptick api that is compatible with polo