I noticed two problematic files in the web_wallet: vendor/js/highcharts.src.js and vendor/js/highstock.src.js. These two are licensed under the "Creative Commons Attribution-NonCommercial 3.0 License". Notice the "NonCommercial", this is IMO a complete no-go for a P2P currency client.
thank you for the review!
The license language is:
You may not exercise any of the rights granted to You in Section 3 above in any manner that is primarily intended for or directed toward commercial advantage or private monetary compensation.[...]
Who is actually in violation of the license? Developers for distributing code that is uses primarily for private monetary compensation ("compensation" might be the key word, since it's used for "gain" but not "compensation")? Traders that make money, but not traders that lose money? Delegates that run the GUI client to sign blocks? If I use those files to make a website showing BitUSD prices for free, and someone uses my website to make money - are they or I in violation (or neither?)
This is the "section 3" referenced above:
3. License Grant. Subject to the terms and conditions of this License, Licensor hereby grants You a worldwide, royalty-free, non-exclusive, perpetual (for the duration of the applicable copyright) license to exercise the rights in the Work as stated below:
a) to Reproduce the Work, to incorporate the Work into one or more Collections, and to Reproduce the Work as incorporated in the Collections;
b) [...]
c) to Distribute and Publicly Perform the Work including as incorporated in Collections; and,
The web_wallet "incorporates the Work". I. e. the person who initially committed this into the repo did so under the terms of the license. Anyone who clones the repo does so under the license. Anyone who distributes the software in source or binary form does so under the license. All of this in itself is not yet a violation of section 4a of the license, because the software is made available for free. (IMO the way the files have been "incorporated" is not sufficient wrt section 4c of the license, though.)
IANAL, but I think in general the term "reproduce" is also applied to loading the software into RAM in order to execute it. I. e. anyone who runs the software does so under the license.
I'm not sure what qualifies as "commercial advantage or private monetary compensation". I'm pretty sure though that a merchant using the gui client to receive payment for his goods would be using the software for "commercial advantage". Delegates with non-zero pay using the gui client would be doing this for "commercial advantage". A trader would likely also be using it for "commercial advantage", even if he is a bad trader - what counts is the intention, a bad trader isn't trading for his commercial disadvantage. Creating a free website showing BitUSD prices OTOH would not be a problem if you only use the gui client to extract the prices from the network (other than using the files in question to display charts in the user's browser).