Show Posts
1
General Discussion / Developers: Some observations about the codebase.
« on: September 02, 2014, 05:31:05 am »
Hi Guys,
I'm fascinated with your idea for BitUSD, so I recently bought some BTSX on an exchange and then downloaded the wallet to start experimenting. Because my wallet kept crashing, I started looking at the bitsharesx codebase on github.
There seems to be some missing tests. I can't find tests for many of the classes. I also noticed that several of the classes are very large with dozens of methods each, and frequently the methods themselves are quite long - this makes testing them very difficult. If you could refactor these large classes and methods into a more manageable object model, i.e., extract out new classes from the large ones so you have more classes, smaller classes, with fewer methods, it'll be a lot easier to test them.
Ideally, from the perspective of an investor, I'd love to see a TDD approach with the goal of 100% test coverage. In that scenario I believe that many of the bugs users are experiencing would be avoided, and investor confidence would soar.
I haven't programmed in C++ for over a decade so maybe the tests are there and I just missed them. In that case, feel free to kick me in the head and point me in the right direction
I'm fascinated with your idea for BitUSD, so I recently bought some BTSX on an exchange and then downloaded the wallet to start experimenting. Because my wallet kept crashing, I started looking at the bitsharesx codebase on github.
There seems to be some missing tests. I can't find tests for many of the classes. I also noticed that several of the classes are very large with dozens of methods each, and frequently the methods themselves are quite long - this makes testing them very difficult. If you could refactor these large classes and methods into a more manageable object model, i.e., extract out new classes from the large ones so you have more classes, smaller classes, with fewer methods, it'll be a lot easier to test them.
Ideally, from the perspective of an investor, I'd love to see a TDD approach with the goal of 100% test coverage. In that scenario I believe that many of the bugs users are experiencing would be avoided, and investor confidence would soar.
I haven't programmed in C++ for over a decade so maybe the tests are there and I just missed them. In that case, feel free to kick me in the head and point me in the right direction
