Author Topic: Big bug in GUI asset update?  (Read 5633 times)

0 Members and 1 Guest are viewing this topic.

Offline merivercap

  • Hero Member
  • *****
  • Posts: 661
    • View Profile
    • BitCash
I have tested and found that now the force settlement feature is actually enabled for TCNY.

according to the design, force settlement/allow witness to provide feed features should both be disabled because of the change but actually not, this is another bug and when in the future the bug be fixed these features will be actually disabled for TCNY, right?

so I wonder whether there are ways to reserve these features for TCNY, as they are important for a smartcoin.

Yeah I agree.   The features should be consistent with regular smartcoins.  (Although I'd probably want to disable forced settlement or make it 90%.)

So do these bugs just occur in the GUI and will CLI changes work fine?
BitCash - http://www.bitcash.org 
Beta: bitCash Wallet / p2p Gateway: (https://m.bitcash.org)
Beta: bitCash Trade (https://trade.bitcash.org)

Offline bitcrab

  • Committee member
  • Hero Member
  • *
  • Posts: 1928
    • View Profile
  • BitShares: bitcrab
  • GitHub: bitcrab
I have tested and found that now the force settlement feature is actually enabled for TCNY.

according to the design, force settlement/allow witness to provide feed features should both be disabled because of the change but actually not, this is another bug and when in the future the bug be fixed these features will be actually disabled for TCNY, right?

so I wonder whether there are ways to reserve these features for TCNY, as they are important for a smartcoin.




Email:bitcrab@qq.com

Offline clayop

  • Hero Member
  • *****
  • Posts: 2033
    • View Profile
    • Bitshares Korea
  • BitShares: clayop
Bump...
So how can resolve this problem?
Bitshares Korea - http://www.bitshares.kr
Vote for me and see Korean Bitshares community grows
delegate-clayop

Offline svk

The asset update in the GUI was never tested using bit assets since I have no idea what bits are used to create one, so most likely this is related to that.

I did try to ensure old flags and permissions were kept, but probably your asset had bits that the GUI ignored and so they were overwritten.

Whitelists are another matter, they are always empty as far as I can tell, it's a witness node bug, unrelated to the GUI.
Worker: dev.bitsharesblocks

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 4664
    • View Profile
    • Abit's Hive Blog
  • BitShares: abit
  • GitHub: abitmore
I believe there is big bug in the GUI asset update page.
today I found that 2 parameters of TCNY have been changed:

issuer_permissions: old:511 new:79
flag:old:128 new:0

after some checking I found what make this happen, in 23th Dec, I operate in GUI to change the owner of TCNY, after doing that, the unexpected change happened.

this can be proved with a test with no confirmation on TUSD, after changing the description and clicking update asset, below pop up:



issuer_permissions and flag are changed to 79 and 0.

this is big bug and may cause big issue, hope everyone be aware of this and this can be fixed asap.

now seems TCNY get unexpected change:

disabled force setting
disabled global force setting by issuer.
disabled confidential transactions
not allow witness/committee members to provide feeds

the worst is that all these features can not be enabled once disabled.

this is really a tragedy for TCNY. :'( , I need to consider how to handle it.
any suggestions?

A temporary solution for the price feeding issue would be manually white-list the ones who you want to have permissions to provide price feeds from the cli wallet for example:
Code: [Select]
update_asset_feed_producers TCNY [in.abit,dele-puppy] true

Perhaps here is another bug: nobody is in the white list now, but some witnesses are able to feed prices for TCNY but others not. Why?
BitShares committee member: abit
BitShares witness: in.abit

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12922
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc

Offline bitcrab

  • Committee member
  • Hero Member
  • *
  • Posts: 1928
    • View Profile
  • BitShares: bitcrab
  • GitHub: bitcrab
I believe there is big bug in the GUI asset update page.
today I found that 2 parameters of TCNY have been changed:

issuer_permissions: old:511 new:79
flag:old:128 new:0

after some checking I found what make this happen, in 23th Dec, I operate in GUI to change the owner of TCNY, after doing that, the unexpected change happened.

this can be proved with a test with no confirmation on TUSD, after changing the description and clicking update asset, below pop up:



issuer_permissions and flag are changed to 79 and 0.

this is big bug and may cause big issue, hope everyone be aware of this and this can be fixed asap.

now seems TCNY get unexpected change:

disabled force setting
disabled global force setting by issuer.
disabled confidential transactions
not allow witness/committee members to provide feeds

the worst is that all these features can not be enabled once disabled.

this is really a tragedy for TCNY. :'( , I need to consider how to handle it.
any suggestions?
Email:bitcrab@qq.com