3211
General Discussion / Re: Percentage based transfer fee [BSIP10] implemented
« on: January 25, 2016, 02:32:21 pm »A new field in "extensions". Please check the examples in OP for reference (haven't been reviewed so far, so don't rely on it right now).I don't foresee this needing a lot of GUI work, a day at most (a day being 8 hours). As long as there's a flag on the asset that says what type of fee to use, and only transfers are affected, it should be trivial to add a switch to whichever transfer operation type that asset uses.@svk Imo here is a list of work to be done in GUI:
Fees need a little bit of work but not a whole lot, assuming the percent fee structure is easily available either in the asset object or in global parameters. We estimate fees using the global parameters and the operation type, so that would need to be extended to handle percent fees but that's not hard. And final operation fees are fetched from the witness node so that should not require any work on the GUI.
* add an selection box on the "create asset" page and "update asset" page, so the issuer can set fee mode easily
* show transfer fee mode on asset details page, and maybe somewhere related
* use new operation to do all transfers (although the original operation can still be used on assets with flat mode)
* extend fee estimation to handle percent fees.
* the fee schedule page
Did I miss something?
I think Jakub will provide a document about data structure changes and API changes. Or you can dig into my code (after CNX reviewed)
Thanks for support!
OK.
How is the fee mode switched? Does it use the existing flags and permissions structure?
No permission involved so far.
Please let me know if I missed something. Thanks.