BitShares Forum

Main => General Discussion => Topic started by: nethyb on November 29, 2014, 03:42:09 am

Title: Caution! Has sparkles code been checked by a trusted BitShares dev
Post by: nethyb on November 29, 2014, 03:42:09 am

Given that at some point BitShares users will be importing their BTS/PTS and associated AGS private keys into the the sparkle client to claim their genesis sparkle.

Has a trusted BitShares dev review the code to ensure there are no security issues?

I'm sure everything is fine, just being cautious before I fire up the client.

Title: Re: Caution! Has sparkles code been checked by a trusted BitShares dev
Post by: toast on November 29, 2014, 04:16:48 am

Considering it's a test network I don't know why you'd import any private keys into it yet.

You can diff the two versions on github, I skimmed through it but won't say anything "official":   https://github.com/sparkle5/Sparkle/compare/BitShares:bitshares...sparkle

Title: Re: Caution! Has sparkles code been checked by a trusted BitShares dev
Post by: nethyb on November 29, 2014, 09:28:34 am

Thanks toast... I've use the compare link you shared to have a look myself  :)

Title: Re: Caution! Has sparkles code been checked by a trusted BitShares dev
Post by: santaclause102 on November 29, 2014, 12:19:12 pm

Is there any solution to the trusting a third party with your private keys problem?

Title: Re: Caution! Has sparkles code been checked by a trusted BitShares dev
Post by: pc on November 29, 2014, 02:49:04 pm

Quote from: delulo on November 29, 2014, 12:19:12 pm

Is there any solution to the trusting a third party with your private keys problem?

I have implemented a solution in our PTS-DPOS client: https://github.com/PTS-DPOS/PTS commits 23b76deba0fd49e1c9243e00f0015264593dd704 - a60e54c79199479d23285a4b2c5dccf380542870 . A general description is available here: http://pts.cubeconnex.com/index.php?topic=37.0 .
With some tweaking it should apply to the BTS master code.

No warranties etc., this is an alpha version that has seen little testing.