BitShares Forum

Main => Stakeholder Proposals => Topic started by: oxarbitrage on June 29, 2017, 06:35:26 pm

Title: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on June 29, 2017, 06:35:26 pm
Hi all, as some of you maybe already know by thread: https://bitsharestalk.org/index.php/topic,23698.0.html i had plans since a while on submitting my own worker proposal for the next half of 2017.

Proposal 1.14.55

Details at:

https://github.com/oxarbitrage/worker-proposals/blob/master/bitshares2017.md

I used @xeroc multisig scheme to get paid in bitusd. I am looking for escrows, this are respectable community members that will hold the funds and vest to worker making  the whole process more secure for everybody. is needed to have a few of them. if anyone want to be part of that please let me know, i will appreciate a lot.

i don't have idea if it will be accepted, lot of uncertainty on my side right now. but the only way to know i guess is trying so here it is.

Now the proposal is public the document no further change will be made. the only addition from now on is to add the escrow accounts.

Any question, suggestion, whatever please let me know.

Wish me luck, vote for it if you can, will not regret.

looking to make the second half of the 2017 more successful than the first with hard work :)

Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: fav on June 29, 2017, 07:30:54 pm
 +5%

supporting your worker!
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: Ashaman on June 29, 2017, 07:35:33 pm
 +5%

voted in favor
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: svk on June 29, 2017, 08:02:10 pm
You have my support as well! I can also help out as part of the multisig group.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: Murderistic on June 29, 2017, 08:07:43 pm
 +5%
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on June 29, 2017, 08:43:55 pm
thank you guys for the support, lets see how it goes in the next days :) very exited with the initial reactions.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: wackou on June 29, 2017, 09:56:58 pm
 +5% thank you very much for all the work you are doing for BitShares!
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: R on July 03, 2017, 12:00:35 am
You've got my vote! :)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: xeroc on July 04, 2017, 03:38:14 pm
+5%
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: Chronos on July 04, 2017, 04:05:21 pm
Thank you for your hard work!
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 04, 2017, 06:26:34 pm
thank you all guys for the support, i am still needing a lot of votes to get approved but i am working on it, hope i can make it :)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 04, 2017, 07:35:03 pm
added a total of 5 escrow accounts to worker proposal document, all good people, what a crew!

chainsquad
dev.bitsharesblocks
elmato
fox
lin9uxis

thanks to the 5 for supporting me!



Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: sahkan on July 04, 2017, 07:44:43 pm
Voted! But as a reminder to ALL BTS holders, anyone that supports this worker should head out to their "Voting page for workers" and vote on this proposed worker.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: blockchained on July 04, 2017, 07:52:12 pm
 +5%
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 07, 2017, 08:25:14 pm
Hello guys, as you may already know the worker proposal has enough votes now to be approved, this was not easy job to get the needed votes but it was a huge learning experience on how the bitshares community governance works and a confirmation that i am in good track with my work here.

It will be impossible for me to thank each of the persons i contacted and all that supported me throw getting this worker proposal passed. during the voting process i asked for help or advice to everyone i know inside this community. a big thanks to all.

The worker starts formally Jul 12 but i am already making work as usual. As the previous worker ended more than a month ago i never stopped the work. Money from the first worker with bitshares appreciation helped me finish a big house remodeling i was on for more than a year, this ended up yesterday with a brand new office for me just in time to start with the new worker in a lot more comfortable environment to face the new challenges ahead. In the last 2 weeks while submitting the new worker proposal and making the all the needed stuff to get voted in had me busy as well.

From now on with all that sorted lets get into some quick updates:

- i configured the alfredo-worker account with the multisig accounts from my escrows:
http://cryptofresh.com/u/alfredo-worker
the 5 escrows plus my account(oxarbitrage.a699) are in place as owner and active, each with the same weight.
threshold of 4 from the total of 6 accounts is needed to move any fund.

i think 4 accounts(me + 3) from 6 is good enough to approve a transaction just in case some of the escrow is on vacation or unreachable but if anyone think this should be different please let me know.

- updates of work done will be posted in this thread once a week every weekend starting with this next weekend.

- working in a roadmap for the open source explorer project that could bring a clear picture to he community of how long we will have something usable and what to expect.

Again thanks to all  your for your support and any question, suggestion, comment please just let me know.

Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: pc on July 09, 2017, 12:54:28 pm
Since you're now (or will soon be) the officially employed core developer, may I suggest a few things:

* We should apply a proper development process on the github repo, like gitflow. Currently, everything goes right into master, which is generally a bad idea.
* Perhaps we should integrate @xeroc's testnet branch into the main repo.
* Create a set of rules for development, like
1. PR's are always to be made against develop.
2. PR's have to be ACKed by at least two "important" devs (apart from the submitter).
3. Merging develop into master is only allowed after develop has been tested successfully in testnet.
4. Merging into master requires ACK from at least three "important" devs.
(where an "important" dev is someone who has shown sufficient knowledge of the codebase, for example by submitting PRs).
* Create a set of rules for releases, especially wrt time frames in the case of a hard fork.
* Back in BTS-1 I set up an automatic build process complete with generation of test coverage metrics and the like. PRs should only be accepted if they fulfill certain quality metrics. Perhaps set up https://about.sonarcloud.io/ or something like that?

IMO we need to get more professional.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 09, 2017, 01:38:02 pm
thank you for the post @pc , i agree with everything you stated. i want to ask here if i can get privileges in the bitshares repos as i currently don't have any. i will like to create branch, add people to tasks, add tags to issues, close issues, review pull requests, etc.

Quote
* We should apply a proper development process on the github repo, like gitflow. Currently, everything goes right into master, which is generally a bad idea.

i agree fully with this, pull requests against master directly is not a good idea, it saves time but it is unprofessional. gitflows seems to be the way to have feature branches, versioned releases and such. it will bring our code to a next level.

Quote
* Perhaps we should integrate @xeroc's testnet branch into the main repo.

Can  take care if i can get the privs, i know you had synchronized this project for xeroc so we should do that now.

Quote
* Create a set of rules for development, like
1. PR's are always to be made against develop.
2. PR's have to be ACKed by at least two "important" devs (apart from the submitter).
3. Merging develop into master is only allowed after develop has been tested successfully in testnet.
4. Merging into master requires ACK from at least three "important" devs.
(where an "important" dev is someone who has shown sufficient knowledge of the codebase, for example by submitting PRs).

i agree with the rules and with the testnet step. i think the "important" devs active now are:
- @pc
- @ElMato
- @abit
- @xeroc
- @oxarbitrage

so if one of this members is submitting a pull request i think it should be maybe 1 approve to the dev branch and 2 to the master until we have at least one more active "important" member. if the requester is from outside this 5 numbers then he is going to need approve by 2 of the main members to add to the dev and 3 to the master.

Quote
* Create a set of rules for releases, especially wrt time frames in the case of a hard fork.

i am not sure if this will be an example of this but the last release doc made by @abit had missing important upgrades that were made. if we do all code in dev branches we can create versioned releases when we agree that enough or significant changes were made. this way all code between release and release will be added at once and nothing will be missed in the release doc. let me know if that is the idea.

Quote
* Back in BTS-1 I set up an automatic build process complete with generation of test coverage metrics and the like. PRs should only be accepted if they fulfill certain quality metrics. Perhaps set up https://about.sonarcloud.io/ or something like that?

sounds interesting as well, i never tried but i was taking a quick look to sonarcloud, looks good to consider. i will give a further look at it and get back here to talk about it.

your ideas for this @pc are very good and very inline with i was thinking to propose specially in code approval and development branches. gitflow helps in the process by managing feature branches organized, i think that is just what we need.

Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 09, 2017, 08:41:33 pm
Here are some updates of last week github issues of the bitshares core that i worked on:

- https://github.com/bitshares/bitshares-core/issues/322
help xeroc to subscribe after changes made in #231.

- https://github.com/bitshares/bitshares-core/issues/323
open ticket with polo in order to fix this problem. the error has now gone but not response from polo side yet.

- https://github.com/bitshares/bitshares-core/issues/320
helping user with installation in slackware.

- https://github.com/bitshares/bitshares-core/issues/29
in order to get started the organizing efforts of the bitshares code i identified and make a task list of all the TODO inside the core code.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 16, 2017, 09:27:15 pm
Folks, as usual here are the last github issues and other areas i was working on during the last week:

- created "develop" branch to bitshares-core. this is part of our efforts to professionalize the development in bitshares. all pull requests(except for very special cases exceptions) will go into this branch before going to the master. develop branch is less rigorous in merging of code than the master. this will encourage new pull requests from outside developers while will introduce less buggy and more tested code into the main branch.

- https://github.com/bitshares/bitshares-core/issues/325

this issue was opened to find root cause and to fix future problems after the crash in the network we had Monday. as soon as @abit noticed the problem and posted in the telegram developer channel a huge effort started from devs, witnesses, community members controlling public opinion and others to get the network up again. this problem exposed the very fast and big response team the bitshares community haves to handle critical situations, a big thanks to everything who participated in the recovery at any level.

@pc found the root cause in a bad proposal sent to the network, the technical details are in the issue. he also created a test unit and pulled to the develop branch:
https://github.com/bitshares/bitshares-core/pull/326
i tested and merged the pull request.

as the original problem is in the use of flat_index containers in our code, we all agree that we need to remove the other flat_indexes in our repo to avoid any future problem of the same kind. the only flat_index left is at block_summary_object. i am in the process of replacing this index in the code but i am having some problems and got stuck. as there is so many things to do and i don't want to stay too much time in the same thing i asked some advice today to @ElMato. he will review, in case problems remain there are other community members that may help just as @pc or @abit, the community is pretty rich to ask technical advice.

more updates on this issue will be posted to issue #326 and a pull request with the changed index as well.

- https://github.com/bitshares/bitshares-core/issues/329

closed issue helping to get the data needed with current api calls.

- https://github.com/bitshares/bitshares-core/issues/328

self assigned issue, this should be an easy one, i will upload patch tomorrow(monday).

- http://bitshares-explorer.io:9009/#/dashboard

resuming the work in the explorer, I have a huge TODO list that will be converted to a roadmap, trying to put everything inside a 4 weeks period to have a first version open source released in 1 month.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 24, 2017, 12:26:51 am
Folks, the following are the last github issues and contributions made by this worker during the last week in the bitshares network:

- https://github.com/bitshares/bitshares-core/issues/328
discussed, implemented, tested, merged and closed.

- https://github.com/bitshares/bitshares-core/issues/325
i am having some problems with this one, i sent it to @pc who will take a look in the next days. i think he may be the right person to change the flat_index we have left. i may came back to it if he can't make it but i had to move on.

- https://github.com/bitshares/bitshares-core/issues/331
reproduced the problem, sent instructions to issuer. accepted suggestion of log msg for api-access file and made pull request here:  https://github.com/bitshares/bitshares-core/pull/332 , changed main README to clarify how to use thie api-access file, sent changes to documentation at: https://github.com/BitSharesEurope/docs.bitshares.eu/pull/12

the idea is to make the documentation repo more active and update it with pull requests as errors/changes are found. please any documentation issue in http://docs.bitshares.org/ submit a pull request to the docs repo or just point it to me and i will do it.

- new pull request: https://github.com/bitshares/bitshares-core/pull/334 for issue https://github.com/bitshares/bitshares-core/issues/298 , this is a replace of pull https://github.com/bitshares/bitshares-core/pull/305

- explorer 1 month roadmap. still on it, will try to release the roadmap Monday to get the project resumed this starting week.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: pc on July 24, 2017, 09:03:32 am
- https://github.com/bitshares/bitshares-core/issues/325
i am having some problems with this one, i sent it to @pc who will take a look in the next days. i think he may be the right person to change the flat_index we have left. i may came back to it if he can't make it but i had to move on.

I've created a PR on your personal repo: https://github.com/oxarbitrage/bitshares-core/pulls
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 24, 2017, 02:07:35 pm
- https://github.com/bitshares/bitshares-core/issues/325
i am having some problems with this one, i sent it to @pc who will take a look in the next days. i think he may be the right person to change the flat_index we have left. i may came back to it if he can't make it but i had to move on.

I've created a PR on your personal repo: https://github.com/oxarbitrage/bitshares-core/pulls


awesome, thanks, i am testing it now and ill send it to bitshares. very appreciated. lets continue with it in the github. many thanks again :)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on July 31, 2017, 09:39:12 pm
Hello Bitshares community, i was not able to post the weekly report of the worker during the weekend so i am posting it today Monday for work done last week.

- https://github.com/bitshares/bitshares-core/pull/335

i requested the help of peter conrad(@pc) to solving this issue. he made a patch into my repo, i just pulled it to bitshares and finally merged to the develop branch after testing.

issue will be closed in 24 hours if there is no objections as the problem is solved: https://github.com/bitshares/bitshares-core/issues/325

- https://github.com/bitshares/bitshares-core/issues/329

at this issue i sent instructions to the issuer on how to do what he was trying to do with what was currently available. issue was closed and later reopened requesting a small modification in the get_trade_history results.

request was considered and patch was sent to the bitshares develop branch:
https://github.com/bitshares/bitshares-core/pull/344

this is now under review of the bitshares developer community.

- https://github.com/bitshares/bitshares-core/pull/336

in this patch submitted by peter conrad part of the problem of issue 303(https://github.com/bitshares/bitshares-core/issues/303) gets solved. the issue in the node output is fixed with the patch but the unit tests are not. trying to make a fix to both cases before approving it.

- https://github.com/bitshares/bitshares-core/pull/332

changes were made to patch to consider when api-access file does not exist in the filesystem.
this is for issue https://github.com/bitshares/bitshares-core/issues/331 that will be closed in 24 hs if there are no objections.

- Explorer TODO: https://github.com/oxarbitrage/bitshares-explorer/blob/master/TODO.md and roadmap for a 1 month plan has been released: https://github.com/oxarbitrage/bitshares-explorer/blob/master/Roadmap1.md

Also in the past week some of the checked items in the TODO were done.

Finally, there is a lot of stuff going on with implementation of bsip-018, the bitshares hardfork and a recent steem post that introduced some new(and some not so new) issues in the chain. I am currently working at some of this but no enough advances to put it in the report, more on this next week.

thank you very much for reading ;)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: fav on August 03, 2017, 04:24:51 pm
any chance to focus on a working block explorer first? 

cryptofresh seems to be gone for good now
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on August 05, 2017, 01:53:07 pm
trying to put more effort to the explorer to have v1 faster as i am aware of the repeated problems of cryptofresh in the last time.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on August 07, 2017, 03:00:46 pm
Hello bitshares community, here is a list of work done by this worker in the last week.

bitshares core:

- https://github.com/bitshares/bitshares-core/issues/329
added side1 and side2 account ids of the trade at pull : https://github.com/bitshares/bitshares-core/pull/344 - merged and closed the issue.

- https://github.com/bitshares/bitshares-core/issues/168
@takaaki7 submitted pull request to fix this issue. pull is at: https://github.com/bitshares/bitshares-core/pull/347 i tested and merged the pull and closed the issue.

special thanks to @takaaki7 who started to collaborate in the bitshares-core development in a good way.

- https://github.com/bitshares/bitshares-core/pull/339
@pc has submitted a pull request that will reduce the "unclean shutdowns" and full replay restart in  nodes by trying to save and use the most data possible from existing chain and log. this is being fully tested and improved, can read more in the pull conversation. we expect to merge a final solution very soon.

- https://github.com/bitshares/bitshares-core/pull/288
after fully testing all the aspects of this pull from @pc we decided with @abit it was ready enough  to merge so we did it. this new code allows to start nodes with a --plugin parameter that will load the witness with only the required combinations of plugs.

explorer:

i am putting more effort on the explorer v1 as some shareholders requested more speed on the project due to repeated problems with cryptofresh. current TODO is at 60% done, new plan is to be at 80% for the next report in 1 week. please check the TODO online file to see progress of version 1:

https://github.com/oxarbitrage/bitshares-explorer/blob/master/TODO.md

additions and suggestions for v2 will be considered and added to v2 file: https://github.com/oxarbitrage/bitshares-explorer/blob/master/TODO2.md
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on August 15, 2017, 03:21:42 pm
Hello all, here is the tasks this worker made on the last week until Sunday 13-08.

- https://github.com/bitshares/bitshares-core/pull/334
conflicts resolved and merged. related issue was closed https://github.com/bitshares/bitshares-core/issues/298

- https://github.com/bitshares/bitshares-core/pull/352
some additional calls for workers and committee members were added to the node, needed by the explorer and useful(i hope) for some others. there are a few changes that will need to be done to merge them to bitshares.

- https://github.com/bitshares/bitshares-core/pull/336
merged pull to remove msg from witness node by peter conrad.

- https://github.com/bitshares/bitshares-core/pull/337
merged hardfork cleanup by peter conrad.

- created milestone for next hardforks: https://github.com/bitshares/bitshares-core/milestones

- explorer: i was expecting to be at 80% of the TODO but i am actually at 73%(https://github.com/oxarbitrage/bitshares-explorer/blob/master/TODO.md). A bit behind the expected, i plan now to be at 90% from the next report and very close to release.

Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on August 29, 2017, 05:21:29 am
Hello shareholders, it has been 2 weeks since last report. I realized today that last week i didn't made it, was and still very busy working but that's no excuse, i should write it weekly, is even easier for me.

My apologies for that and i will try to don't do the same again. Anyways, the report today includes the last 15 days of work by this worker.

Bitshares Core Tasks:

- https://github.com/bitshares/bitshares-core/issues/358 -> work in progress, have a solution, will pull tomorrow.

- https://github.com/bitshares/bitshares-core/issues/355 -> i have an old machine 32 bits to test compilation, i remember i tested it a long time ago and didn't worked for me but don't remember the reason.

- https://github.com/bitshares/bitshares-core/issues/361 -> closed.

- https://github.com/bitshares/bitshares-core/pull/352 -> made requested changes, merged.

- https://github.com/bitshares/bitshares-core/issues/367 -> opened issue about error caused by one of the last merges. @pc identified the cause of the problem and submitted a patch: https://github.com/bitshares/bitshares-core/pull/368 -> works good now, merged patch.

- https://github.com/bitshares/bitshares-core/issues/295 Closed. Made additional changes to core to solve this issue, this are at pull: https://github.com/bitshares/bitshares-core/pull/364
Issue was opened in the UI to make a warning when subscriptions to accounts its passing 100: https://github.com/bitshares/bitshares-ui/issues/299 -> issue was closed by @svk as this will be handled different in the upcoming GUI release.

- https://github.com/bitshares/bitshares-core/pull/373 -> adding 2 new calls to work with transactions hashes from the api. first call was easy but the second i want to make need more bigger changes. work in progress, i have a working prototype, new commits will be added to introduce the second call in the next days.

- https://github.com/bitshares/bitshares-core/issues/375 -> unrelated, replied and closed.

- https://github.com/bitshares/bitshares-core/pull/345 -> tested and merged.

reviewing now:

- https://github.com/bitshares/bitshares-core/pull/376 -> testing.
- https://github.com/bitshares/bitshares-core/pull/341 -> testing, the log message is fine to identify the problem, the tests cases are a bit unclear still. more review needed before merging, i have to check with @alexpmorris.
- https://github.com/bitshares/bitshares-core/pull/348 (HF) -> testing hardfork with the debug node.
- https://github.com/bitshares/bitshares-core/pull/369 (HF) -> testing hardfork with the debug node.

Explorer:

Today it is the deadline of a very rough estimate i made for the explorer of 1 month, plan was to have all the TODO tasks of the explorer finished:

https://github.com/oxarbitrage/bitshares-explorer/blob/master/Roadmap1.md

https://github.com/oxarbitrage/bitshares-explorer/blob/master/TODO.md

The TODO is right now at 90%. The reason it is not at 100% today are a few:

- there is also a TODO 2 where some tasks were made: https://github.com/oxarbitrage/bitshares-explorer/blob/master/TODO2.md
- the estimate was rough and some tasks required more time.
- some tasks not included in TODO1 and TODO2 had to be done.

The remaining 10% of the TODO1 is just cleanup, performance and code disclosure.

All the features and sections of the explorer are working*, i encourage to visit one more time: http://bitshares-explorer.io:9009/
Performance will increase as i remove all the crap and package it for distribution, it haves some problems but it is fully functional.

* Only section not working is transactions section(http://bitshares-explorer.io:9009/#/txs) but that is not part of TODO1.Trying to first add some code to the core in order to achieve transactions section and search.

As it was previously mentioned, the project is 2 repos.

https://github.com/oxarbitrage/bitshares-python-api-backend -> api python backend serving the explorer website only at the moment but can serve other applications. Public and fully updated.

https://github.com/oxarbitrage/bitshares-explorer

To release the code of the explorer part, with all the cleaning and stuff i have to do, i think i am going to need 1 week more.

Others:

Upticks:

https://github.com/xeroc/python-bitshares/issues/10

Docs.Bitshares.Org:

https://github.com/bitshares/docs.bitshares.org/pull/16

Bitshares.GitHub.IO:

to be merged after next release of bitshares UI:
https://github.com/bitshares/bitshares.github.io/pull/108

SonarCloud:

https://sonarcloud.io/dashboard?id=BitShares-develop%3Adevelop

taking the opportunity to mention that @pc added our develop bitshares-core branch, this will allow to improve code quality. For a huge project like bitshares the code quality ratings are pretty impressive.

Until next week, thanks for taking the time of reading :)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on September 04, 2017, 11:10:27 pm
bitshares-core:

- https://github.com/bitshares/bitshares-core/issues/358 - work in progress here, need changes: https://github.com/bitshares/bitshares-core/pull/379
- https://github.com/bitshares/bitshares-core/issues/388 - samples and links provided. closed issue.

hardfork reviews:

we are in the process of merging code for 4 hardforks to the develop branch, 1 main and 3 smaller bug fixes.

- https://github.com/bitshares/bitshares-core/pull/386 - tested, reviewed and approved.
- https://github.com/bitshares/bitshares-core/pull/369 - tested, reviewed and approved.
- https://github.com/bitshares/bitshares-core/pull/348 - tested, reviewed and approved.
- https://github.com/bitshares/bitshares-core/pull/340 - this is the main hardfork, is under review and testing now.

please note that hardfork will be also tested in a testnet before production release.

explorer:

released first production version at :

http://bitshares-explorer.io

this week efforts in the explorer will be to display all operation history in the accounts page, something the community is needing since a while.

documentation:

- https://github.com/bitshares/bitshares-core/issues/378 - wiki page created https://github.com/bitshares/bitshares-core/wiki/Memory-reduction-for-nodes , sent pull request to link it at main README: https://github.com/bitshares/bitshares-core/pull/391 and https://github.com/bitshares/docs.bitshares.org/pull/17
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: Brekyrself on September 07, 2017, 07:24:28 pm
Thanks for the consistent updates.  Any opinion on this feature being discussed for a future core project? https://github.com/bitshares/bitshares-ui/issues/356
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on September 11, 2017, 08:49:32 pm
Thanks for the consistent updates.  Any opinion on this feature being discussed for a future core project? https://github.com/bitshares/bitshares-ui/issues/356
you can submit the issue to the bitshares-core at: https://github.com/bitshares/bitshares-core/issues and we will consider it however as it needs a hardfork it is going to be hard to see it done in a short period of time. please note we are after a hardfork now and this is not something that happen very often. @svk comments it is also big work, that decrease even further the possibilities of materializing it as it will need to be done throw a bsip(https://github.com/bitshares/bsips). still, if you can convince an important number of people(shareholders) that this is important then it will eventually be done.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on September 19, 2017, 02:06:53 am
folks, 2 weeks has passed since my last report, here is a summary of the last work done.

bitshares core:

all the pull requests with hardfork were reviewed and merged to the develop branch. @pc later updated the testnet based on this branch.

- https://github.com/bitshares/bitshares-core/pull/386 - merged.
- https://github.com/bitshares/bitshares-core/pull/369 -  merged.
- https://github.com/bitshares/bitshares-core/pull/348 - merged.
- https://github.com/bitshares/bitshares-core/pull/340 -  merged.

https://github.com/bitshares/bitshares-core/issues/390

sent link to new documentation of memory reduction techniques and closed the issue.

https://github.com/bitshares/bitshares-core/pull/391

a few more changes were made to the documentation to reflect memory size.  merged pull.

https://github.com/bitshares/bitshares-core/pull/339

after some additional testing the pull by peter conrad was merged.

https://github.com/bitshares/bitshares-core/pull/346

requested @xeroc to fix the conflicts, now pull under review by me for a possible merge into the develop , can be a good starting point to develop plugins for newcomers.

https://github.com/bitshares/bitshares-core/pull/392

reviewed and merge this small fixes and cleanup by peter conrad.

https://github.com/bitshares/bitshares-core/issues/395

assistance provided for build issues, problem was fixed, closed the issue.

https://github.com/bitshares/bitshares-core/issues/396

removed header in pull request: https://github.com/bitshares/bitshares-core/pull/397 merged and closed issue.

https://github.com/bitshares/bitshares-core/pull/398

tested and merged patch by peter.

https://github.com/bitshares/bitshares-core/pull/379

a new solution has been proposed in this pull request to access some needed blockchain data without spending any additional ram. this was a very big research work. i can say that i spent almost the last entire week working on this solution that i hope can be approved by the other devs as it can bring additional features to our api calls not currently possible. i am not really sure of the future of this pull request(if it will be accepted or not) but what learned in the process is invaluable.

note will upload the proposed solution tomorrow morning as i found a small bug i want to fix before pulling. will update here when it is up.

https://github.com/bitshares/bitshares-core/issues/355

this was also a time consuming task. i was able to confirm bitshares-core full project compiles in a 32 bits ubuntu system even if in production this is pretty much useless it can be of interest for private blockchains or testnets. closed the issue.

explorer:

the main issues the explorer was having was the possibility to browse all user history, this has been added and it is fully supported with the help of a full node provided by @xeroc. the other main problem was that the explorer service was crashing with high traffic, this was fixed, it can still be improved further but it is working better now.

issues are open for the explorer at https://github.com/oxarbitrage/bitshares-explorer/issues and will be added to this report as thye get resolved.

i plan to spend significant time this week in the explorer to keep improving it as it is gaining traffic and it is having great feedback. now that the hardfork code was merged in the core and that very time consuming advances had been made at pull 379 the idea is to have more time for it this week.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: pc on September 19, 2017, 03:16:27 pm
Thanks Alfredo! You help with the release preparations, and your testing have been very valuable! Good Job!
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on September 29, 2017, 01:31:33 am
Adding a report now with the work from the last 1 week and a half. I am posting it today as i am going out for a small trip tomorrow and i'll be back Tuesday next week. I am going to Buenos Aires for family issues but also going to meet @ElMato and i have the luck that this Saturday there is an EOS event, ill be there ;)

bitshares-core:

- https://github.com/bitshares/bitshares-core/issues/108 -> closing UI related issue after asking @svk and @wmbutler , old issue, not a problem anymore.
- https://github.com/bitshares/bitshares-core/issues/403 -> assigned myself the issue, made some initial research but the bulk of the work will be done next week to change index.
- https://github.com/bitshares/bitshares-core/issues/75 -> located documentation confirming the operation will delete and not refuse to sign, also found line where proposal is deleted from the blockchain. @abit mentioned another issue with the implementation but will be discussed in  new issue, closing this one.
- https://github.com/bitshares/bitshares-core/issues/409 -> helping with build issues in ubuntu 17.10.
- https://github.com/bitshares/bitshares-core/issues/265 -> added pull request for the issue at: https://github.com/bitshares/bitshares-core/pull/406 -> under review by  the team now.
- merged seed addition https://github.com/bitshares/bitshares-core/pull/400/files
- merged documentation change by @abit https://github.com/bitshares/bitshares-core/pull/401
- https://github.com/bitshares/bitshares-core/issues/390 ->  closed issue

- https://github.com/bitshares/bitshares-core/pull/405 -> new pull request was made to resolve the issue of the get account history by date and trying to build a framework to solve other issues that require similar actions. we are unsure on how we will proceed, options haves been presented and it is in discussion with the bitshares dev community.

explorer:

- big improvements were made to the assets page with the guide of @tbone https://github.com/bitshares/bitshares-core/issues/390
- https://github.com/oxarbitrage/bitshares-explorer/issues/3 -> done and closed issue.

- explorer server was hacked this week, mainly because i have other sites, old sites in the same server. i had a hard time to restore it.  @wmbutler has sent me an instance to run the explorer, and it will be moved there next week. thank you very much @wmbutler !
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on October 14, 2017, 01:29:13 pm
I am probably missing stuff, need to go back to reports every 1 week instead of 2!

bitshares-core:

- https://github.com/bitshares/bitshares-core/issues/411 - @dnotestein pointed us to a few commits made to the steem p2p code that will improve the operation of bitshares node. @xeroc made a cherrypick of the steem code(https://github.com/bitshares/bitshares-core/pull/412) that saved a lot of time than making this changes manually. Tested a full resync and the code worked fine so the solution was marged and the issue closed.

- https://github.com/bitshares/bitshares-core/pull/406 - code was made to fix issue https://github.com/bitshares/bitshares-core/issues/265 - need testing before merging and issue closing.

- https://github.com/bitshares/bitshares-core/pull/415 - We want to reduce ram in new installations without interfacing with existing business. @xeroc made some changes, i reviewed and approved but then @pc found some problems so we reverted back until this is fixed.

- @pc found some problem with a unit test of account_history when making the last testing for the next release. We fixed the issue here: https://github.com/bitshares/bitshares-core/pull/420 - merged.

- I started to work on a plugin that will allow to reduce full node ram usage by storing the history of accounts in the database(elasticsearch). At the same time it will solve several relational issues in searching in the account history in an efficient way. This is a big and time consuming task, more updates in this post on the next report.

explorer:

explorer is going slow but good, as cryptofresh has been working fine after the server change i dont have the preassure of being the only working explorer so i am focusing on having more stats suggested by the community i nthe form of issues.

- almost all the changes requested by @tbone were made to the assets page. part of the discussion can be found in the assets page issue at : http://bitshares-explorer.io/#/assets
closing the issue by now.

- https://github.com/oxarbitrage/bitshares-explorer/issues/11 changes were made to the individual asset page as: http://bitshares-explorer.io/#/assets/1.3.1152 closed the issue.

- https://github.com/oxarbitrage/bitshares-explorer/issues/7 fixed as part of the assets page work. closed.

- https://github.com/oxarbitrage/bitshares-explorer/issues/9 working on account page issues, not moved to production yet but can see progress in the develop version: http://bitshares-explorer.io:9009/#/accounts/1.2.121
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: Brekyrself on October 14, 2017, 03:51:46 pm
Thanks for the update. 

-Any idea how 3rd parties are notified about changes such as issue 411/412?  This could be a reason why Bittrex delisted BTS?
-Will you come up with a release schedule such as bi-weekly or monthly to provide new versions with all these fixes?
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on October 16, 2017, 09:31:55 pm
Thanks for the update. 

-Any idea how 3rd parties are notified about changes such as issue 411/412?  This could be a reason why Bittrex delisted BTS?
-Will you come up with a release schedule such as bi-weekly or monthly to provide new versions with all these fixes?

For the first point the fix will be included in the next release @pc is preparing among all the other fixes/changes that were done since the last release. There is a witnesses telegram channel, i am not member of it as i am not a witness but pretty sure the p2p issue is being discussed there. I honestly have no idea at this moment why bittrex delisted bts, not even know if it was due a technical aspect or something else.

In regards to a release schedule it actually depends on how much code was inserted and what is the importance of changes to make a release. In the case of the current release we are working on, it toke a lot more time than preferred but the reason for that is that there is a hardfork. Releases with hardfork are harder to implement than releases without it.
Please note that in the past we were merging all new code directly to master branch, this changed and now all the new code go into a develop branch, when the develop branch haves enough or significant changes they get merged to master with a release.
This new extra step is better for all as the develop branch haves more time to be tested and less bugs will be introduced to master but it haves the problem of giving an impression to outsiders that no commit was done since the last release long time ago. The extra step of the develop branch is here to stay but merges to master should be ideally more often(like around 1 a month). Exact estimates on when a new release will be out is not a very good strategy, if there are not enough changes there is no point on making a release just to be on a expected timeframe.

Hope it helps clarify something :)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: Brekyrself on October 17, 2017, 01:06:28 am
Where is the develop branch located on github so we can see the commits etc..?

Thanks again for your hard work making BTS better!
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on October 17, 2017, 01:55:01 pm
https://github.com/bitshares/bitshares-core/tree/develop

if you check the commits: https://github.com/bitshares/bitshares-core/commits/develop the last commit in master is from July 10(on page 4 currently). everything from there up to today is what will be included into the next bitshares-core release.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: vanterpool7 on October 22, 2017, 06:47:52 pm
 >:(alfredo Garcia
nesecito ayuda mi hermano conquien puedo hablar para arreglar algo en mi cuenta de bitsheres , sucede que traferi desde mi cuenta de coinbase , $523.00 dollares y lo tenia en mi cuenta y sucede que hacen dos dias le di a a lago que sellama withdrawal y  derepende mi dinero se de saparecio y ahora aparece en una cuenta que sellama openledger-wallet  pero quiero tranferir a mi cuenta y no me deja ahora cadave que quiero tranferir no puede por que medice que nesecito una authorisacion no se de quien y nesecito sacar mi dinero no me gusta ested systema de verda que no . porfavor te agradeseria su conce de alguien que me pueda ayudaR PORFAVOR , ME PUEDE escribir a mi correo esv-ministry@hotmail.com
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on October 23, 2017, 02:22:59 pm
>:(alfredo Garcia
nesecito ayuda mi hermano conquien puedo hablar para arreglar algo en mi cuenta de bitsheres , sucede que traferi desde mi cuenta de coinbase , $523.00 dollares y lo tenia en mi cuenta y sucede que hacen dos dias le di a a lago que sellama withdrawal y  derepende mi dinero se de saparecio y ahora aparece en una cuenta que sellama openledger-wallet  pero quiero tranferir a mi cuenta y no me deja ahora cadave que quiero tranferir no puede por que medice que nesecito una authorisacion no se de quien y nesecito sacar mi dinero no me gusta ested systema de verda que no . porfavor te agradeseria su conce de alguien que me pueda ayudaR PORFAVOR , ME PUEDE escribir a mi correo esv-ministry@hotmail.com


parece ser algún problema específico con openledger. proba en el telegram de openledger en español si no sabes nada de ingles: https://telegram.me/OpenLedgerESP
cualquier cosa enviame un mensaje privado ya que este no es el lugar para estas consultas en ningún idioma.

//////////// guy having an issue with a withdraw using openledger, sent him to openledger support telegram in spanish. out of topic for the thread.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on October 31, 2017, 12:04:42 am
Release, we did.

https://github.com/bitshares/bitshares-core/releases

After a lot of testing in our 3 branches(develop - testnet - master) we tagged a new release. This is the work of contributors on the last 3 months featuring lot of great work by @pc. thank you for all the work done in this time.

A special mention in the release are some last minute changes like the default config code: https://github.com/bitshares/bitshares-core/pull/422 and the asset creation fee issue https://github.com/bitshares/bitshares-core/issues/433 - https://github.com/bitshares/bitshares-core/issues/429 . For this last issue we replicated the problem in the testnet then a patch in the form of softfork was added by @abit and finally @pc made a definitive solution that was added to the release at the last minute.

Another last minute addition was a new plugin @pc created while fixing 429-433 https://github.com/bitshares/bitshares-core/pull/437
this is a snapshot plugin that allow the user to create a full json formatted file that includes all the indexes from the entire blockchain at a selected block or date.

Many other last minute changes were added, check the release page for the details on whats included, the amount of work testing to make candidate, pre release and release was very significant but it is finally available.

The following issues are after release or non related to it:

- https://github.com/bitshares/bitshares-core/issues/431 - closed.
- https://github.com/bitshares/bitshares-core/issues/439 - closed - fix here: https://github.com/bitshares/bitshares-core/pull/440

- https://github.com/bitshares/bitshares-core/pull/444 - version1 of elasticsearch plugin and documentation https://github.com/oxarbitrage/worker-proposals/blob/master/elasticsearch-plugin.md

This is a very needed plugin that will allow to close many issues related to the API and to run full nodes without all the RAM currently needed. V1 is a fully working version but it needs a lot of fine tuning before a merge. I already got the needed feedback to do this from the other bitshares devs and now the fine tuning is in process. Most of my work will be here in the next few weeks.

- Explorer - with the release and the elasticsearch plugin i was very focused in the core and left explorer abandoned a bit. Still some small progress was made in the assets page: http://bitshares-explorer.io/#/assets, in the account page: http://bitshares-explorer.io/#/accounts/1.2.121 and in the market page: http://bitshares-explorer.io/#/markets/CNY/BTS
Ill try to revamp it this next weeks now that the release passed and the heavy work in the elasticsearch plugin too specially starting by adding referral stuff to the explorer https://github.com/oxarbitrage/bitshares-explorer/issues/6 ,  do some of the last requested changes at the assets page https://github.com/oxarbitrage/bitshares-explorer/issues/2 and https://github.com/oxarbitrage/bitshares-explorer/issues/1
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on November 15, 2017, 04:31:25 pm
Fellows, here the pull requests, issues, etc i was working on in the last 2 weeks:

bitshares-core:

- moved discussion about new features of worker proposal into a BSIP created by @billbutler at https://github.com/bitshares/bsips/blob/master/bsip-0028.md. We closed https://github.com/bitshares/bitshares-core/issues/451 and https://github.com/bitshares/bitshares-core/issues/473 from the core discussions. Sent pull request to update technical aspects of the new BSIP: https://github.com/bitshares/bsips/pull/41

- https://github.com/bitshares/bitshares-core/issues/465 - added pull to include 15 mins, 30 mins and 4hs buckets, removing 15 seconds: https://github.com/bitshares/bitshares-core/pull/466

- https://github.com/bitshares/bitshares-core/issues/403 reviewed @abit code at https://github.com/bitshares/bitshares-core/pull/464, after some error fix we merged.

- opened issue https://github.com/bitshares/bitshares-core/issues/452 for referral index. found bug when exploring referral available code for explorer. no fix yet - relative low priority as client can still loop throw all accounts.

- https://github.com/bitshares/bitshares-core/pull/444 - after a lot of work the elasticsearch plugin has been finally merged to the develop branch.

- https://github.com/bitshares/bitshares-core/pull/471 - added code to allow plugins to have descriptions. merged.

- https://github.com/bitshares/bitshares-core/issues/476 - add curl as dependecy to documentation : https://github.com/bitshares/docs.bitshares.org/pull/22/files and https://github.com/bitshares/bitshares-core/pull/477

- reviewed and merged https://github.com/bitshares/bitshares-core/pull/479 to fix https://github.com/bitshares/bitshares-core/issues/409 (doxygen issue with last stable debian)

- https://github.com/bitshares/bitshares-core/issues/449 - tested, setted up tmp public node for interested parties to test in. changes were merged and the chart data from the core does not need any filtering anymore. can see it working at: http://bitshares-explorer.io/#/markets/CNY/BTS

- merged docker files from @xeroc https://github.com/bitshares/bitshares-core/pull/482

bitshares-fc:

- a pull request was submitted to FC to make bitshares project compile with newer version of boost(up to 1.63) https://github.com/bitshares/bitshares-fc/pull/5 - after testing we merged the solution.

- another pull address the compile problem of GCC 7.2. merged solution also: https://github.com/bitshares/bitshares-fc/pull/6

- @abit made the needed changes to reflect the new changes from bitshares-fc into bitshares-core. Tested and merged the whole solution: https://github.com/bitshares/bitshares-core/pull/483

- added documentation to include new supported versions of boost at https://github.com/bitshares/bitshares-core/wiki and https://github.com/bitshares/bitshares-core/pull/486

explorer:

- An issue in the explorer was making the python interface to crash when too much traffic are browsing the explorer at the same time. I was able to change the configuration of the backend to run under Nginx and with 4 processes. The explorer has been stable for the last 3 days with no crash so i hope this will be the end of this problem but i can add more processes if needed.

- i requested an increase of HD in one of the explorer servers as i need to run 2 nodes at the same time in the near future. One will serve what it is currently serving while the other will have elasticsearch plugin that will allow to bring lot of new features to the explorer. While everything could be done with 1 node with ES loaded it will be better if we keep current funcionality working so there is going to be a period of time while both nodes will be used.

- fixed chart data with new core changes, market charts now look as they should: http://bitshares-explorer.io/#/markets/CNY/BTS without any filtering client side. https://github.com/oxarbitrage/bitshares-python-api-backend/commit/34d87ebe5b4daa9418e9c0d6e86bae53adf9df85

- added referral information to account page(http://bitshares-explorer.io:9009/#/accounts/fav). Information includes by now count of referrals and account names. More info will be added. This is going after https://github.com/oxarbitrage/bitshares-explorer/issues/6
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: fav on November 15, 2017, 04:49:07 pm
awesome :)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: renkcub on November 25, 2017, 06:21:07 pm
Nice work. I would personally like to see a chart on your new Explorer that shows Dex BitUSD - equivalent volume on a scalable basis (and filterable for Smartcoins vs UIA, for example, or by single asset pairing)
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on December 01, 2017, 09:28:25 pm
Nice work. I would personally like to see a chart on your new Explorer that shows Dex BitUSD - equivalent volume on a scalable basis (and filterable for Smartcoins vs UIA, for example, or by single asset pairing)

Hey @renko, sorry i didn't saw your message before. Can you please open an issue for it at https://github.com/oxarbitrage/bitshares-explorer/issues
I will be happy to do it, please also include some more details about it like where in the explorer you will want that placed. assets page(http://bitshares-explorer.io/#/assets)? bitusd page(http://bitshares-explorer.io/#/assets/1.3.121)?  and what do you want to be charted more specifically as i don't fully understand it. thanks!
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on December 01, 2017, 10:33:44 pm
Dear bitshares stakeholders and general public that may be reading, here is a report of the documented work done in the last 15 days by this worker.

bitshares-core:

- https://github.com/bitshares/bitshares-core/pull/488 - @xeroc submitted a fix for his docker configurations that was merged into the develop branch.

- @xeroc new docker codes replaces https://github.com/bitshares/bitshares-core/pull/376 so it was closed.

- merged docker config by xeroc to fix curl dependency of develop branch(needed for elasticsearch plugin): https://github.com/bitshares/bitshares-core/pull/498

- closed docker related issue: https://github.com/bitshares/bitshares-core/issues/318

- https://github.com/bitshares/bitshares-core/issues/358 - @pc suggested that exposing the whole elasticsearch database to the internet may be risky. for this reason i am working on a small python wrapper so the UI and other apps can make queries to that instead of directly the database. This wrapper is work in progress just started and it is located by now here: https://github.com/oxarbitrage/bitshares-es-wrapper

- a small deprecated text was found by a contributor in the p2p code of bitshares. his change was merged to the develop branch: https://github.com/bitshares/bitshares-core/pull/489

- https://github.com/bitshares/bitshares-core/issues/484 - some assitance was provided to a new developer trying to work with bitshares in this issue and in telegram developer channel.

- https://github.com/bitshares/bitshares-core/pull/478 - After testing this by setting up nodes and others we finally merged the changes made by @abit that deal with extreme values in market history data that were making charts to look very bad. This pull allowed to close several issues, after reviews by @sivek, myself and other contributors from telegram we merged the code. Big improvement here.

- https://github.com/bitshares/bitshares-core/pull/494 - merged small typo pull request.

- https://github.com/bitshares/bitshares-core/issues/499 - tested, was not able to find memory leak issuer presents following his steps, memory remains the same, closing the issue.

- https://github.com/bitshares/bitshares-core/pull/500 - in addition to the former ES plugin that saves account history data to the database we created a new plugin that saves additional data, needed to fix several issues and make queries of some data easier. It is in progress and not merged yet, related discussion and more info can be found in the pull.

- https://github.com/bitshares/bitshares-core/pull/507 - 2 new functions were proposed in the pull to create and read memos in the cli_wallet. After testing and reviewing the code it was concluded that it works good so the pull was merged.

- https://github.com/bitshares/bitshares-core/issues/126 - closed as issue is too old and part of it is solved at present time.

- fixed https://github.com/bitshares/bitshares-core/issues/66 with https://github.com/bitshares/bitshares-core/pull/508

- https://github.com/bitshares/bitshares-core/issues/514 - trying to bring some light to this new bitshares enthusiast on how the system works.

bsips:

- some small technical additions were added to bsip28 proposed by @bill butler. https://github.com/bitshares/bsips/pull/41

explorer:

- https://github.com/oxarbitrage/bitshares-explorer/pull/13 -> added pull with link to bitshares explorer api backend.

- https://github.com/oxarbitrage/bitshares-explorer/issues/12 - this is very important so i have it as the highest priority for the explorer even if i know there are other issues in charting,  more data, presentation of data, etc people want to see; the release of the code will bring contributions from outside that will make the whole thing go faster.

This will be easy if it was not by the theme restrictions it haves and the initial error i made of building the explorer on top of it. I contacted the theme owner several days ago to see if it could be a possibility to open source it(for a price). No response yet.

In the last few days i had been in conversations with the UI team in order to develop an UDF wrapper needed to add trading view charts to the reference UI. The issue for it is at https://github.com/bitshares/bitshares-ui/issues/773 and had been assigned to me with 20 hours.
As i already have a position in bitshares i will not be getting this 20 hours in cash but instead i am going to exchange it by work in the explorer. A first option will be to get some help in the release of the project, i already discussed with Calvin and he can help here. Another option is to make that work myself and invest the 20 hours(or more, as i am not sure how much the UDF thing will take) for other explorer work. Open to suggestions here.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on December 23, 2017, 10:00:35 pm
work done in the last 15 days, a bit late sorry about that.

bitshares-core:

- https://github.com/bitshares/bitshares-core/issues/514 - helping new user explaining how bitshares and dpos works. closed.

- https://github.com/bitshares/bitshares-core/issues/521 - add version command to cli_wallet and witness_node. pull created and merged: https://github.com/bitshares/bitshares-core/issues/521
Then we saw it was better toi have this code moved to a new file, related issue for that is https://github.com/bitshares/bitshares-core/issues/535 and pull https://github.com/bitshares/bitshares-core/pull/536

- https://github.com/bitshares/bitshares-core/issues/509 - review pull from @abit to improve this. pull: https://github.com/bitshares/bitshares-core/pull/513  - merged.

- https://github.com/bitshares/bitshares-core/pull/500 - additional commits had been added to this plugin but then started with the release and as the plugin was not going to be included there it was on hold for the last 2 weeks. resuming the work on it this starting week.

- On December 12 we started working on a new release with the last changes since fork. Not going to add all the pulls and merges from branches we did to make the release, the important is that at this point we have the testnet / master / develop branch all with the same code. After testing we made a pre release version of the new master and finally after a few days we released fully the last bitshares version. Details of what was included can be found at: https://github.com/bitshares/bitshares-core/releases/tag/2.0.171212

- https://github.com/bitshares/bitshares-core/pull/430 - after testing and modifications we finally merged the get_account_history_by_operations for exchanges api call and wallet call submitted by @zhuliting.

- review and approved some commits from @pc that were lost inside an unmerged pull request: https://github.com/bitshares/bitshares-core/pull/546 and https://github.com/bitshares/bitshares-core/pull/547

- https://github.com/bitshares/bitshares-core/pull/548 - approved an update in ram needed to run a full node but requested the contributor to sumbit it to the develop branch.

udf wrapper:

https://github.com/bitshares/bitshares-ui/issues/773

The udf wrapper is needed to add TradingView chart support to the bitshares-ui.

Version 1 of the program with online demo is here:

https://github.com/oxarbitrage/udf-bitshares-wrapper

Some issues were already added by me to it at:

https://github.com/oxarbitrage/udf-bitshares-wrapper/issues

elasticsearch-wrapper:

https://github.com/oxarbitrage/bitshares-es-wrapper

finished version 1 of the project. samples of what can be obtained are in the README. As a demo the transactions list from the explorer are pulled by using the wrapper: http://open-explorer.io/#/txs

more integration will came next in the explorer with elasticsearch and also of elasticsearch and the bitshares-ui, both using the api exposed by this wrapper.

A note about wrappers:

I have 3 wrappers at this time and more will eventually came if is needed. All wrappers are python 2 and run by flask. Flask is ok for development and for demos but in production this wrappers need to run behind a real webserver. Instructions to do this in nginx will be provided in a document soon.

A note about elasticsearch full node:

I am helping @Fox  to setup a full elasticsearch node with wrapper. This will be the first active witness on having this setup. Plan is to provide stable api access to elasticsearch data for dapps.

Open sourcing the explorer:

in my last report i exposed that the open sourcing of the explorer was the most important thing to do. Check previous post explorer section.

So i made a clean unthemed version http://bitshares-explorer.io/#/dashboard

I made it totally from scratch by starting the project with https://github.com/angular/angular-seed but used some ideas from the orignal theme. To make fully sure bitshares will not be involved in a license issue i have the repo in private until some members of the community can review it and we can release it under MIT.

see more about this at: https://bitsharestalk.org/index.php/topic,25570.0.html

i have a few people added to the review but this days are very slow as so many people is on vacation or not in full mode. I want to release the code of the explorer asap so if someone want to help just let me know and ill add you to the private repos.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on December 23, 2017, 10:26:24 pm
forgot to mention 2 things ...

- my contract with the blockchain will end 8/1/2018. i plan to renew, will send more details in a new worker text but will be very similar to the current contract(same money, same escrow, same period of time, pretty much same tasks). if you have any ideas to add new tasks please let me know and i will consider them.

i already contacted some of the proxies to tell them this, i will try to contact them all and inform the community in general by different channels.

- happy holidays to all!
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: sahkan on December 24, 2017, 03:28:54 am
The elasticsearch looks pretty straight forward, I am open to getting this installed on my Los Angeles node to get this tested as well.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: pc on December 24, 2017, 02:04:38 pm
- my contract with the blockchain will end 8/1/2018. i plan to renew, will send more details in a new worker text but will be very similar to the current contract(same money, same escrow, same period of time, pretty much same tasks).

I fully support that. You have done a great job, Alfredo!

The elasticsearch looks pretty straight forward, I am open to getting this installed on my Los Angeles node to get this tested as well.

Please be careful. AFAIK exposing an ES node to the internet is dangerous.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on December 24, 2017, 03:33:19 pm
the setup is elasticsearch database listening on localhost and elasticsearch wrapper exposed to the internet: https://github.com/oxarbitrage/bitshares-es-wrapper
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on January 12, 2018, 10:18:44 pm
Hello stakeholders, this is the last report from this worker in this thread.

I have a new worker proposal voting now to start 22th of this month as i am taking a week of vacation starting today.

Take a look at the new worker proposal here and vote for it if you like:

https://github.com/oxarbitrage/worker-proposals/blob/master/bitshares2018_1.md

New worker proposal number is 1.14.75

If approved, the reports will be posted bi weekly on the new worker thread at:

https://bitsharestalk.org/index.php/topic,25713.0.html

I want to thank everybody for supporting me and i hope i can continue here for the starting year, very exiting year for sure.

The worker has liquidated all the payment left and in the process of burning back 127118 BTS to the chain. This operation is already made and it is just waiting for 1 approval vote from the worker escrow, this will be happening in the next few hours.

Now let me go over the last advances, this was a period where it was hard to reach other bitshares devs for the holiday season, for this reason most of the work was focused outside core.

bitshares-core:

- issue https://github.com/bitshares/bitshares-core/issues/549 fixed with merged pull request: https://github.com/bitshares/bitshares-core/pull/551

- https://github.com/bitshares/bitshares-core/issues/528 finished documentation for elasticsearch plugin and moved to wiki page of bitshares: https://github.com/bitshares/bitshares-core/wiki/ElasticSearch-Plugin

- Small readme notes changes: https://github.com/bitshares/bitshares-core/pull/562

- review and merged https://github.com/bitshares/bitshares-core/pull/557

- merged https://github.com/bitshares/bitshares-core/pull/568 from @xeroc - docker updates.

- created new api call get_top_markets - https://github.com/bitshares/bitshares-core/pull/560

there are some other pending reviews from @abit, @pc and @xeroc that i will be able to finish when i came back from vacation or they will review each other if they want to merge before that.

account history exporter:

an account history exporter was made:

http://open-explorer.io/bitshares-account-exporter/index.php

It makes use of the elasticsearch node plugin and wrapper. Open source code in php can be found at: https://github.com/oxarbitrage/bitshares-account-exporter

There are plans to make a reduced version of it only exporting fill orders to be used with https://cointracking.info/

udf wrapper:

The udf wrapper was finished https://github.com/oxarbitrage/udf-bitshares-wrapper and was added as a proof of concept to the 2 explorer versions:

http://open-explorer.io/#/markets/CNY/BTS
http://bitshares-explorer.io/#/markets/CNY/BTS

The issue for it in UI was closed: https://github.com/bitshares/bitshares-ui/issues/773

I received the payment, i wanted to exchange it for some explorer work with the UI guys but they are to busy to do so at the moment.

Still, there are going to be more opportunities to make this deal in the future with other features the UI may need.

- bitshares-api-backend:

In addition to fixes i always do to this repo when i find a bug from the explorer i am now getting some contributions from @knaperek. He is helping as a volunteer to learn some bitshares with several stuff like dockerizing the project and fixing some bugs.

His contributions can be found at:

https://github.com/oxarbitrage/bitshares-python-api-backend/pull/1
https://github.com/oxarbitrage/bitshares-python-api-backend/pull/2
https://github.com/oxarbitrage/bitshares-python-api-backend/pull/3
https://github.com/oxarbitrage/bitshares-python-api-backend/pull/4

All of them were merged.


Thank you guys all again.
Title: Re: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017
Post by: oxarbitrage on January 12, 2018, 10:57:22 pm
update in the burning:

worked just burned 127118 BTS: http://open-explorer.io/#/operations/1.11.115677591