BitShares Forum
Other => Graveyard => Keyhotee => Topic started by: toast on February 28, 2014, 02:35:05 pm
-
I've brought this up to both Dans but haven't heard meaningful responses...
Your Keyhotee master private key does not depend on all of the forms in the profile wizard! This a critical error and all founders would have to re-register, right? Please just tell me I'm misreading the code?
https://github.com/InvictusInnovations/keyhotee/blob/master/profile_wizard/ProfileWizard.cpp#L269
I don't see where create_profile is defined but its conf argument is defined on the stack and so we know all the fields that got set.
Looks like first name, middle name, last name, and brain key are the only things that count. SS, passport, DOB... none of those things contribute to security.
No, that was a bug that we didn't catch.
Dan
On Feb 27, 2014, at 3:33 PM, Nikolai Mushegian <nikolai.mushegian@gmail.com> wrote:
> I forgot to mention this: is it intended that the keyhotee master
> private key does NOT depend on many fields in the profile wizard? Try
> changing your DOB or SS...
-
We have three options with respect to this issue:
1) force everyone to reregister
2) enable these extra fields for new users only
3) remove these fields
I am inclined to give people the option to reregister, but not require it. Those that do not reregister will have to remember to ignore those fields if they want to regenerate their key from memory in the future.
Dan Notestein has been addressing this issue in Github.
-
2) enable these extra fields for new users only
...
I am inclined to give people the option to reregister, but not require it. Those that do not reregister will have to remember to ignore those fields if they want to regenerate their key from memory in the future.
I think Dan N disagrees with you about these options based on his changes on github.
Dan Notestein has been addressing this issue in Github.
https://github.com/InvictusInnovations/keyhotee/commit/bd9c5785a6527566cb4209f58af7872035cba8b2
"whooooops yeah those were never supposed to be part of the profile anyway yeah..."
So should I go find all the forum posts referring to those fields between now and lets see how long ago...
https://github.com/InvictusInnovations/keyhotee/commits/bd9c5785a6527566cb4209f58af7872035cba8b2/profile_wizard/ProfileEditPage.ui
https://github.com/InvictusInnovations/keyhotee/commits/master/profile_wizard/ProfileWizard.cpp
two months!!!
All information is optional and was chosen merely because it is easy to remember for most users
It is used as a salt that makes attackers pick an individual
Sent from my iPhone using Tapatalk (http://tapatalk.com/m?id=1)
Brain wallet doesn't depend on DOB? I just used two different dates and got the same public key...
Hi toast,
Yes, I tested it myself and you're correct. Passport/driver's license also didn't affect it. I've committed a new version of this dialog that removes these fields, since it's just extra work for no purpose to enter this info, plus it's confusing. So now it's just first, middle, last name, brainwallet key, and password that are accepted.
Well NOW it is...
why am I so angry about this, I shouldn't be angry
-
Everything good toast?
Sent from my iPhone using Tapatalk
-
Everything good toast?
Sent from my iPhone using Tapatalk
I took like 20 deep breaths so now it's all ok
Sent from my SCH-I535 using Tapatalk
-
Lol.. Dan N. and I often have different opinions. And sometimes I waiver on my opinion on what should be done when I lack a metric by which to judge. I this case I may have told Dan one thing, then talked to you Toast and changed my mind...
I welcome feedback on how this should be handled.