Big bug in GUI asset update?

[puppies]

permissions cannot be re-enabled once the have been disabled ..

That sucks.

[xeroc]

permissions cannot be re-enabled once the have been disabled ..

[puppies]

bitcrab have you tried

Code: [Select]

update_asset TCNY null {  "id": "1.3.734",  "symbol": "TCNY",  "precision": 4,  "issuer": "1.2.121",  "options": {    "max_supply": "1000000000000000",    "market_fee_percent": 0,    "max_market_fee": "1000000000000000",    "issuer_permissions": 511,    "flags": 128,    "core_exchange_rate": {      "base": {        "amount": 103,        "asset_id": "1.3.734"      },      "quote": {        "amount": 46825,        "asset_id": "1.3.0"      }    },    "whitelist_authorities": [],    "blacklist_authorities": [],    "whitelist_markets": [],    "blacklist_markets": [],    "description": "smartcoin defined by transwiser",    "extensions": []  } true
 
That should set your permissions and your flags back to where they were. 

[Musewhale]

, great, good idea, i like it, just do it!

[bitcrab]

Unless @theoreticalbts or @bytemaster can explain the "missing" permissions that relate to bit assets I can't do much about this.

I say "missing" because they're not part of the definitions here: https://github.com/cryptonomex/graphene/blob/62c22fbf18d748531c468e0d7a88d08eddbd6f20/libraries/chain/include/graphene/chain/protocol/types.hpp#L84

and I've tried searching through the code but I can't find anything explaining how bit asset permissions.

https://github.com/cryptonomex/graphene/blob/master/libraries/wallet/wallet.cpp#L2319-L2336
It seems all that is needed is another 'bitasset"-specific json object:
https://github.com/cryptonomex/graphene/blob/master/libraries/chain/include/graphene/chain/protocol/asset_ops.hpp#L87-L110

do you mean the only way is to create another privatized smartcoin to replace TCNY, if need to get the initial issuer permissions and flags?

I guess he mean the attributes which svk didn't find are in another object, the "bitasset" object, not the "asset" object.

got it.

[abit]

Unless @theoreticalbts or @bytemaster can explain the "missing" permissions that relate to bit assets I can't do much about this.

I say "missing" because they're not part of the definitions here: https://github.com/cryptonomex/graphene/blob/62c22fbf18d748531c468e0d7a88d08eddbd6f20/libraries/chain/include/graphene/chain/protocol/types.hpp#L84

and I've tried searching through the code but I can't find anything explaining how bit asset permissions.

https://github.com/cryptonomex/graphene/blob/master/libraries/wallet/wallet.cpp#L2319-L2336
It seems all that is needed is another 'bitasset"-specific json object:
https://github.com/cryptonomex/graphene/blob/master/libraries/chain/include/graphene/chain/protocol/asset_ops.hpp#L87-L110

do you mean the only way is to create another privatized smartcoin to replace TCNY, if need to get the initial issuer permissions and flags?

I guess he mean the attributes which svk didn't find are in another object, the "bitasset" object, not the "asset" object.

[bitcrab]

Unless @theoreticalbts or @bytemaster can explain the "missing" permissions that relate to bit assets I can't do much about this.

I say "missing" because they're not part of the definitions here: https://github.com/cryptonomex/graphene/blob/62c22fbf18d748531c468e0d7a88d08eddbd6f20/libraries/chain/include/graphene/chain/protocol/types.hpp#L84

and I've tried searching through the code but I can't find anything explaining how bit asset permissions.

https://github.com/cryptonomex/graphene/blob/master/libraries/wallet/wallet.cpp#L2319-L2336
It seems all that is needed is another 'bitasset"-specific json object:
https://github.com/cryptonomex/graphene/blob/master/libraries/chain/include/graphene/chain/protocol/asset_ops.hpp#L87-L110

do you mean the only way is to create another privatized smartcoin to replace TCNY, if need to get the initial issuer permissions and flags?

[xeroc]

Unless @theoreticalbts or @bytemaster can explain the "missing" permissions that relate to bit assets I can't do much about this.

I say "missing" because they're not part of the definitions here: https://github.com/cryptonomex/graphene/blob/62c22fbf18d748531c468e0d7a88d08eddbd6f20/libraries/chain/include/graphene/chain/protocol/types.hpp#L84

and I've tried searching through the code but I can't find anything explaining how bit asset permissions.

https://github.com/cryptonomex/graphene/blob/master/libraries/wallet/wallet.cpp#L2319-L2336
It seems all that is needed is another 'bitasset"-specific json object:
https://github.com/cryptonomex/graphene/blob/master/libraries/chain/include/graphene/chain/protocol/asset_ops.hpp#L87-L110

[Thom]

Unless @theoreticalbts or @bytemaster can explain the "missing" permissions that relate to bit assets I can't do much about this.

I say "missing" because they're not part of the definitions here: https://github.com/cryptonomex/graphene/blob/62c22fbf18d748531c468e0d7a88d08eddbd6f20/libraries/chain/include/graphene/chain/protocol/types.hpp#L84

and I've tried searching through the code but I can't find anything explaining how bit asset permissions.

This is what ad hoc engineering gets you (no design spec or explicit definitions of what the code needs to implement).

Welcome to BitShares!

[svk]

Unless @theoreticalbts or @bytemaster can explain the "missing" permissions that relate to bit assets I can't do much about this.

I say "missing" because they're not part of the definitions here: https://github.com/cryptonomex/graphene/blob/62c22fbf18d748531c468e0d7a88d08eddbd6f20/libraries/chain/include/graphene/chain/protocol/types.hpp#L84

and I've tried searching through the code but I can't find anything explaining how bit asset permissions.

[sudo]

bad bugs！！！！！！！！

[bitcrab]

this is an accident, I think there should be a solution to enable the issuer_permissions and flags for TCNY.
 @bytemaster @xeroc @svk @valzav

[merivercap]

I have tested and found that now the force settlement feature is actually enabled for TCNY.

according to the design, force settlement/allow witness to provide feed features should both be disabled because of the change but actually not, this is another bug and when in the future the bug be fixed these features will be actually disabled for TCNY, right?

so I wonder whether there are ways to reserve these features for TCNY, as they are important for a smartcoin.

Yeah I agree.   The features should be consistent with regular smartcoins.  (Although I'd probably want to disable forced settlement or make it 90%.)

So do these bugs just occur in the GUI and will CLI changes work fine?

It depends on how you use CLI, E.G. what command, what parameters, afaik some commands are fine but others are not.

Thx it would be good to know 1) which parameters we can change now 2) which ones we have to wait on a hard fork for 3) what day fixes are planned to be made 4) if this requires a worker proposal. 

[abit]

I have tested and found that now the force settlement feature is actually enabled for TCNY.

according to the design, force settlement/allow witness to provide feed features should both be disabled because of the change but actually not, this is another bug and when in the future the bug be fixed these features will be actually disabled for TCNY, right?

Lack of detailed document of "feature description" or "feature requirement" yet. "We" need to make one, otherwise the code is correct in any case.

so I wonder whether there are ways to reserve these features for TCNY, as they are important for a smartcoin.

To "reserve these features" it may need a hard fork.

[abit]

I have tested and found that now the force settlement feature is actually enabled for TCNY.

according to the design, force settlement/allow witness to provide feed features should both be disabled because of the change but actually not, this is another bug and when in the future the bug be fixed these features will be actually disabled for TCNY, right?

so I wonder whether there are ways to reserve these features for TCNY, as they are important for a smartcoin.

Yeah I agree.   The features should be consistent with regular smartcoins.  (Although I'd probably want to disable forced settlement or make it 90%.)

So do these bugs just occur in the GUI and will CLI changes work fine?

It depends on how you use CLI, E.G. what command, what parameters, afaik some commands are fine but others are not.