Author Topic: Best way to tell if transaction is a deposit via RPC?  (Read 1478 times)

0 Members and 1 Guest are viewing this topic.

Offline jsidhu

  • Hero Member
  • *****
  • Posts: 1335
    • View Profile
Re: Best way to tell if transaction is a deposit via RPC?
« Reply #15 on: December 12, 2014, 11:57:17 pm »
Thanks... this should run against the server wallet so from account shouldnt matter... the hash makes sure i got the right tx.

But 'from_account' is the customer who's paying you, right? I'm just wondering if it's possible to have two different 'from_account's inside the ledger array?
There will be many diff from accounts.. U mean two different ppl paying for same thing? Well there is a hash too for that reason but if they know the hash then yes you can have someone else pay for you if you really want. The customer is not reequired to validate which account they are paying from when paying an order.

No, I mean within 1 transaction there is a ledger_entries array. Inside that array each entry has a 'from_account' field. That suggests to me that inside 1 transaction it might be possible to have several different people sending you assets. I just want clarity on whether this is possible or not.

Yea I see.. if this is true we will have to loop through each tx to ensure we got all of the received coins we are looking for. I havent' seen this in my tests.. even sending multiple tx's within 10s so I can tentatively say that its 1 and not N inputs.
Hired by blockchain | Developer
delegate: dev.sidhujag

Offline monsterer

Re: Best way to tell if transaction is a deposit via RPC?
« Reply #16 on: December 14, 2014, 07:08:42 pm »
Yea I see.. if this is true we will have to loop through each tx to ensure we got all of the received coins we are looking for. I havent' seen this in my tests.. even sending multiple tx's within 10s so I can tentatively say that its 1 and not N inputs.

I don't know about you, but I wouldn't be comfortable with releasing software dealing with money without knowing answers like this *for certain* :)
My opinions do not represent those of metaexchange unless explicitly stated.
https://metaexchange.info | Bitcoin<->Altcoin exchange | Instant | Safe | Low spreads

Offline jsidhu

  • Hero Member
  • *****
  • Posts: 1335
    • View Profile
Re: Best way to tell if transaction is a deposit via RPC?
« Reply #17 on: December 14, 2014, 08:18:44 pm »
Yea I see.. if this is true we will have to loop through each tx to ensure we got all of the received coins we are looking for. I havent' seen this in my tests.. even sending multiple tx's within 10s so I can tentatively say that its 1 and not N inputs.

I don't know about you, but I wouldn't be comfortable with releasing software dealing with money without knowing answers like this *for certain* :)

Since there is no spec this is why we have to do codereviews with someone who can tell us right away aka bm.. i can look at the code too but cant be bothered to because  im not at the release and testing phase yet. You should come up with a verification test that will cover these cases to ensure its good.. thats my plan anyway.
Hired by blockchain | Developer
delegate: dev.sidhujag

Offline vikram

Re: Best way to tell if transaction is a deposit via RPC?
« Reply #18 on: December 14, 2014, 08:36:58 pm »
Thanks... this should run against the server wallet so from account shouldnt matter... the hash makes sure i got the right tx.

But 'from_account' is the customer who's paying you, right? I'm just wondering if it's possible to have two different 'from_account's inside the ledger array?
There will be many diff from accounts.. U mean two different ppl paying for same thing? Well there is a hash too for that reason but if they know the hash then yes you can have someone else pay for you if you really want. The customer is not reequired to validate which account they are paying from when paying an order.

No, I mean within 1 transaction there is a ledger_entries array. Inside that array each entry has a 'from_account' field. That suggests to me that inside 1 transaction it might be possible to have several different people sending you assets. I just want clarity on whether this is possible or not.

This is very possible, but does not happen in practice yet since there are no good tools to do so. A transaction can pretty much have any arbitrary set of operations--this is why the transaction scanning (and thus history) is currently being rewritten (see https://github.com/BitShares/bitshares/issues/845) to treat transfers effectively as inputs and outputs--like in bitcoin.

Offline monsterer

Re: Best way to tell if transaction is a deposit via RPC?
« Reply #19 on: December 14, 2014, 10:37:02 pm »
This is very possible, but does not happen in practice yet since there are no good tools to do so. A transaction can pretty much have any arbitrary set of operations--this is why the transaction scanning (and thus history) is currently being rewritten (see https://github.com/BitShares/bitshares/issues/845) to treat transfers effectively as inputs and outputs--like in bitcoin.

Thanks vikram, that's good to know. For safety, do you suggest we parse every ledger entry inside each transaction as it's own 'micro' transaction with potential unique sender and receiver?
My opinions do not represent those of metaexchange unless explicitly stated.
https://metaexchange.info | Bitcoin<->Altcoin exchange | Instant | Safe | Low spreads

Offline vikram

Re: Best way to tell if transaction is a deposit via RPC?
« Reply #20 on: December 15, 2014, 12:59:51 am »
This is very possible, but does not happen in practice yet since there are no good tools to do so. A transaction can pretty much have any arbitrary set of operations--this is why the transaction scanning (and thus history) is currently being rewritten (see https://github.com/BitShares/bitshares/issues/845) to treat transfers effectively as inputs and outputs--like in bitcoin.

Thanks vikram, that's good to know. For safety, do you suggest we parse every ledger entry inside each transaction as it's own 'micro' transaction with potential unique sender and receiver?

Yes. Please be careful regardless, however. The current scanning and ledger construction code is honestly pretty bad (hence the rewrite), and the ledger entries may be inaccurate for certain types of transactions.

Offline monsterer

Re: Best way to tell if transaction is a deposit via RPC?
« Reply #21 on: December 15, 2014, 09:40:37 am »
Yes. Please be careful regardless, however. The current scanning and ledger construction code is honestly pretty bad (hence the rewrite), and the ledger entries may be inaccurate for certain types of transactions.

Can we have detail on exactly where the problems lie?
My opinions do not represent those of metaexchange unless explicitly stated.
https://metaexchange.info | Bitcoin<->Altcoin exchange | Instant | Safe | Low spreads

Offline vikram

Re: Best way to tell if transaction is a deposit via RPC?
« Reply #22 on: December 15, 2014, 07:21:45 pm »
Yes. Please be careful regardless, however. The current scanning and ledger construction code is honestly pretty bad (hence the rewrite), and the ledger entries may be inaccurate for certain types of transactions.

Can we have detail on exactly where the problems lie?

Can't really say; the current code is too complex to analyze. I would just manually test the particular types of transactions you are interested in; e.g.: TITAN transfers, BitAsset transfers with yield, etc.