Author Topic: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!  (Read 2473 times)

0 Members and 1 Guest are viewing this topic.

Offline Xeldal

  • Hero Member
  • *****
  • Posts: 1019
    • View Profile
  • BitShares: xeldal
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #15 on: January 22, 2015, 08:20:28 pm »
for many commands the console just sits there for a very long time.  I can't tell whether its doing something or not.

Just did an import keys from json and
Navigating back to my accounts, the robot picture displays but no other information in the header about the account does.  For all accounts.

then after some time, 2 minutes or more it all shows back up.  background process from the console must have been chugging away.  It would be nice if there were some indication of this.

Offline bytemaster

Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #16 on: January 22, 2015, 08:35:39 pm »
for many commands the console just sits there for a very long time.  I can't tell whether its doing something or not.

Just did an import keys from json and
Navigating back to my accounts, the robot picture displays but no other information in the header about the account does.  For all accounts.

then after some time, 2 minutes or more it all shows back up.  background process from the console must have been chugging away.  It would be nice if there were some indication of this.

Import keys for large wallets is very slow with no progress indicator.   That is a known issue.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline davidpbrown

Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #17 on: January 23, 2015, 08:45:27 am »
The GUI could do with having an option to switch languages. Even if the translation is not there, then a call to help translate key elements of text could be.
See https://bitsharestalk.org/index.php?topic=13587.0
฿://1CBxm54Ah5hiYxiUtD7JGYRXykT5Z6ZuMc

Offline arhag

  • Hero Member
  • *****
  • Posts: 1214
    • View Profile
    • My posts on Steem
  • BitShares: arhag
  • GitHub: arhag
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #18 on: January 23, 2015, 10:27:14 pm »
I haven't had the opportunity to build and try it out yet, but...

https://github.com/BitShares/bitshares/blob/develop/docs/multisig.md

Is there a RPC that allows you to see what a given transaction builder does? You shouldn't just sign any transaction someone gives you without first checking out how much of what asset it is pulling out of which multisigID and sending to which address. Is the only way to figure this stuff out right now to go through the raw transaction builder?

Also, a minor correction: I think you meant to write "angel" instead of "alice" in the "wallet_multisig_deposit" command.

https://github.com/BitShares/bitshares/blob/develop/docs/voter-key.md

Another potential minor correction: Shouldn't you be using "wallet_builder_file_add_signature" rather than "wallet_builder_add_signature" since the last argument is the path to the transaction builder and not the escaped transaction builder itself?


Also, in general I think the documentation would benefit from actual examples copied and pasted from the client with the real names, addresses, keys, etc. rather than your BTS...something... notation. It is especially odd because it appears you are putting the returned results of some of these commands on the same line as the command that was input by the user. Never mind that was just because you forgot to wrap them in code blocks which James Calfee fixed.
« Last Edit: January 24, 2015, 10:49:08 pm by arhag »

Offline arhag

  • Hero Member
  • *****
  • Posts: 1214
    • View Profile
    • My posts on Steem
  • BitShares: arhag
  • GitHub: arhag
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #19 on: January 25, 2015, 04:44:27 am »
I tried to follow the voter-key guide and ran into some problems.

I set up the hot client and cold storage addresses according to the guide. My voter address is DVSCp2UnK2SYacZbrhuA1XCSnej9cGsLgqDW. My cold storage address is DVS2AgMjmUsKhUvgv9eRNkfKrqgtdadYrku8. I moved 100 DVS to that address creating a balance with an ID of DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj.

Code: [Select]
(wallet closed) >>> blockchain_list_balances DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj 1
[[
    "DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj",{
      "condition": {
        "asset_id": 0,
        "slate_id": 14656263436760093262,
        "type": "withdraw_signature_type",
        "data": {
          "owner": "DVS2AgMjmUsKhUvgv9eRNkfKrqgtdadYrku8",
          "memo": null
        }
      },
      "balance": 10000000,
      "restricted_owner": null,
      "snapshot_info": null,
      "deposit_date": "2015-01-24T23:59:30",
      "last_update": "2015-01-24T23:59:30",
      "meta_data": null
    }
  ]
]

Then from my cold-storage wallet I do the following:
Code: [Select]
cold-storage (unlocked) >>> wallet_balance_set_vote_info DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj DVSCp2UnK2SYacZbrhuA1XCSnej9cGsLgqDW vote_all false
{
  "transaction_record": {
    "index": 0,
    "record_id": "0000000000000000000000000000000000000000",
    "block_num": 0,
    "is_virtual": false,
    "is_confirmed": false,
    "is_market": false,
    "trx": {
      "expiration": "2015-01-25T05:19:39",
      "slate_id": null,
      "operations": [{
          "type": "update_balance_vote_op_type",
          "data": {
            "balance_id": "DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj",
            "new_restricted_owner": "DVSCp2UnK2SYacZbrhuA1XCSnej9cGsLgqDW",
            "new_slate": 0
          }
        }
      ],
      "signatures": []
    },
    "ledger_entries": [{
        "from_account": null,
        "to_account": null,
        "amount": {
          "amount": 0,
          "asset_id": 0
        },
        "memo": "Set balance vote info",
        "memo_from_account": null
      }
    ],
    "fee": {
      "amount": 100000,
      "asset_id": 0
    },
    "created_time": "1970-01-01T00:00:00",
    "received_time": "1970-01-01T00:00:00",
    "extra_addresses": []
  },
  "required_signatures": [
    "DVS2AgMjmUsKhUvgv9eRNkfKrqgtdadYrku8"
  ],
  "outstanding_balances": [],
  "notices": []
}
The JSON output is also stored in the file "/home/arhag/.DevShares/wallets/trx/latest.trx". I copy that to builder.trx in the same directory.

I tried to use the command in the guide, but I had to set the broadcast flag to false because it is supposed to be a cold-storage environment meaning that I shouldn't have an internet connection to broadcast the transaction (I only want to sign it). However, as you will see it gave me an error:
Code: [Select]
cold-storage (unlocked) >>> wallet_builder_add_signature null false "/home/arhag/.DevShares/wallets/trx/builder.trx"
7 bad_cast_exception: Bad Cast
Invalid cast from type 'null_type' to Object
    {"type":"null_type"}
    th_a  variant.cpp:568 get_object

    {"command":"wallet_builder_add_signature"}
    th_a  cli.cpp:626 execute_command

So, I gave up on following the guide and tried to figure it out for myself. I used the "wallet_builder_file_add_signature" command instead:
Code: [Select]
cold-storage (unlocked) >>> wallet_builder_file_add_signature false
{
  "transaction_record": {
    "index": 0,
    "record_id": "588316c670f32541363755f28d515f484668bc4a",
    "block_num": 0,
    "is_virtual": false,
    "is_confirmed": false,
    "is_market": false,
    "trx": {
      "expiration": "2015-01-25T05:19:39",
      "slate_id": null,
      "operations": [{
          "type": "update_balance_vote_op_type",
          "data": {
            "balance_id": "DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj",
            "new_restricted_owner": "DVSCp2UnK2SYacZbrhuA1XCSnej9cGsLgqDW",
            "new_slate": 0
          }
        }
      ],
      "signatures": [
        "207d264bb6f0a41d6455cd6b9f2d6c1942f87fe461997e46d9b2f0941d6a95e8726d4182dbf05b828e09d93457667622d162abd9448b0cf75b57ad59d94ba34bb0"
      ]
    },
    "ledger_entries": [{
        "from_account": null,
        "to_account": null,
        "amount": {
          "amount": 0,
          "asset_id": 0
        },
        "memo": "Set balance vote info",
        "memo_from_account": null
      }
    ],
    "fee": {
      "amount": 100000,
      "asset_id": 0
    },
    "created_time": "2015-01-25T04:26:01",
    "received_time": "2015-01-25T04:26:01",
    "extra_addresses": []
  },
  "required_signatures": [
    "DVS2AgMjmUsKhUvgv9eRNkfKrqgtdadYrku8"
  ],
  "outstanding_balances": [],
  "notices": []
}

This appears to have taken the transaction in latest.trx, added the signature, and wrote the result back in latest.trx. Here is the diff between builder.trx (the unsigned version of the transaction) and latest.trx (the signed version):
Code: [Select]
$ diff builder.trx latest.trx
4c4
<     "record_id": "0000000000000000000000000000000000000000",
---
>     "record_id": "588316c670f32541363755f28d515f484668bc4a",
21c21,23
<       "signatures": []
---
>       "signatures": [
>         "207d264bb6f0a41d6455cd6b9f2d6c1942f87fe461997e46d9b2f0941d6a95e8726d4182dbf05b828e09d93457667622d162abd9448b0cf75b57ad59d94ba34bb0"
>       ]
38,39c40,41
<     "created_time": "1970-01-01T00:00:00",
<     "received_time": "1970-01-01T00:00:00",
---
>     "created_time": "2015-01-25T04:26:01",
>     "received_time": "2015-01-25T04:26:01",

I then can copy this latest.trx to the machine where my hot client is running (in reality I'm just doing this on the same machine for convenience). Then after opening the regular hot wallet and unlocking it, I run the following command to broadcast this signed transaction from the internet-enabled machine where the hot client is running:
Code: [Select]
default (unlocked) >>> wallet_builder_file_add_signature true
Transaction was invalid!
default (unlocked) >>> wallet_builder_file_add_signature true{
  "transaction_record": {
    "index": 0,
    "record_id": "588316c670f32541363755f28d515f484668bc4a",
    "block_num": 0,
    "is_virtual": false,
    "is_confirmed": false,
    "is_market": false,
    "trx": {
      "expiration": "2015-01-25T05:19:39",
      "slate_id": null,
      "operations": [{
          "type": "update_balance_vote_op_type",
          "data": {
            "balance_id": "DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj",
            "new_restricted_owner": "DVSCp2UnK2SYacZbrhuA1XCSnej9cGsLgqDW",
            "new_slate": 0
          }
        }
      ],
      "signatures": [
        "207d264bb6f0a41d6455cd6b9f2d6c1942f87fe461997e46d9b2f0941d6a95e8726d4182dbf05b828e09d93457667622d162abd9448b0cf75b57ad59d94ba34bb0"
      ]
    },
    "ledger_entries": [{
        "from_account": null,
        "to_account": null,
        "amount": {
          "amount": 0,
          "asset_id": 0
        },
        "memo": "Set balance vote info",
        "memo_from_account": null
      }
    ],
    "fee": {
      "amount": 100000,
      "asset_id": 0
    },
    "created_time": "2015-01-25T04:26:01",
    "received_time": "2015-01-25T04:26:01",
    "extra_addresses": []
  },
  "required_signatures": [
    "DVS2AgMjmUsKhUvgv9eRNkfKrqgtdadYrku8"
  ],
  "outstanding_balances": [],
  "notices": []
}

But as you can see it returns "Transaction was invalid!" as an error message. And sure enough I can see that the restricted_owner field for the balance has not been updated and is still null:
Code: [Select]
default (unlocked) >>> blockchain_list_balances DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj 1
[[
    "DVS4sfmSA1jXb7swUkDRm323vhoqXxT69BGj",{
      "condition": {
        "asset_id": 0,
        "slate_id": 14656263436760093262,
        "type": "withdraw_signature_type",
        "data": {
          "owner": "DVS2AgMjmUsKhUvgv9eRNkfKrqgtdadYrku8",
          "memo": null
        }
      },
      "balance": 10000000,
      "restricted_owner": null,
      "snapshot_info": null,
      "deposit_date": "2015-01-24T23:59:30",
      "last_update": "2015-01-24T23:59:30",
      "meta_data": null
    }
  ]
]

I thought about trying the "blockchain_broadcast_transaction" command instead to see if that could work, but that requires me to input the escaped JSON into the CLI and doesn't allow me instead provide a path to a file holding the transaction JSON. Anyway, I don't even know if that would help if the transaction itself is not formed properly.
« Last Edit: January 25, 2015, 05:11:41 am by arhag »

Offline fundomatic

  • Full Member
  • ***
  • Posts: 149
    • View Profile
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #20 on: January 25, 2015, 10:25:15 am »
"client_version": "0.6.1" in Debian GNU/Linux jessie/sid

Cannot import keys (checked with "wallet_account_list_public_keys" command and there was no new keys)

>>> wallet_import_keys_from_json

gives output:

Code: [Select]
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
not skipping   
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
not skipping   
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
not skipping   
error, setting skip_me=true
not skipping   
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
not skipping   
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
error, setting skip_me=true
not skipping   
not skipping   
error, setting skip_me=true
not skipping   
error, setting skip_me=true
error, setting skip_me=true
not skipping   
not skipping   
No errors were encountered, but there is currently no way to check if keys were decrypted using the correct password.


I went to client version 0.5.0. Imported keys with "wallet_import_keys_from_json" command, no problem.

Went back to 0.6.1. The client went unresponsive, eventually gave an error saying to restart with --rebuild-index or --resync-blockchain.

Restarted with no problems.

Offline cgafeng

Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #21 on: January 25, 2015, 03:18:40 pm »
can't create uia from ui?
click the create button and nothing happen.
BTC:1EYwcZ9cYVj6C9LMLafdcjK9wicVMDV376

Offline cn-members

  • Sr. Member
  • ****
  • Posts: 365
    • View Profile
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #22 on: January 25, 2015, 03:19:38 pm »
We have collected the follwing suggestions from chinese community for DVS 0.6.1:

1. the chinese localization is incompleted:


2. the block explorer is for bts, not dvs

3. the issuer of user-issued assets are incorrect:


4. some layout in chinese is bad:


5. While doing transactions, there should be a place to select your favorite accounts:


6. The auto-completion of account names should be disabled by default to avoid transaction to wring accounts:


7. After transaction to a new account, the wallet should ask 'whether to add this account to my favorite?'

8. To avoid transaction of error unit, the default transaction unit should be changable in 'advanced' tab, and should be 'blank', not DVS/BTS by default.


9.The 'advanced' should be on the right side of account names, not hidden in menu, for easier access.
BTS中文区发言人公共账号,帮助社区有效沟通与交流。
Chinese Community Spokesman Account,to help the effective communication between Chinese and other members of the community.We're not translators to do regular translations , but will help with vital ones as we see fit and available at that time.

Offline wuyanren

  • Hero Member
  • *****
  • Posts: 589
    • View Profile
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #23 on: January 25, 2015, 03:21:11 pm »
 +5% +5%

Offline valzav

  • Sr. Member
  • ****
  • Posts: 294
    • View Profile
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #24 on: January 25, 2015, 10:13:13 pm »
cn-members, thanks for your suggestions, most of them are in our plans and most of the bugs are known and some of them are already fixed.
the only thing I would disagree is #9 - Advanced is not going to be frequently accessed so it would be waste of space to have it as top level menu entry.

Offline toast

  • Hero Member
  • *****
  • Posts: 4002
    • View Profile
  • BitShares: nikolai
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #25 on: January 26, 2015, 09:46:02 pm »
@arhag   I think you might have not copied the builder to the data directory when you did "builder_file_add_signature"? The file argument is misleading because it only writes there, but it reads from the latest.trx

I will change the builder interface to be much more clear for this
Do not use this post as information for making any important decisions. The only agreements I ever make are informal and non-binding. Take the same precautions as when dealing with a compromised account, scammer, sockpuppet, etc.

Offline bytemaster

Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #26 on: January 26, 2015, 10:12:38 pm »
cn-members, thanks for your suggestions, most of them are in our plans and most of the bugs are known and some of them are already fixed.
the only thing I would disagree is #9 - Advanced is not going to be frequently accessed so it would be waste of space to have it as top level menu entry.

Perhaps put the advanced gear next to the network connection status?
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline bytemaster

Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #27 on: January 26, 2015, 10:13:30 pm »
I think the currency should "Default" to something other than blank when ever there is only one currency in the account.   
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 3202
    • View Profile
    • Steemit Blog
  • BitShares: abit
  • GitHub: abitmore
Re: Please help test new features in DVS 0.6.0 + Surprise GUI overhaul!
« Reply #28 on: January 28, 2015, 02:07:41 am »
The GUI could do with having an option to switch languages. Even if the translation is not there, then a call to help translate key elements of text could be.
See https://bitsharestalk.org/index.php?topic=13587.0
There is already an option to switch languages in the 'Preferences' menu (left pane).
BTS account: abit
BTS committee member: abit
BTS witness: in.abit