Author Topic: DVS Light Wallet for Mac Open Beta  (Read 6285 times)

0 Members and 1 Guest are viewing this topic.

Offline arhag

  • Hero Member
  • *****
  • Posts: 1214
    • View Profile
    • My posts on Steem
  • BitShares: arhag
  • GitHub: arhag
Re: DVS Light Wallet for Mac Open Beta
« Reply #45 on: February 03, 2015, 01:26:28 am »
Now, I see that there was a commit just one hour ago that may solve this bug. When I posted "Great, I'm building now." I had already started the build, and now I realize I was building an older commit than the one you referenced (c6b6e4624d19a65cba0464aa06490f88f1a34b78). I guess it's time to build again...

Okay all clients running on new build (c6b6e4624d19a65cba0464aa06490f88f1a34b78). The transaction history in the full client is back. It now correctly interprets the back and forth transfers I made today (arhag -> arhag-light -15 DVS, arhag-light -> arhag +13 DVS), but it still inaccurately reports the transfer I did last time from the light wallet to the full client as (arhag -> arhag-light -8 DVS) which also then screws up the balances reported with "wallet_account_transaction_history". This remains true after full blockchain rescan (which btw brought back my lost vote_all transaction). And even more strange is that the balance of the most recent transaction in the GUI transaction history starts off consistent with that from "wallet_account_transaction_history" after refresh but then is for some reason replaced after a little bit of time by the amount that was sent in that transaction (e.g. 13 DVS).

The light wallet did not show the +15 DVS and -13 DVS transactions I made today. I tried repeating again with 20 DVS from arhag to arhag-light and 18 DVS from arhag-light to arhag. From the perspective of the full client everything went smoothly and those transactions accurately appeared in the transaction history. The light wallet was able to recognize the 20 DVS transfer to it with the included memo and sender info. I then initiated the 18 DVS transfer back to arhag. Once I hit confirm the light wallet segfaulted, but apparently the transaction went through anyway (as confirmed by my full client and dvs.bitsharesblocks.com). When I reload the light wallet the balance is 0 DVS as it should be, but when I look at the transaction history, not only are the two transactions I said were missing last time (+15 DVS and -13 DVS) still missing but the transaction where I received +20 DVS (which was in the transaction history in the light wallet before the segfault) is gone too (and of course the -18 DVS transaction isn't there as well).

Since all of this information is recorded in the blockchain and associated to the active key of the light wallet accounts, why can't the light wallet client simply query the light wallet server to give it all the raw transactions from the blockchain that are associated with its public active key? Then the light wallet could reconstruct the transaction history even if didn't store it locally.
« Last Edit: February 03, 2015, 01:30:28 am by arhag »

Offline modprobe

Re: DVS Light Wallet for Mac Open Beta
« Reply #46 on: February 03, 2015, 03:53:49 pm »
Quote
Since all of this information is recorded in the blockchain and associated to the active key of the light wallet accounts, why can't the light wallet client simply query the light wallet server to give it all the raw transactions from the blockchain that are associated with its public active key? Then the light wallet could reconstruct the transaction history even if didn't store it locally.
That's exactly what it does, although it caches things based on time, so I'm guessing your cache got damaged in the crash. Right now I'm just using FC to do persistence, but I think I need something a little more capable. I'll look into this. To clarify, the light wallet always reports your balance correctly, but not always your history? It's designed to be a bit more careful about reporting the balance correctly, so I'm glad that's working as intended.

I am curious about that crash, though. I haven't seen any crashes except crashes on exit. I don't suppose you collected the command line output around said crash, or maybe even a backtrace, did you? :]

Offline arhag

  • Hero Member
  • *****
  • Posts: 1214
    • View Profile
    • My posts on Steem
  • BitShares: arhag
  • GitHub: arhag
Re: DVS Light Wallet for Mac Open Beta
« Reply #47 on: February 03, 2015, 11:41:47 pm »
To clarify, the light wallet always reports your balance correctly, but not always your history?

Correct.

I don't suppose you collected the command line output around said crash, or maybe even a backtrace, did you? :]

Unfortunately not. : (

Offline clayop

  • Hero Member
  • *****
  • Posts: 2033
    • View Profile
    • Bitshares Korea
  • BitShares: clayop
Re: DVS Light Wallet for Mac Open Beta
« Reply #48 on: February 05, 2015, 07:10:50 pm »
No news about windows client?
Bitshares Korea - http://www.bitshares.kr
Vote for me and see Korean Bitshares community grows
delegate-clayop

Offline modprobe

Re: DVS Light Wallet for Mac Open Beta
« Reply #49 on: February 05, 2015, 08:32:24 pm »
I'm afraid not, clayop. I spent about 5 hours on monday trying to get our windows dev box to build something, but neither I nor the resident windows user could get it working. Maybe cgafeng can give you a binary? At some point, we'll have to get the light wallet integrated into our normal windows build process, but we haven't done that yet.

Offline clayop

  • Hero Member
  • *****
  • Posts: 2033
    • View Profile
    • Bitshares Korea
  • BitShares: clayop
Re: DVS Light Wallet for Mac Open Beta
« Reply #50 on: February 05, 2015, 08:41:00 pm »
I'm afraid not, clayop. I spent about 5 hours on monday trying to get our windows dev box to build something, but neither I nor the resident windows user could get it working. Maybe cgafeng can give you a binary? At some point, we'll have to get the light wallet integrated into our normal windows build process, but we haven't done that yet.

Thanks. Keep working on LW and forget about windows binary! :)
Bitshares Korea - http://www.bitshares.kr
Vote for me and see Korean Bitshares community grows
delegate-clayop

Offline modprobe

Re: DVS Light Wallet for Mac Open Beta
« Reply #51 on: February 05, 2015, 09:43:27 pm »
That's the plan! :)

We're planning to release a beta of the LW on BitShares. Are there any critical issues in the light wallet that have been found which need to be fixed prior to releasing on the live BitShares network?

Offline clayop

  • Hero Member
  • *****
  • Posts: 2033
    • View Profile
    • Bitshares Korea
  • BitShares: clayop
Re: DVS Light Wallet for Mac Open Beta
« Reply #52 on: February 05, 2015, 10:20:58 pm »
That's the plan! :)

We're planning to release a beta of the LW on BitShares. Are there any critical issues in the light wallet that have been found which need to be fixed prior to releasing on the live BitShares network?

Unfortunately, there were only 35 downloads of DVS LW. I don't think we passed enough test. This can be reverting my argument, but we need windows binary to have enough test bed.
Bitshares Korea - http://www.bitshares.kr
Vote for me and see Korean Bitshares community grows
delegate-clayop

Offline modprobe

Re: DVS Light Wallet for Mac Open Beta
« Reply #53 on: February 05, 2015, 10:43:29 pm »
And only 21 of those 35 registered accounts, and several of those never sent a transaction from the light wallet. So is anyone having trouble?

But I also note that the LW is currently very simple, so there's not much *to* test. The fact that 21 people registered accounts and many of them sent transactions to and from their wallets without reporting serious problems tells me that it's working pretty well so far, which was really the point of this release: get a minimal, useful product out there which is simple enough to be quick and easy to fully test.

Offline clayop

  • Hero Member
  • *****
  • Posts: 2033
    • View Profile
    • Bitshares Korea
  • BitShares: clayop
Re: DVS Light Wallet for Mac Open Beta
« Reply #54 on: February 05, 2015, 10:49:55 pm »
This makes sense. Then GO!  8)
Bitshares Korea - http://www.bitshares.kr
Vote for me and see Korean Bitshares community grows
delegate-clayop

Offline arhag

  • Hero Member
  • *****
  • Posts: 1214
    • View Profile
    • My posts on Steem
  • BitShares: arhag
  • GitHub: arhag
Re: DVS Light Wallet for Mac Open Beta
« Reply #55 on: February 06, 2015, 12:09:14 am »
@modprobe, is there a way for me recover my account from the brain-key? I want to see if get my full transaction history to reappear if I get rid of "~/.local/share/DevShares/BitShares DVS Light Wallet/wallet_data.json" but when I do it forces me register a new account. I see no option of recovering an existing account. Is that not yet built into the light wallet?

Offline modprobe

Re: DVS Light Wallet for Mac Open Beta
« Reply #56 on: February 06, 2015, 12:40:58 am »
Hi, arhag. That was not implemented at the time of this beta release, but it is now implemented, albeit a bit buggy in the UX. If you rebuild from the devshares branch, you should get it.

Offline modprobe

Re: DVS Light Wallet for Mac Open Beta
« Reply #57 on: February 06, 2015, 01:03:58 am »
As a matter of fact, I've redone the persistence framework, so you'll either have to regenerate from your brain key, or manually copy the data to the new storage, after upgrading to the version. I have yet to write the data portability code, sorry about that.

So note to all: make sure you've got a copy of your brain key before upgrading, if you want to build your own. I'll make an update utility if people need it, but for now it should be a simple matter of reloading the account from backup.

Offline modprobe

Re: DVS Light Wallet for Mac Open Beta
« Reply #58 on: February 06, 2015, 10:36:59 pm »
I've just added a new OSX binary to the OP. Feel free to grab and test it. It will require you to reload your account from backup, so be prepared to test that for me too! ;)

Offline clayop

  • Hero Member
  • *****
  • Posts: 2033
    • View Profile
    • Bitshares Korea
  • BitShares: clayop
Re: DVS Light Wallet for Mac Open Beta
« Reply #59 on: February 07, 2015, 05:45:30 am »
Cool. I will let Korean community know and ask testing with DVS giveaway.
Bitshares Korea - http://www.bitshares.kr
Vote for me and see Korean Bitshares community grows
delegate-clayop