Author Topic: open sourcing the explorer.  (Read 1681 times)

0 Members and 1 Guest are viewing this topic.

Offline oxarbitrage

open sourcing the explorer.
« on: December 18, 2017, 10:17:25 pm »
new unthemed opensource candidate online version: http://open-explorer.io/

i am releasing an open source version of the explorer. to refresh, i made an initial mistake and used a purchased theme to make the project http://bitshares-explorer.io/ and now i removed all theme related stuff to make an open source version(much more harder to do than to say). i am sharing the 3 private repos in order to make sure the MIT version is good enough to don't bring any license trouble to bitshares.

after trying to contact the vendor by email asking how much he will charge to release the code under MIT without response i actually started a new project using  https://github.com/angular/angular-seed and added my code  into it, i followed some of the original purchased template rules like using grunt, bower and such but everything could be done without the theme in the first place so i think it should be fine.

just trying to make sure by having more eyes watching it.

- original theme: https://github.com/oxarbitrage/original-theme-explorer - online: http://bitshares-explorer.io/orig/#/
- explorer with theme: https://github.com/oxarbitrage/bitshares-explorer.io - online: http://bitshares-explorer.io/
- explorer unthemed: https://github.com/oxarbitrage/open-explorer.io - online: http://open-explorer.io/

if you think you can collaborate with this please drop me your github user and ill add you as collaborator of the 3 repos. i need to release the code of this asap.

thank you very much.

Online yvv

  • Hero Member
  • *****
  • Posts: 1185
    • View Profile
Re: open sourcing the explorer.
« Reply #1 on: December 19, 2017, 12:25:48 am »
To be honest, this explorer looks very good  +5%

I've spotted something that may be an error. Over here

http://open-explorer.io/#/assets

top left table says

Quote
24H MARKET CAP IN MILLION BTS
24H MARKET CAP IN MILLION USD
24H MARKET CAP IN MILLION CNY

but the numbers look like it is in BTS, USD, CNY, not million of BTS, USD, CNY. Please, check the units.

Offline Fox

Re: open sourcing the explorer.
« Reply #2 on: December 19, 2017, 02:00:29 am »
if you think you can collaborate with this please drop me your github user and ill add you as collaborator of the 3 repos. i need to release the code of this asap.

Please add ryanRfox to the repos and I will review with you. I appreciate your efforts in making this code open source.
Witness: fox

Offline oxarbitrage

Re: open sourcing the explorer.
« Reply #3 on: December 19, 2017, 02:16:40 pm »
if you think you can collaborate with this please drop me your github user and ill add you as collaborator of the 3 repos. i need to release the code of this asap.

Please add ryanRfox to the repos and I will review with you. I appreciate your efforts in making this code open source.

added you to the 3 repos, thanks.

To be honest, this explorer looks very good  +5%

I've spotted something that may be an error. Over here

http://open-explorer.io/#/assets

top left table says

Quote
24H MARKET CAP IN MILLION BTS
24H MARKET CAP IN MILLION USD
24H MARKET CAP IN MILLION CNY

but the numbers look like it is in BTS, USD, CNY, not million of BTS, USD, CNY. Please, check the units.


thank you for that, changed it in here: http://bitshares-explorer.io/#/assets and http://open-explorer.io/#/assets

please use https://github.com/oxarbitrage/bitshares-explorer/issues for issues.

Offline fav

  • Administrator
  • Hero Member
  • *****
  • Posts: 4267
  • No Pain, No Gain
    • View Profile
  • BitShares: fav
Re: open sourcing the explorer.
« Reply #4 on: December 19, 2017, 04:55:28 pm »
 http://open-explorer.io/ looking better than the one with theme in my opinion :)
► How-to Buy BitShares: https://goo.gl/i9j2YZ

Offline oxarbitrage

Re: open sourcing the explorer.
« Reply #5 on: December 19, 2017, 05:01:16 pm »
http://open-explorer.io/ looking better than the one with theme in my opinion :)

i think the same, it haves only what matters. after i release i will be able to resume the work in the issues it haves that are the same than in the themed version(https://github.com/oxarbitrage/bitshares-explorer/issues). will also get help  from the UI team in exchange for some work i am making for tradingview integration on the UI. also will get help from any that want to participate. i think it will be cool to have a github pages version that updates as code is merged.

Offline btswolf

Re: open sourcing the explorer.
« Reply #6 on: December 19, 2017, 08:13:42 pm »

Offline oxarbitrage

Re: open sourcing the explorer.
« Reply #7 on: December 19, 2017, 08:24:29 pm »
Thank you very much.

- explorer unthemed: https://github.com/oxarbitrage/open-explorer.io
That link does not work?


they are all closed repos until we check everything is in good shape to open source it in regards to licences. that is the repo i will actually open source after this review i am requesting. can send you access if you want, just send me your github username.

Offline Customminer

  • Hero Member
  • *****
  • Posts: 623
  • Bitshares FTW!
    • View Profile
  • GitHub: grctest
Re: open sourcing the explorer.
« Reply #8 on: December 26, 2017, 12:45:35 pm »
Looks great, keep up the excellent work :)

Offline oxarbitrage

Re: open sourcing the explorer.
« Reply #9 on: January 04, 2018, 09:19:12 pm »
bumping the thread, hoping to get the code released as soon as possible now the holidays passed. thanks again!

Offline Thom

Re: open sourcing the explorer.
« Reply #10 on: January 05, 2018, 05:30:05 pm »
I don't care for the unthemed version as much, but it is plenty adequate. Differences appear to be aesthetic and user preference oriented and not functionally significant.

Thank you for all your hard work and following through on the much needed alternative to cryptofresh, and your dedication to open source.
Injustice anywhere is a threat to justice everywhere - MLK |  Verbaltech2 Witness Reports: https://bitsharestalk.org/index.php/topic,23902.0.html

Offline oxarbitrage

Re: open sourcing the explorer.
« Reply #11 on: January 05, 2018, 05:37:55 pm »
thanks [member=21490]Thom[/member] . the only problem is that the unthemed version even if made from scratch uses some of the stuff that was already present in the themed licenced version. All what it uses is open source so i am 99% sure it will not be a problem if i just release it now but to be 100% sure i added this people to the private repos so they can take a look and make sure. maybe is the work for a lawyer specialized in code licence stuff, i don't know any unfortunately so i am leaving it at the hands of the bitshares community.

my main concern is actually be totally sure this will not bring any future problems to bitshares.

Offline oxarbitrage

Re: open sourcing the explorer.
« Reply #12 on: February 06, 2018, 08:31:19 pm »
explorer front end code released https://github.com/oxarbitrage/open-explorer under MIT.

Offline Customminer

  • Hero Member
  • *****
  • Posts: 623
  • Bitshares FTW!
    • View Profile
  • GitHub: grctest
Re: open sourcing the explorer.
« Reply #13 on: February 06, 2018, 09:00:41 pm »
explorer front end code released https://github.com/oxarbitrage/open-explorer under MIT.
Absolute legend! Great work :D  +5%