do you have modify the trade logic in this fork?

[hotpot999]

I have to fix also I have confirmed
it's very easy to develop a script  to attack the margin call orders.
and very danger to the system.






ufa1688

[hotpot999]

 what bull shit do you want to get from me?
I think I have describe the problem very clear  Bitshares blockchain is security, how good it can use to keep people's right, all bull shit.
maybe you are all cheaters.






ufa1688

[zhf9916888]

alt大神，你好。看了你的基于BTS内盘机器人交易的文章和设计。十分佩服。我也想用机器人做市；但目前相差网站www.btsbots.com已经打不开了，导致我不能使用。故特发邮件询问一下。多有打扰。谢谢。

[fav]

Sell your stake and move on if you don't see any value in your investment. This thread is moving nowhere.

[alt]

Yes, I got it.
the Blockchain never told me it coudn't sent 100 CNY to others when I want to transfer 10 CNY.
the Blockchain never told me it coudn't sent 100 USD to others when I want to transfer 10 CNY.
the Blockchain never told me it coudn't sent to account B when I want to transfer to account A.
the Blockchain never told me it coudn't sell at price 1.0 when I want to sell at price 10.0
the Blockchain never told me nobody can control my account without my key.
the Blockchain is just a joke.

so that's your point?
I think this Blockchain is far away to be a financial tools.
it's just a joke game.
all people told oethers how security DEX is are cheaters. you should never do it again.

nobody ever told me about these rule.

Who told you that the margin call would be filled at the lower price? I guess nobody did. It's just an assumption on your side.

I admit that it's a *reasonable* assumption, and that this is how it *should* work. But the fact that it doesn't is not a bug. It's just the way it has been implemented, and AFAIK it does not violate the specification.

It's not the only point where the market engine does not behave how people assume it does, see the case brought up by @alexpmorris a couple of months ago. The market engine needs an overhaul, but that is something that takes care, and planning, and detailed specifications, and lots of discussion. You don't do someting like this overnight.

[pc]

nobody ever told me about these rule.

Who told you that the margin call would be filled at the lower price? I guess nobody did. It's just an assumption on your side.

I admit that it's a *reasonable* assumption, and that this is how it *should* work. But the fact that it doesn't is not a bug. It's just the way it has been implemented, and AFAIK it does not violate the specification.

It's not the only point where the market engine does not behave how people assume it does, see the case brought up by @alexpmorris a couple of months ago. The market engine needs an overhaul, but that is something that takes care, and planning, and detailed specifications, and lots of discussion. You don't do someting like this overnight.

[alt]

I am good to accept the truth.
just need our spokeman told others the truth, and don't be a cheater.
never say to others how security the DEX is.
tell them it's a high risk action to use the DEX.

as the most active trader in DEX,
nobody ever told me about these rule.
so where is my compensation?

Bitshares owes you no compensation, in accordance with the implemented MIT license: https://github.com/bitshares/bitshares-core/blob/master/LICENSE.txt

Specifically:

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

[R]

as the most active trader in DEX,
nobody ever told me about these rule.
so where is my compensation?

Bitshares owes you no compensation, in accordance with the implemented MIT license: https://github.com/bitshares/bitshares-core/blob/master/LICENSE.txt

Specifically:

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

[alt]

how shameless this bitshares committee @fav is.
there is a flaw make me lost money, an will continue make more people lose.
you said this flaw is in the rule, you said this flaw is not emergency to fix.
and you lied to others the Bitshares blockchain is security, how good it can use to keep people's right, all bull shit.
maybe you are all cheaters.

as the most active trader in DEX,
nobody ever told me about these rule.
so where is my compensation?
I remember the committee member @fav have told me I will get it of course.
where is it now?

have you told the shorters they will lose 10% even there are plenty of bid orders in the market?
have you told the buyer their bid order can't be filled even their order is in the first position?
this is just another joke from the core team.

Shorters should know that they risk a 10% penalty when being margin called. None of the defined operational parameters are broken through this behaviour.
IMO this bug is a flaw, but not a serious problem. It certainly doesn't justify an emergency fix, or whatever you expect.

Make sure to contact the bitshares blockchain for a refund.

Good luck though, since every loss happened within the rules.

[rnglab]

@alt mate, for better or worst (it's up to us), code is not the law as you already know. Consensus is.

would you accept network funds to collaborate improving the DEX?

what are your thoughts about BSIP38's draft

[fav]

as the most active trader in DEX,
nobody ever told me about these rule.
so where is my compensation?
I remember the committee member @fav have told me I will get it of course.
where is it now?

have you told the shorters they will lose 10% even there are plenty of bid orders in the market?
have you told the buyer their bid order can't be filled even their order is in the first position?
this is just another joke from the core team.

Shorters should know that they risk a 10% penalty when being margin called. None of the defined operational parameters are broken through this behaviour.
IMO this bug is a flaw, but not a serious problem. It certainly doesn't justify an emergency fix, or whatever you expect.

Make sure to contact the bitshares blockchain for a refund.

Good luck though, since every loss happened within the rules.

[abit]

This should work properly by using your Smart asset to reduce the collateral first, then fill all orders until sold or until it reaches the margin call price.

IMHO this approach is a big change. Of course it's possible to change the code to something like this, although personally I don't like this behavior, it should be decided by stake holders, we can discuss the pros and cons first anyway.

[alt]

as the most active trader in DEX,
nobody ever told me about these rule.
so where is my compensation?
I remember the committee member @fav have told me I will get it of course.
where is it now?

have you told the shorters they will lose 10% even there are plenty of bid orders in the market?
have you told the buyer their bid order can't be filled even their order is in the first position?
this is just another joke from the core team.

Shorters should know that they risk a 10% penalty when being margin called. None of the defined operational parameters are broken through this behaviour.
IMO this bug is a flaw, but not a serious problem. It certainly doesn't justify an emergency fix, or whatever you expect.

[alt]

have you told the shorters they will lose 10% even there are plenty of bid orders in the market?
have you told the buyer their bid order can't be filled even their order is in the first position?
this is just another joke from the core team.

Shorters should know that they risk a 10% penalty when being margin called. None of the defined operational parameters are broken through this behaviour.
IMO this bug is a flaw, but not a serious problem. It certainly doesn't justify an emergency fix, or whatever you expect.

[sahkan]

I agree with @alt , this needs to be fixed. If we continue to have the sharp price drops in crypto we are bound to have some margin calls and the losses will be much greater than they should have been. This should work properly by using your Smart asset to reduce the collateral first, then fill all orders until sold or until it reaches the margin call price.

[ripplexiaoshan]

Mark, eyes on.

[sudo]

I don't know if you don't know what can happen with this flaw, or you don't care about others lost totally.
in fact the users could have lost millions USD in these days if somebody attack with this flaw.

when the price drop down, some short possition will be margin call after several minutes,
the attacker can borrow  0.1 CNY with collect rate just a little bit higher than the first debt position.
in fact he can create many short position like this.

the other hand, the attacker  create some bid orders prepare to fill the comming magin call orders. the bid price is feedprice/1.1

when the margin call happen, the small debt position will execute first, and make all bid orders be ignore just  like what happend to mine 4 days ago.
then the real big margin call orders will filled the attacker's bid order at feed price / 1.1

finally the attacker can sell these cheaper BTS to the bid orders which have be ignore just now.
so he can earn 10% without any risk.

 

[pc]

Shorters should know that they risk a 10% penalty when being margin called. None of the defined operational parameters are broken through this behaviour.
IMO this bug is a flaw, but not a serious problem. It certainly doesn't justify an emergency fix, or whatever you expect.

[alt]

if you still ignore the flaw,  you don't care about the users's profit.
I will try to attack.

[alt]

I don't know if you don't know what can happen with this flaw, or you don't care about others lost totally.
in fact the users could have lost millions USD in these days if somebody attack with this flaw.

when the price drop down, some short possition will be margin call after several minutes,
the attacker can borrow  0.1 CNY with collect rate just a little bit higher than the first debt position.
in fact he can create many short position like this.

the other hand, the attacker  create some bid orders prepare to fill the comming magin call orders. the bid price is feedprice/1.1

when the margin call happen, the small debt position will execute first, and make all bid orders be ignore just  like what happend to mine 4 days ago.
then the real big margin call orders will filled the attacker's bid order at feed price / 1.1

finally the attacker can sell these cheaper BTS to the bid orders which have be ignore just now.
so he can earn 10% without any risk.

[pc]

The issue was submitted a long ago, why wasn't the fix included in the last fork?

We discussed the fixes to be included in the hardfork here: https://bitsharestalk.org/index.php/topic,24816.0.html

At that time, the problem was only a side remark on issue #338. There several reasons why it wasn't included, like
* lack of manpower (at the time, @oxarbitrage was the only paid developer)
* the problem was not considered to be a serious one
* nobody came up and asked for a fix, or offered to help - as you can see from that thread, general interest from the community was almost non-existant
* we have a lot of issues regarding the market engine, so fixing this should be part of a bigger overhaul IMO

[yvv]

seems not the same issue.

This issue has been discussed on github:
* https://github.com/bitshares/bitshares-core/issues/453 and
* https://github.com/bitshares/bitshares-core/issues/338#issuecomment-318808452

There is a test case to reproduce it:
* https://github.com/bitshares/bitshares-core/pull/341/commits/aa60533269d7ca5e534bedb8a63ac4742d50164c

It's on the to-do list, will be fixed in a future release.

It is.

The issue was submitted a long ago, why wasn't the fix included in the last fork?

[alt]

it doesn't matter,
this type of flaw shoudn't be in the waiting todo list
it should be fixed ASAP

seems not the same issue.

This issue has been discussed on github:
* https://github.com/bitshares/bitshares-core/issues/453 and
* https://github.com/bitshares/bitshares-core/issues/338#issuecomment-318808452

There is a test case to reproduce it:
* https://github.com/bitshares/bitshares-core/pull/341/commits/aa60533269d7ca5e534bedb8a63ac4742d50164c

It's on the to-do list, will be fixed in a future release.

It is.

[abit]

seems not the same issue.

This issue has been discussed on github:
* https://github.com/bitshares/bitshares-core/issues/453 and
* https://github.com/bitshares/bitshares-core/issues/338#issuecomment-318808452

There is a test case to reproduce it:
* https://github.com/bitshares/bitshares-core/pull/341/commits/aa60533269d7ca5e534bedb8a63ac4742d50164c

It's on the to-do list, will be fixed in a future release.

It is.

[alt]

the exactly lose is I should have bought 1M BTS at price 2.8CNY/BTS,
but the marketing engine ignore my bid order, sold the 1M BTS to other orders which price lower than mine.

alt, did you really lose 1M (one million) BTS?

[alt]

I don't know who should take responsibility, but I'm sure it's not me.
or your spoke man should talk the truth to others, the DEX will not take any responsibility for your asset security
if there is a bug make your money disapear, you take responsibility by yourself.

I don't know what happend to you?! and you want who to give you an apologize?! the community?  the developer? the user? the Committee? the system?
If you hate the system flaw, destroy it in your way.
If you hate the BITSHARES, leave or destroy it in your way.

“Don’t let hatred control you, no matter what others do that causes [anger]. You would only become guilty of the same sin that afflicts them, and nothing would be solved.” —Billy Graham

You are a very good developer of BTS, do what you think is right.

[alt]

seems not the same issue.
your issue is matching price.
my issue is not filled my bid orders but others lower than me.

and if you care about the short position's profit,
you should resolve it ASAP.
because with this flaw, I can fill all margin call orders at feedprice/1.1 even there is many bid orders which have a high price than me. then sell these cheap BTS to the high bid orders.

This issue has been discussed on github:
* https://github.com/bitshares/bitshares-core/issues/453 and
* https://github.com/bitshares/bitshares-core/issues/338#issuecomment-318808452

There is a test case to reproduce it:
* https://github.com/bitshares/bitshares-core/pull/341/commits/aa60533269d7ca5e534bedb8a63ac4742d50164c

It's on the to-do list, will be fixed in a future release.

[fluxer555]

alt, did you really lose 1M (one million) BTS?

[binggo]

I don't know what happend to you?! and you want who to give you an apologize?! the community?  the developer? the user? the Committee? the system?
If you hate the system flaw, destroy it in your way.
If you hate the BITSHARES, leave or destroy it in your way.

“Don’t let hatred control you, no matter what others do that causes [anger]. You would only become guilty of the same sin that afflicts them, and nothing would be solved.” —Billy Graham

You are a very good developer of BTS, do what you think is right.

[abit]

This issue has been discussed on github:
* https://github.com/bitshares/bitshares-core/issues/453 and
* https://github.com/bitshares/bitshares-core/issues/338#issuecomment-318808452

There is a test case to reproduce it:
* https://github.com/bitshares/bitshares-core/pull/341/commits/aa60533269d7ca5e534bedb8a63ac4742d50164c

It's on the to-do list, will be fixed in a future release.

[alt]

Yes I have spent many time to help Bitshares in the past.
but it just doesn't worth any of my time any more.
because the bitshares core of mine have be fucked.

As a common user, I have lost 1M BTS because of the system flaw.
can you tell me what should I do?  keep silence and accept the lose?
24 hours past, no one give me even an apologize.

I have give the block number, all data in the blockchain.
what else do you need me to provide?

seems nobody will take responsibility for my lose because of the system bug?
and nobody care about repair the flaw to protect the short position?
this is what the great DEX you told to others?

Dude WTF happened to you ?  You used to be a star around hear everybody use to love  you, even Dan gave you accolades.  I used to think you are a genius. Now you are coming here and just fucking up everything, it is  like you are possessed or something ,like somebody is against you and we all want to fuck you.You are just threatening this and that ... WTF   . We know you are a smart guy but you should decide either you are on the dark side or not. Bitshares gave you a lot so if you want to help this is good and you'll got all the love in the world for all of us, if not don't act like you are the second coming of Jesus or Buddha or whatever you believe in, cause you are not..... Go ahead fuck up Bitshares and ruin all the fucking time you spend to built it. If not just calm down body we still love you man if you are with us. We will fucking fix your lose if you don't act like a douche-bag.....

[oco101]

seems nobody will take responsibility for my lose because of the system bug?
and nobody care about repair the flaw to protect the short position?
this is what the great DEX you told to others?

Dude WTF happened to you ?  You used to be a star around hear everybody use to love  you, even Dan gave you accolades.  I used to think you are a genius. Now you are coming here and just fucking up everything, it is  like you are possessed or something ,like somebody is against you and we all want to fuck you.You are just threatening this and that ... WTF   . We know you are a smart guy but you should decide either you are on the dark side or not. Bitshares gave you a lot so if you want to help this is good and you'll got all the love in the world for all of us, if not don't act like you are the second coming of Jesus or Buddha or whatever you believe in, cause you are not..... Go ahead fuck up Bitshares and ruin all the fucking time you spend to built it. If not just calm down body we still love you man if you are with us. We will fucking fix your lose if you don't act like a douche-bag.....

[alt]

seems nobody will take responsibility for my lose because of the system bug?
and nobody care about repair the flaw to protect the short position?
this is what the great DEX you told to others?

[alt]

what bull shit do you want to get from me?
I think I have describe the problem very clear.

what ever, I guess somebody should pay for my lost.  and also pay for the shorters lost.
sell 969536 BTS to me at price 2.84
and send some BTS to the margin call owner, they should spent less BTS to pay for the debt.

I'm sure the blockchain will give you a refund.

stop the cryptic bullshit please, if there's an issue make a clear post.

[fav]

what ever, I guess somebody should pay for my lost.  and also pay for the shorters lost.
sell 969536 BTS to me at price 2.84
and send some BTS to the margin call owner, they should spent less BTS to pay for the debt.

I'm sure the blockchain will give you a refund.

stop the cryptic bullshit please, if there's an issue make a clear post.

[Brekyrself]

I have confirmed
it's very easy to develop a script  to attack the margin call orders.
and very danger to the system.

this is another fuck flaw because of this BSIP18 fork.

Can you please describe this to the dev's in private?  For the sake of BitShares, work with the dev's to make BitShares better!

[alt]

I have confirmed
it's very easy to develop a script  to attack the margin call orders.
and very danger to the system.

this is another fuck flaw because of this BSIP18 fork.

[alt]

I may know the problem.
if it's what I think, maybe there is  some technicals way to make the shorters lose more.
you should react soon and need another fork.

[alt]

what ever, I guess somebody should pay for my lost.  and also pay for the shorters lost.
sell 969536 BTS to me at price 2.84
and send some BTS to the margin call owner, they should spent less BTS to pay for the debt.

[alt]

no, it's not protection, seems like a random behave.
it hurt the short position also, they sold BTS at lower price than it should.

block 22,800,824, I create the buy order
block 22,800,845, the margin call happen. and only 66517.4995 CNY filled my order. the orders filled at price lower than me.

what the hell this logic?

[yvv]

Is this because of short squeeze protection? I also wander, why the hell do we need it? If a shorter can't maintain collateral, let him take a hit.

[alt]

I have a buy order at price 2.84

Code: [Select]

2.840 10000.0000 28405.0000 kaifeng9
2.840 969536.4689 2753532.0542 demo.btsbots
2.840 3038.1662 8628.5439 abcbts
there are 2.8M CNY margin call,
the margin call order not filled my buy order, but others more less price.
what have you done to the trade logic?
who will take responsibility to my lost?

 

Code: [Select]

12/20 12:38:06 2.833 16970.4275 48077.2211 xlggd tara
12/20 12:38:06 2.835 35263.8986 99973.1561 xlggd yxb
12/20 12:38:06 2.835 1763.6683 5000.0000 xlggd exchange.btsbots
12/20 12:38:06 2.839 352.1127 1000.0000 xlggd hsh19830907
12/20 12:38:06 2.840 100000.0000 284000.0000 xlggd ags
12/20 12:38:06 2.840 3521.1268 10000.0000 xlggd bts8129
12/20 12:38:06 2.840 35193.3518 99949.1228 xlggd yxb
12/20 12:38:06 2.840 50000.0000 142000.5000 xlggd