Author [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] Topic: Market search lagging glitch  (Read 485 times)

0 Members and 1 Guest are viewing this topic.

Offline islandking

  • Sr. Member
  • ****
  • Posts: 378
  • The king of the island
    • View Profile
Market search lagging glitch
« on: December 02, 2014, 10:24:26 PM »

In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.
I've been working on a new electronic cash system that's fully peer-to-peer, with no trusted third party. - Satoshi

Offline vikram

Re: Market search lagging glitch
« Reply #1 on: December 02, 2014, 10:27:41 PM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

Offline svk

Re: Market search lagging glitch
« Reply #2 on: December 03, 2014, 09:51:59 AM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

I made a pull request last night to fix this issue, just needed to limit the amount of entries shown in the typeahead list.
Worker: dev.bitsharesblocks

Offline islandking

  • Sr. Member
  • ****
  • Posts: 378
  • The king of the island
    • View Profile
Re: Market search lagging glitch
« Reply #3 on: December 03, 2014, 02:42:01 PM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

I made a pull request last night to fix this issue, just needed to limit the amount of entries shown in the typeahead list.

 +5% Thanks svk!
I've been working on a new electronic cash system that's fully peer-to-peer, with no trusted third party. - Satoshi

Offline jsidhu

  • Hero Member
  • *****
  • Posts: 1337
    • View Profile
Re: Market search lagging glitch
« Reply #4 on: December 03, 2014, 05:50:47 PM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

I made a pull request last night to fix this issue, just needed to limit the amount of entries shown in the typeahead list.

Does this limit the feature then? Will it page instead? How would typeahead work for things that are above the limit of allowed entries?
Hired by blockchain | Developer
delegate: dev.sidhujag

Offline svk

Re: Market search lagging glitch
« Reply #5 on: December 03, 2014, 06:41:55 PM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

I made a pull request last night to fix this issue, just needed to limit the amount of entries shown in the typeahead list.

Does this limit the feature then? Will it page instead? How would typeahead work for things that are above the limit of allowed entries?
Yea you need to be a bit more precise basically. I set the limit to 10 but we could increase it I guess. It's not really practical browsing through hundreds of entries though.
Worker: dev.bitsharesblocks

Offline jsidhu

  • Hero Member
  • *****
  • Posts: 1337
    • View Profile
Re: Market search lagging glitch
« Reply #6 on: December 04, 2014, 10:25:23 PM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

I made a pull request last night to fix this issue, just needed to limit the amount of entries shown in the typeahead list.

Does this limit the feature then? Will it page instead? How would typeahead work for things that are above the limit of allowed entries?
Yea you need to be a bit more precise basically. I set the limit to 10 but we could increase it I guess. It's not really practical browsing through hundreds of entries though.

Yea... this kind of thing only works when you know what you are searching for or keywords to look for... if you don't know (then you are browsing), you need a good way to be able to browse all the data without sacrificing usability.

It would be interesting to see whre the bottleneck lies.. on the front-end side "drawing" the entries or on the backend, having to download the data... if its drawing, and you are searching across everything anyway and only showing up to 10 results at a time that is a fair tradeoff I think, if that's the way its working.

If it's downloading then server-side paging is really the only answer.
Hired by blockchain | Developer
delegate: dev.sidhujag

Offline svk

Re: Market search lagging glitch
« Reply #7 on: December 04, 2014, 10:43:51 PM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

I made a pull request last night to fix this issue, just needed to limit the amount of entries shown in the typeahead list.

Does this limit the feature then? Will it page instead? How would typeahead work for things that are above the limit of allowed entries?
Yea you need to be a bit more precise basically. I set the limit to 10 but we could increase it I guess. It's not really practical browsing through hundreds of entries though.

Yea... this kind of thing only works when you know what you are searching for or keywords to look for... if you don't know (then you are browsing), you need a good way to be able to browse all the data without sacrificing usability.

It would be interesting to see whre the bottleneck lies.. on the front-end side "drawing" the entries or on the backend, having to download the data... if its drawing, and you are searching across everything anyway and only showing up to 10 results at a time that is a fair tradeoff I think, if that's the way its working.

If it's downloading then server-side paging is really the only answer.

It's definitely on the front-end, it's basically instant with the limitation in place. The freezing comes from the drawing of the DOM nodes for all the results in the list, the way it works with my fix it only draws 10 items at a time so it's nice and fast. The drawback is that since we have probably several thousand combinations starting with "bit", right now you'll only see the first 10 of them, hence why I said you need to be bit more specific. I doubt anyone would want to page through that kind of list anyway ;)
Worker: dev.bitsharesblocks

Offline jsidhu

  • Hero Member
  • *****
  • Posts: 1337
    • View Profile
Re: Market search lagging glitch
« Reply #8 on: December 04, 2014, 10:55:35 PM »
In the BTS client when I click on "market" and then try to search in "search market" it lags for up to 30 seconds and is extremely slow.

We'll take a look: https://github.com/BitShares/web_wallet/issues/488

I made a pull request last night to fix this issue, just needed to limit the amount of entries shown in the typeahead list.

Does this limit the feature then? Will it page instead? How would typeahead work for things that are above the limit of allowed entries?
Yea you need to be a bit more precise basically. I set the limit to 10 but we could increase it I guess. It's not really practical browsing through hundreds of entries though.

Yea... this kind of thing only works when you know what you are searching for or keywords to look for... if you don't know (then you are browsing), you need a good way to be able to browse all the data without sacrificing usability.

It would be interesting to see whre the bottleneck lies.. on the front-end side "drawing" the entries or on the backend, having to download the data... if its drawing, and you are searching across everything anyway and only showing up to 10 results at a time that is a fair tradeoff I think, if that's the way its working.

If it's downloading then server-side paging is really the only answer.

It's definitely on the front-end, it's basically instant with the limitation in place. The freezing comes from the drawing of the DOM nodes for all the results in the list, the way it works with my fix it only draws 10 items at a time so it's nice and fast. The drawback is that since we have probably several thousand combinations starting with "bit", right now you'll only see the first 10 of them, hence why I said you need to be bit more specific. I doubt anyone would want to page through that kind of list anyway ;)

But it is a search and not meant to be a browsable category based list or something.. so if they want to browse they should do it through another means, and that should be paged... yea if its angular based and you're setting up watches on all those entries or they are drawn with {item.details} or whatenot then it will slow things down... DOM manipulation is slow.

A search is a search is a search... should only show things when you know what to look for.

A browsable list would have categories and a hierarchical display so its easy to navigate and pinpoint what you are trying to find.
Hired by blockchain | Developer
delegate: dev.sidhujag

 

Google+