Author [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] Topic: Increase the memo field in the transaction to 64 characters  (Read 939 times)

Offline monsterer

Increase the memo field in the transaction to 64 characters
« on: January 15, 2015, 09:07:15 AM »

That way a memo can reference a bitcoin address, or bitcoin TXID as well as bitshares trxid and account name.

The current length cant even accommodate a bitcoin address.

use case: gateways - having the user put their desired bitcoin address into the memo field of a bitshares transaction removes the need to import private keys into the bitshares wallet, which is fragile and only works once due to change addresses.
« Last Edit: January 15, 2015, 09:25:49 AM by monsterer »
My opinions do not represent those of metaexchange unless explicitly stated.
https://metaexchange.info | Bitcoin<->Altcoin exchange | Instant | Safe | Low spreads

Offline liondani

Re: Increase the memo field in the transaction to 64 characters
« Reply #1 on: January 15, 2015, 09:22:29 AM »
That way a memo can reference a bitcoin address, or bitcoin TXID as well as bitshares trxid and account name.

The current length cant even accommodate a bitcoin address.
+5

Sent from my ALCATEL ONE TOUCH 997D

  https://bitshares.OPENLEDGER.info/?r=GREECE  | You are in Control | BUY | SELL | SHORT | SWAP | LOAN | TRADE |  

Offline Markus

  • Sr. Member
  • ****
  • Posts: 366
    • View Profile
Re: Increase the memo field in the transaction to 64 characters
« Reply #2 on: January 15, 2015, 10:04:13 AM »
Good idea.
Maybe charge an extra high transaction fee for long memos to avoid bloat?

Offline monsterer

Re: Increase the memo field in the transaction to 64 characters
« Reply #3 on: January 15, 2015, 10:35:53 AM »
Good idea.
Maybe charge an extra high transaction fee for long memos to avoid bloat?

Yeah, maybe transaction fee could be per kb?
My opinions do not represent those of metaexchange unless explicitly stated.
https://metaexchange.info | Bitcoin<->Altcoin exchange | Instant | Safe | Low spreads

Offline cass

  • Hero Member
  • *****
  • Posts: 4320
  • /(┬.┬)\
    • View Profile
Re: Increase the memo field in the transaction to 64 characters
« Reply #4 on: January 15, 2015, 12:29:15 PM »
IMO good idea
█║▌║║█  - - -  The quieter you become, the more you are able to hear  - - -  █║▌║║█

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 11963
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BTS: xeroc
  • GitHub: xeroc
Re: Increase the memo field in the transaction to 64 characters
« Reply #5 on: January 15, 2015, 12:35:01 PM »
according to
https://github.com/BitShares/bitshares/blob/master/libraries/blockchain/include/bts/blockchain/config.hpp#L39

The memo limit is currently 19bytes .. for a ripemd160 hash of a public key you need 160bit which is 20 byte ..
so actually we are very close to what is required .. increasing the limit to 20bytes would be enough ..

not sure what the argumentation has been to set it at 19bytes in the first place
Give BitShares a try! Use the http://testnet.bitshares.eu provided by http://bitshares.eu powered by ChainSquad GmbH

Offline svk

Re: Increase the memo field in the transaction to 64 characters
« Reply #6 on: January 15, 2015, 01:14:35 PM »
according to
https://github.com/BitShares/bitshares/blob/master/libraries/blockchain/include/bts/blockchain/config.hpp#L39

The memo limit is currently 19bytes .. for a ripemd160 hash of a public key you need 160bit which is 20 byte ..
so actually we are very close to what is required .. increasing the limit to 20bytes would be enough ..

not sure what the argumentation has been to set it at 19bytes in the first place
I think they lowered it for v0.4.27 actually, I know at one point I could no longer use the same memo I had used before.  It even caused those transactions that had the earlier, longer memos to disappear from my transaction history.
Worker: dev.bitsharesblocks

Offline bytemaster

Re: Increase the memo field in the transaction to 64 characters
« Reply #7 on: January 15, 2015, 01:15:29 PM »
It was either 19 or 35 due to aes encryption chunk size. 
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 11963
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BTS: xeroc
  • GitHub: xeroc
Re: Increase the memo field in the transaction to 64 characters
« Reply #8 on: January 15, 2015, 01:45:53 PM »
It was either 19 or 35 due to aes encryption chunk size.
so what's the argument against increasing the memo size to 35 bytes again?
Give BitShares a try! Use the http://testnet.bitshares.eu provided by http://bitshares.eu powered by ChainSquad GmbH

Offline monsterer

Re: Increase the memo field in the transaction to 64 characters
« Reply #9 on: January 15, 2015, 06:26:45 PM »
according to
https://github.com/BitShares/bitshares/blob/master/libraries/blockchain/include/bts/blockchain/config.hpp#L39

The memo limit is currently 19bytes .. for a ripemd160 hash of a public key you need 160bit which is 20 byte ..
so actually we are very close to what is required .. increasing the limit to 20bytes would be enough ..

not sure what the argumentation has been to set it at 19bytes in the first place

Remembers its the base58 version of the address in the memo, so will take 34 bytes not including EOL
My opinions do not represent those of metaexchange unless explicitly stated.
https://metaexchange.info | Bitcoin<->Altcoin exchange | Instant | Safe | Low spreads

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 11963
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BTS: xeroc
  • GitHub: xeroc
Re: Increase the memo field in the transaction to 64 characters
« Reply #10 on: January 15, 2015, 07:13:33 PM »
according to
https://github.com/BitShares/bitshares/blob/master/libraries/blockchain/include/bts/blockchain/config.hpp#L39

The memo limit is currently 19bytes .. for a ripemd160 hash of a public key you need 160bit which is 20 byte ..
so actually we are very close to what is required .. increasing the limit to 20bytes would be enough ..

not sure what the argumentation has been to set it at 19bytes in the first place

Remembers its the base58 version of the address in the memo, so will take 34 bytes not including EOL
no one forces you to base58 encode the address ... you could also go binary
 .. also no one forces you add the checksum (4 bytes) as those should be checked before anyway ..

afaik the memo could be binary .. may look crappy .. but could :)
Give BitShares a try! Use the http://testnet.bitshares.eu provided by http://bitshares.eu powered by ChainSquad GmbH

Offline theoretical

Re: Increase the memo field in the transaction to 64 characters
« Reply #11 on: January 15, 2015, 07:19:00 PM »
Could we have an "extended memo" op that replaces the memo with text of arbitrary length?

We should have separate fields for encrypted ("public memo") and unencrypted ("private memo") contents, each of which can be arbitrary length (of course max tx size sets an effective limit).  The client should automatically add a 64-bit nonce to the encrypted memo (and strip it on the receiving side).  The nonce is to boost the entropy, e.g. if you're sending a bitcoin address in the memo field, without the nonce an attacker could find out the memo contents by simply encrypting all Bitcoin addresses in existence with the recipient's public key.

If the blockchain was frozen, I'd suggest re-purposing the burn op for this, but since we obviously have hardforks planned, it makes sense to just make a new op.
BTS- theoretical / PTS- PZxpdC8RqWsdU3pVJeobZY7JFKVPfNpy5z / BTC- 1NfGejohzoVGffAD1CnCRgo9vApjCU2viY / the delegate formerly known as drltc / Nothing said on these forums is intended to be legally binding / All opinions are my own unless otherwise noted / Take action due to my posts at your own risk

Offline bytemaster

Re: Increase the memo field in the transaction to 64 characters
« Reply #12 on: January 15, 2015, 07:33:59 PM »
https://github.com/BitShares/bitshares/issues/1258

I'll add the ability to have an extra 32 bytes for a total of 51 bytes.   That should be plenty to contain a bitcoin address.  In theory we should be moving away from using the memo field all together, but it does not require a hard fork to support 51 bytes, just wallet support.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline theoretical

Re: Increase the memo field in the transaction to 64 characters
« Reply #13 on: January 15, 2015, 08:11:47 PM »
In theory we should be moving away from using the memo field all together

What's the replacement?  Mail?
BTS- theoretical / PTS- PZxpdC8RqWsdU3pVJeobZY7JFKVPfNpy5z / BTC- 1NfGejohzoVGffAD1CnCRgo9vApjCU2viY / the delegate formerly known as drltc / Nothing said on these forums is intended to be legally binding / All opinions are my own unless otherwise noted / Take action due to my posts at your own risk

Offline bytemaster

Re: Increase the memo field in the transaction to 64 characters
« Reply #14 on: January 15, 2015, 08:13:45 PM »
In theory we should be moving away from using the memo field all together

What's the replacement?  Mail?

Yes
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

 

Google+