Author Topic: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017  (Read 18537 times)

0 Members and 1 Guest are viewing this topic.


Offline oxarbitrage

Hello stakeholders, this is the last report from this worker in this thread.

I have a new worker proposal voting now to start 22th of this month as i am taking a week of vacation starting today.

Take a look at the new worker proposal here and vote for it if you like:

https://github.com/oxarbitrage/worker-proposals/blob/master/bitshares2018_1.md

New worker proposal number is 1.14.75

If approved, the reports will be posted bi weekly on the new worker thread at:

https://bitsharestalk.org/index.php/topic,25713.0.html

I want to thank everybody for supporting me and i hope i can continue here for the starting year, very exiting year for sure.

The worker has liquidated all the payment left and in the process of burning back 127118 BTS to the chain. This operation is already made and it is just waiting for 1 approval vote from the worker escrow, this will be happening in the next few hours.

Now let me go over the last advances, this was a period where it was hard to reach other bitshares devs for the holiday season, for this reason most of the work was focused outside core.

bitshares-core:

- issue https://github.com/bitshares/bitshares-core/issues/549 fixed with merged pull request: https://github.com/bitshares/bitshares-core/pull/551

- https://github.com/bitshares/bitshares-core/issues/528 finished documentation for elasticsearch plugin and moved to wiki page of bitshares: https://github.com/bitshares/bitshares-core/wiki/ElasticSearch-Plugin

- Small readme notes changes: https://github.com/bitshares/bitshares-core/pull/562

- review and merged https://github.com/bitshares/bitshares-core/pull/557

- merged https://github.com/bitshares/bitshares-core/pull/568 from @xeroc - docker updates.

- created new api call get_top_markets - https://github.com/bitshares/bitshares-core/pull/560

there are some other pending reviews from @abit, @pc and @xeroc that i will be able to finish when i came back from vacation or they will review each other if they want to merge before that.

account history exporter:

an account history exporter was made:

http://open-explorer.io/bitshares-account-exporter/index.php

It makes use of the elasticsearch node plugin and wrapper. Open source code in php can be found at: https://github.com/oxarbitrage/bitshares-account-exporter

There are plans to make a reduced version of it only exporting fill orders to be used with https://cointracking.info/

udf wrapper:

The udf wrapper was finished https://github.com/oxarbitrage/udf-bitshares-wrapper and was added as a proof of concept to the 2 explorer versions:

http://open-explorer.io/#/markets/CNY/BTS
http://bitshares-explorer.io/#/markets/CNY/BTS

The issue for it in UI was closed: https://github.com/bitshares/bitshares-ui/issues/773

I received the payment, i wanted to exchange it for some explorer work with the UI guys but they are to busy to do so at the moment.

Still, there are going to be more opportunities to make this deal in the future with other features the UI may need.

- bitshares-api-backend:

In addition to fixes i always do to this repo when i find a bug from the explorer i am now getting some contributions from @knaperek. He is helping as a volunteer to learn some bitshares with several stuff like dockerizing the project and fixing some bugs.

His contributions can be found at:

https://github.com/oxarbitrage/bitshares-python-api-backend/pull/1
https://github.com/oxarbitrage/bitshares-python-api-backend/pull/2
https://github.com/oxarbitrage/bitshares-python-api-backend/pull/3
https://github.com/oxarbitrage/bitshares-python-api-backend/pull/4

All of them were merged.


Thank you guys all again.

Offline oxarbitrage

the setup is elasticsearch database listening on localhost and elasticsearch wrapper exposed to the internet: https://github.com/oxarbitrage/bitshares-es-wrapper

Offline pc

  • Hero Member
  • *****
  • Posts: 1530
    • View Profile
    • Bitcoin - Perspektive oder Risiko?
  • BitShares: cyrano
- my contract with the blockchain will end 8/1/2018. i plan to renew, will send more details in a new worker text but will be very similar to the current contract(same money, same escrow, same period of time, pretty much same tasks).

I fully support that. You have done a great job, Alfredo!

The elasticsearch looks pretty straight forward, I am open to getting this installed on my Los Angeles node to get this tested as well.

Please be careful. AFAIK exposing an ES node to the internet is dangerous.
Bitcoin - Perspektive oder Risiko? ISBN 978-3-8442-6568-2 http://bitcoin.quisquis.de

Offline sahkan

  • Sr. Member
  • ****
  • Posts: 247
    • View Profile
    • BitShares DEX
The elasticsearch looks pretty straight forward, I am open to getting this installed on my Los Angeles node to get this tested as well.

Offline oxarbitrage

forgot to mention 2 things ...

- my contract with the blockchain will end 8/1/2018. i plan to renew, will send more details in a new worker text but will be very similar to the current contract(same money, same escrow, same period of time, pretty much same tasks). if you have any ideas to add new tasks please let me know and i will consider them.

i already contacted some of the proxies to tell them this, i will try to contact them all and inform the community in general by different channels.

- happy holidays to all!

Offline oxarbitrage

work done in the last 15 days, a bit late sorry about that.

bitshares-core:

- https://github.com/bitshares/bitshares-core/issues/514 - helping new user explaining how bitshares and dpos works. closed.

- https://github.com/bitshares/bitshares-core/issues/521 - add version command to cli_wallet and witness_node. pull created and merged: https://github.com/bitshares/bitshares-core/issues/521
Then we saw it was better toi have this code moved to a new file, related issue for that is https://github.com/bitshares/bitshares-core/issues/535 and pull https://github.com/bitshares/bitshares-core/pull/536

- https://github.com/bitshares/bitshares-core/issues/509 - review pull from @abit to improve this. pull: https://github.com/bitshares/bitshares-core/pull/513  - merged.

- https://github.com/bitshares/bitshares-core/pull/500 - additional commits had been added to this plugin but then started with the release and as the plugin was not going to be included there it was on hold for the last 2 weeks. resuming the work on it this starting week.

- On December 12 we started working on a new release with the last changes since fork. Not going to add all the pulls and merges from branches we did to make the release, the important is that at this point we have the testnet / master / develop branch all with the same code. After testing we made a pre release version of the new master and finally after a few days we released fully the last bitshares version. Details of what was included can be found at: https://github.com/bitshares/bitshares-core/releases/tag/2.0.171212

- https://github.com/bitshares/bitshares-core/pull/430 - after testing and modifications we finally merged the get_account_history_by_operations for exchanges api call and wallet call submitted by @zhuliting.

- review and approved some commits from @pc that were lost inside an unmerged pull request: https://github.com/bitshares/bitshares-core/pull/546 and https://github.com/bitshares/bitshares-core/pull/547

- https://github.com/bitshares/bitshares-core/pull/548 - approved an update in ram needed to run a full node but requested the contributor to sumbit it to the develop branch.

udf wrapper:

https://github.com/bitshares/bitshares-ui/issues/773

The udf wrapper is needed to add TradingView chart support to the bitshares-ui.

Version 1 of the program with online demo is here:

https://github.com/oxarbitrage/udf-bitshares-wrapper

Some issues were already added by me to it at:

https://github.com/oxarbitrage/udf-bitshares-wrapper/issues

elasticsearch-wrapper:

https://github.com/oxarbitrage/bitshares-es-wrapper

finished version 1 of the project. samples of what can be obtained are in the README. As a demo the transactions list from the explorer are pulled by using the wrapper: http://open-explorer.io/#/txs

more integration will came next in the explorer with elasticsearch and also of elasticsearch and the bitshares-ui, both using the api exposed by this wrapper.

A note about wrappers:

I have 3 wrappers at this time and more will eventually came if is needed. All wrappers are python 2 and run by flask. Flask is ok for development and for demos but in production this wrappers need to run behind a real webserver. Instructions to do this in nginx will be provided in a document soon.

A note about elasticsearch full node:

I am helping @Fox  to setup a full elasticsearch node with wrapper. This will be the first active witness on having this setup. Plan is to provide stable api access to elasticsearch data for dapps.

Open sourcing the explorer:

in my last report i exposed that the open sourcing of the explorer was the most important thing to do. Check previous post explorer section.

So i made a clean unthemed version http://bitshares-explorer.io/#/dashboard

I made it totally from scratch by starting the project with https://github.com/angular/angular-seed but used some ideas from the orignal theme. To make fully sure bitshares will not be involved in a license issue i have the repo in private until some members of the community can review it and we can release it under MIT.

see more about this at: https://bitsharestalk.org/index.php/topic,25570.0.html

i have a few people added to the review but this days are very slow as so many people is on vacation or not in full mode. I want to release the code of the explorer asap so if someone want to help just let me know and ill add you to the private repos.

Offline oxarbitrage

Dear bitshares stakeholders and general public that may be reading, here is a report of the documented work done in the last 15 days by this worker.

bitshares-core:

- https://github.com/bitshares/bitshares-core/pull/488 - @xeroc submitted a fix for his docker configurations that was merged into the develop branch.

- @xeroc new docker codes replaces https://github.com/bitshares/bitshares-core/pull/376 so it was closed.

- merged docker config by xeroc to fix curl dependency of develop branch(needed for elasticsearch plugin): https://github.com/bitshares/bitshares-core/pull/498

- closed docker related issue: https://github.com/bitshares/bitshares-core/issues/318

- https://github.com/bitshares/bitshares-core/issues/358 - @pc suggested that exposing the whole elasticsearch database to the internet may be risky. for this reason i am working on a small python wrapper so the UI and other apps can make queries to that instead of directly the database. This wrapper is work in progress just started and it is located by now here: https://github.com/oxarbitrage/bitshares-es-wrapper

- a small deprecated text was found by a contributor in the p2p code of bitshares. his change was merged to the develop branch: https://github.com/bitshares/bitshares-core/pull/489

- https://github.com/bitshares/bitshares-core/issues/484 - some assitance was provided to a new developer trying to work with bitshares in this issue and in telegram developer channel.

- https://github.com/bitshares/bitshares-core/pull/478 - After testing this by setting up nodes and others we finally merged the changes made by @abit that deal with extreme values in market history data that were making charts to look very bad. This pull allowed to close several issues, after reviews by @sivek, myself and other contributors from telegram we merged the code. Big improvement here.

- https://github.com/bitshares/bitshares-core/pull/494 - merged small typo pull request.

- https://github.com/bitshares/bitshares-core/issues/499 - tested, was not able to find memory leak issuer presents following his steps, memory remains the same, closing the issue.

- https://github.com/bitshares/bitshares-core/pull/500 - in addition to the former ES plugin that saves account history data to the database we created a new plugin that saves additional data, needed to fix several issues and make queries of some data easier. It is in progress and not merged yet, related discussion and more info can be found in the pull.

- https://github.com/bitshares/bitshares-core/pull/507 - 2 new functions were proposed in the pull to create and read memos in the cli_wallet. After testing and reviewing the code it was concluded that it works good so the pull was merged.

- https://github.com/bitshares/bitshares-core/issues/126 - closed as issue is too old and part of it is solved at present time.

- fixed https://github.com/bitshares/bitshares-core/issues/66 with https://github.com/bitshares/bitshares-core/pull/508

- https://github.com/bitshares/bitshares-core/issues/514 - trying to bring some light to this new bitshares enthusiast on how the system works.

bsips:

- some small technical additions were added to bsip28 proposed by @bill butler. https://github.com/bitshares/bsips/pull/41

explorer:

- https://github.com/oxarbitrage/bitshares-explorer/pull/13 -> added pull with link to bitshares explorer api backend.

- https://github.com/oxarbitrage/bitshares-explorer/issues/12 - this is very important so i have it as the highest priority for the explorer even if i know there are other issues in charting,  more data, presentation of data, etc people want to see; the release of the code will bring contributions from outside that will make the whole thing go faster.

This will be easy if it was not by the theme restrictions it haves and the initial error i made of building the explorer on top of it. I contacted the theme owner several days ago to see if it could be a possibility to open source it(for a price). No response yet.

In the last few days i had been in conversations with the UI team in order to develop an UDF wrapper needed to add trading view charts to the reference UI. The issue for it is at https://github.com/bitshares/bitshares-ui/issues/773 and had been assigned to me with 20 hours.
As i already have a position in bitshares i will not be getting this 20 hours in cash but instead i am going to exchange it by work in the explorer. A first option will be to get some help in the release of the project, i already discussed with Calvin and he can help here. Another option is to make that work myself and invest the 20 hours(or more, as i am not sure how much the UDF thing will take) for other explorer work. Open to suggestions here.

Offline oxarbitrage

Nice work. I would personally like to see a chart on your new Explorer that shows Dex BitUSD - equivalent volume on a scalable basis (and filterable for Smartcoins vs UIA, for example, or by single asset pairing)

Hey @renko, sorry i didn't saw your message before. Can you please open an issue for it at https://github.com/oxarbitrage/bitshares-explorer/issues
I will be happy to do it, please also include some more details about it like where in the explorer you will want that placed. assets page(http://bitshares-explorer.io/#/assets)? bitusd page(http://bitshares-explorer.io/#/assets/1.3.121)?  and what do you want to be charted more specifically as i don't fully understand it. thanks!

Offline renkcub

  • Full Member
  • ***
  • Posts: 143
    • View Profile
Nice work. I would personally like to see a chart on your new Explorer that shows Dex BitUSD - equivalent volume on a scalable basis (and filterable for Smartcoins vs UIA, for example, or by single asset pairing)

Offline fav

  • Hero Member
  • *****
  • Posts: 4278
  • No Pain, No Gain
    • View Profile
    • Follow Me!
  • BitShares: fav

Offline oxarbitrage

Fellows, here the pull requests, issues, etc i was working on in the last 2 weeks:

bitshares-core:

- moved discussion about new features of worker proposal into a BSIP created by @billbutler at https://github.com/bitshares/bsips/blob/master/bsip-0028.md. We closed https://github.com/bitshares/bitshares-core/issues/451 and https://github.com/bitshares/bitshares-core/issues/473 from the core discussions. Sent pull request to update technical aspects of the new BSIP: https://github.com/bitshares/bsips/pull/41

- https://github.com/bitshares/bitshares-core/issues/465 - added pull to include 15 mins, 30 mins and 4hs buckets, removing 15 seconds: https://github.com/bitshares/bitshares-core/pull/466

- https://github.com/bitshares/bitshares-core/issues/403 reviewed @abit code at https://github.com/bitshares/bitshares-core/pull/464, after some error fix we merged.

- opened issue https://github.com/bitshares/bitshares-core/issues/452 for referral index. found bug when exploring referral available code for explorer. no fix yet - relative low priority as client can still loop throw all accounts.

- https://github.com/bitshares/bitshares-core/pull/444 - after a lot of work the elasticsearch plugin has been finally merged to the develop branch.

- https://github.com/bitshares/bitshares-core/pull/471 - added code to allow plugins to have descriptions. merged.

- https://github.com/bitshares/bitshares-core/issues/476 - add curl as dependecy to documentation : https://github.com/bitshares/docs.bitshares.org/pull/22/files and https://github.com/bitshares/bitshares-core/pull/477

- reviewed and merged https://github.com/bitshares/bitshares-core/pull/479 to fix https://github.com/bitshares/bitshares-core/issues/409 (doxygen issue with last stable debian)

- https://github.com/bitshares/bitshares-core/issues/449 - tested, setted up tmp public node for interested parties to test in. changes were merged and the chart data from the core does not need any filtering anymore. can see it working at: http://bitshares-explorer.io/#/markets/CNY/BTS

- merged docker files from @xeroc https://github.com/bitshares/bitshares-core/pull/482

bitshares-fc:

- a pull request was submitted to FC to make bitshares project compile with newer version of boost(up to 1.63) https://github.com/bitshares/bitshares-fc/pull/5 - after testing we merged the solution.

- another pull address the compile problem of GCC 7.2. merged solution also: https://github.com/bitshares/bitshares-fc/pull/6

- @abit made the needed changes to reflect the new changes from bitshares-fc into bitshares-core. Tested and merged the whole solution: https://github.com/bitshares/bitshares-core/pull/483

- added documentation to include new supported versions of boost at https://github.com/bitshares/bitshares-core/wiki and https://github.com/bitshares/bitshares-core/pull/486

explorer:

- An issue in the explorer was making the python interface to crash when too much traffic are browsing the explorer at the same time. I was able to change the configuration of the backend to run under Nginx and with 4 processes. The explorer has been stable for the last 3 days with no crash so i hope this will be the end of this problem but i can add more processes if needed.

- i requested an increase of HD in one of the explorer servers as i need to run 2 nodes at the same time in the near future. One will serve what it is currently serving while the other will have elasticsearch plugin that will allow to bring lot of new features to the explorer. While everything could be done with 1 node with ES loaded it will be better if we keep current funcionality working so there is going to be a period of time while both nodes will be used.

- fixed chart data with new core changes, market charts now look as they should: http://bitshares-explorer.io/#/markets/CNY/BTS without any filtering client side. https://github.com/oxarbitrage/bitshares-python-api-backend/commit/34d87ebe5b4daa9418e9c0d6e86bae53adf9df85

- added referral information to account page(http://bitshares-explorer.io:9009/#/accounts/fav). Information includes by now count of referrals and account names. More info will be added. This is going after https://github.com/oxarbitrage/bitshares-explorer/issues/6

Offline oxarbitrage

Release, we did.

https://github.com/bitshares/bitshares-core/releases

After a lot of testing in our 3 branches(develop - testnet - master) we tagged a new release. This is the work of contributors on the last 3 months featuring lot of great work by @pc. thank you for all the work done in this time.

A special mention in the release are some last minute changes like the default config code: https://github.com/bitshares/bitshares-core/pull/422 and the asset creation fee issue https://github.com/bitshares/bitshares-core/issues/433 - https://github.com/bitshares/bitshares-core/issues/429 . For this last issue we replicated the problem in the testnet then a patch in the form of softfork was added by @abit and finally @pc made a definitive solution that was added to the release at the last minute.

Another last minute addition was a new plugin @pc created while fixing 429-433 https://github.com/bitshares/bitshares-core/pull/437
this is a snapshot plugin that allow the user to create a full json formatted file that includes all the indexes from the entire blockchain at a selected block or date.

Many other last minute changes were added, check the release page for the details on whats included, the amount of work testing to make candidate, pre release and release was very significant but it is finally available.

The following issues are after release or non related to it:

- https://github.com/bitshares/bitshares-core/issues/431 - closed.
- https://github.com/bitshares/bitshares-core/issues/439 - closed - fix here: https://github.com/bitshares/bitshares-core/pull/440

- https://github.com/bitshares/bitshares-core/pull/444 - version1 of elasticsearch plugin and documentation https://github.com/oxarbitrage/worker-proposals/blob/master/elasticsearch-plugin.md

This is a very needed plugin that will allow to close many issues related to the API and to run full nodes without all the RAM currently needed. V1 is a fully working version but it needs a lot of fine tuning before a merge. I already got the needed feedback to do this from the other bitshares devs and now the fine tuning is in process. Most of my work will be here in the next few weeks.

- Explorer - with the release and the elasticsearch plugin i was very focused in the core and left explorer abandoned a bit. Still some small progress was made in the assets page: http://bitshares-explorer.io/#/assets, in the account page: http://bitshares-explorer.io/#/accounts/1.2.121 and in the market page: http://bitshares-explorer.io/#/markets/CNY/BTS
Ill try to revamp it this next weeks now that the release passed and the heavy work in the elasticsearch plugin too specially starting by adding referral stuff to the explorer https://github.com/oxarbitrage/bitshares-explorer/issues/6 ,  do some of the last requested changes at the assets page https://github.com/oxarbitrage/bitshares-explorer/issues/2 and https://github.com/oxarbitrage/bitshares-explorer/issues/1

Offline oxarbitrage

>:(alfredo Garcia
nesecito ayuda mi hermano conquien puedo hablar para arreglar algo en mi cuenta de bitsheres , sucede que traferi desde mi cuenta de coinbase , $523.00 dollares y lo tenia en mi cuenta y sucede que hacen dos dias le di a a lago que sellama withdrawal y  derepende mi dinero se de saparecio y ahora aparece en una cuenta que sellama openledger-wallet  pero quiero tranferir a mi cuenta y no me deja ahora cadave que quiero tranferir no puede por que medice que nesecito una authorisacion no se de quien y nesecito sacar mi dinero no me gusta ested systema de verda que no . porfavor te agradeseria su conce de alguien que me pueda ayudaR PORFAVOR , ME PUEDE escribir a mi correo esv-ministry@hotmail.com


parece ser algún problema específico con openledger. proba en el telegram de openledger en español si no sabes nada de ingles: https://telegram.me/OpenLedgerESP
cualquier cosa enviame un mensaje privado ya que este no es el lugar para estas consultas en ningún idioma.

//////////// guy having an issue with a withdraw using openledger, sent him to openledger support telegram in spanish. out of topic for the thread.

Offline vanterpool7

 >:(alfredo Garcia
nesecito ayuda mi hermano conquien puedo hablar para arreglar algo en mi cuenta de bitsheres , sucede que traferi desde mi cuenta de coinbase , $523.00 dollares y lo tenia en mi cuenta y sucede que hacen dos dias le di a a lago que sellama withdrawal y  derepende mi dinero se de saparecio y ahora aparece en una cuenta que sellama openledger-wallet  pero quiero tranferir a mi cuenta y no me deja ahora cadave que quiero tranferir no puede por que medice que nesecito una authorisacion no se de quien y nesecito sacar mi dinero no me gusta ested systema de verda que no . porfavor te agradeseria su conce de alguien que me pueda ayudaR PORFAVOR , ME PUEDE escribir a mi correo esv-ministry@hotmail.com