1 PTS per Typo-Fix Pull Request Submitted to invictus.io

Started by bytemaster, January 22, 2014, 07:43:27 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

HackFisher

Quote from: bytemaster on January 22, 2014, 07:26:17 PM
Quote from: xeroc on January 22, 2014, 08:55:31 AM
Bazinga - found one :-)
https://github.com/super3/invictus.io/pull/46

PTS: PdbNaeWMsB2JXWWURwxVNA2jdZEmpuUaME

EDIT: you might want to add the project to http://tip4commit.com/projects and donate a few mBTC - same result .. less effort

Interesting... once Arlen starts full time we may use this.

Cool...
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

mint chocolate chip

Lends Dollars into existance on collateral. Repays Loan to take dollars out of existance. ---------> existence (two mistakes here http://invictus.io/bitsharesx.php)

---------------------
on http://invictus.io/bitshares-pts.php ...

A BitShare is a stake in what we like to call a decentralized autonomous company and Invictus has many innovative blockchains on our roadmap. ----> roadmap should be road map.

ProtoShare" is a registered trademark of Site9, Inc. for its prototyping and mockup software product, ProtoShare. ---> mockup should be mock-up

The pool combines the power of all connected nodes and pays you proportionally for your sharerate. ----> sharerate should be share rate

Pay Per Share http://ypool.net - 6% fee, multicoin pool, ... ----> multicoin is not a word (Multicoin is a coin i believe), multiple coin or maybe dash between the two words

Blockchain explorer - View transactions by pts adress ----> adress should be address + capitalize pts
[url="http://bitsharesblog.com/"]http://bitsharesblog.com/[/url]

mint chocolate chip

Calls Loan
when collateral
looses value.

http://invictus.io/bitsharesx.php under foreclosure sign
looses should be loses
[url="http://bitsharesblog.com/"]http://bitsharesblog.com/[/url]

xeroc

Quote from: gigawatt on January 22, 2014, 09:59:31 PM
edit2: You guys should totally add a favicon.ico file!  The tab looks so bland without it.
+1

Nice work gigawatt

gigawatt

I've submitted a few typo and standardization suggestions: https://github.com/super3/invictus.io/pull/50


  • bitshares-pts.php - It kept alternating between "ProtoShares", "Protoshares" and "protoshares" where the rest of the site just used "Protoshares".  Fixed capitalization of "Bitshares". Added missing period
  • bitshares-ags.php - Typo: "donators" -> "donors".  Standardized capitalization of "Bitshares".
  • funding-philosophy.php - I don't think "minable" is a word and "mineable" look odd, so I changed "is minable" to "can be mined".  Typo: too many "n"s in "technology".  Fixed capitalization of "Website" to be consistent.
  • keyhotee.php - "unstability" isn't a word, but "instability" is.


Suggestions: make a guideline of what capitalization to use for "Protoshares".  Also, from an HTML perspective, I saw "<br>", "<br/>", and "<br />" all used in the code.

My PTS address is Pstkk1gZCxc4GEwS1eBAykYwVmcubU1P8L
Send whatever you think is appropriate.




edit: Site footer had an HTML typo.  It used "&ampl;" instead of "&amp;" in a URL.  Also, for consistency, if you're going to spell out "Incorporated" in the address, you can probably afford to spell out "Drive" as well.  ;D




edit2: You guys should totally add a favicon.ico file!  The tab looks so bland without it.
BTC: 1E2egHUcLDAmcxcqZqpL18TPLx9Xj1akcV
PTS: Pstkk1gZCxc4GEwS1eBAykYwVmcubU1P8L

graffenwalder

Not. really a bug or typo, but it should be pointed out that donations should be made from owned wallets. (Not bitstamp, gox cryptsy.....) Pvw5u6QQBoVt52i5CuDJnWc7EHyjQc4ziU

mint chocolate chip

From a website standpoint, the description meta tag should probably have something between the ""

<meta name="description" content="">


This is like this on all pages on the site
[url="http://bitsharesblog.com/"]http://bitsharesblog.com/[/url]

mint chocolate chip

Found another...

http://invictus.io/bitshares.php

-------------period missing in the top one or remove period from second one-------------
Many alt-coins with the same unprofitable business model
Many alt-companies with creative profit models.
--------------------------------------------
[url="http://bitsharesblog.com/"]http://bitsharesblog.com/[/url]

mint chocolate chip

when showing this site to my wife last night, I thought I stumbled upon one such typo.

On http://invictus.io/bitsharesx.php in the section comparing a bank to bitsharesX:
Lends dollars.
Earns revenue.
Calls loan.
Repay loan.

I found it awkward that Repay is not Repays to go with the other ones. BitsharesX repays loan sounds better than BitsharesX repay loan.

[url="http://bitsharesblog.com/"]http://bitsharesblog.com/[/url]

bytemaster

Quote from: xeroc on January 22, 2014, 08:55:31 AM
Bazinga - found one :-)
https://github.com/super3/invictus.io/pull/46

PTS: PdbNaeWMsB2JXWWURwxVNA2jdZEmpuUaME

EDIT: you might want to add the project to http://tip4commit.com/projects and donate a few mBTC - same result .. less effort

Interesting... once Arlen starts full time we may use this.
For the latest updates checkout my blog: [url="http://bytemaster.bitshares.org"]http://bytemaster.bitshares.org[/url]
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

xeroc

Bazinga - found one :-)
https://github.com/super3/invictus.io/pull/46

PTS: PdbNaeWMsB2JXWWURwxVNA2jdZEmpuUaME

EDIT: you might want to add the project to http://tip4commit.com/projects and donate a few mBTC - same result .. less effort

bytemaster

Find a typo, a glitch, or some other cosmetic bug with invictus.io, submit a pull request and get paid.  If you don't know how to use github, then post in this thread and split the bounty with someone who can manage github.

https://github.com/super3/invictus.io
For the latest updates checkout my blog: [url="http://bytemaster.bitshares.org"]http://bytemaster.bitshares.org[/url]
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.