Author [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] Topic: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io  (Read 3743 times)

0 Members and 1 Guest are viewing this topic.

Offline bytemaster

1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« on: January 22, 2014, 07:43:27 AM »

Find a typo, a glitch, or some other cosmetic bug with invictus.io, submit a pull request and get paid.  If you don't know how to use github, then post in this thread and split the bounty with someone who can manage github.

https://github.com/super3/invictus.io
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12339
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BTS: xeroc
  • GitHub: xeroc
Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #1 on: January 22, 2014, 08:55:31 AM »
Bazinga - found one :-)
https://github.com/super3/invictus.io/pull/46

PTS: PdbNaeWMsB2JXWWURwxVNA2jdZEmpuUaME

EDIT: you might want to add the project to http://tip4commit.com/projects and donate a few mBTC - same result .. less effort
« Last Edit: January 22, 2014, 08:57:26 AM by xeroc »
Give BitShares a try! Use the http://testnet.bitshares.eu provided by http://bitshares.eu powered by ChainSquad GmbH

Offline bytemaster

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #2 on: January 22, 2014, 07:26:17 PM »
Bazinga - found one :-)
https://github.com/super3/invictus.io/pull/46

PTS: PdbNaeWMsB2JXWWURwxVNA2jdZEmpuUaME

EDIT: you might want to add the project to http://tip4commit.com/projects and donate a few mBTC - same result .. less effort

Interesting... once Arlen starts full time we may use this.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline mint chocolate chip

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #3 on: January 22, 2014, 07:45:45 PM »
when showing this site to my wife last night, I thought I stumbled upon one such typo.

On http://invictus.io/bitsharesx.php in the section comparing a bank to bitsharesX:
Lends dollars.
Earns revenue.
Calls loan.
Repay loan.

I found it awkward that Repay is not Repays to go with the other ones. BitsharesX repays loan sounds better than BitsharesX repay loan.


Offline mint chocolate chip

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #4 on: January 22, 2014, 07:56:00 PM »
Found another...

http://invictus.io/bitshares.php

-------------period missing in the top one or remove period from second one-------------
Many alt-coins with the same unprofitable business model
Many alt-companies with creative profit models.
--------------------------------------------

Offline mint chocolate chip

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #5 on: January 22, 2014, 08:00:44 PM »
From a website standpoint, the description meta tag should probably have something between the ""

<meta name="description" content="">


This is like this on all pages on the site

Offline graffenwalder

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #6 on: January 22, 2014, 09:31:22 PM »
Not. really a bug or typo, but it should be pointed out that donations should be made from owned wallets. (Not bitstamp, gox cryptsy.....) Pvw5u6QQBoVt52i5CuDJnWc7EHyjQc4ziU

Offline gigawatt

  • Jr. Member
  • **
  • Posts: 27
    • View Profile
Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #7 on: January 22, 2014, 09:59:31 PM »
I've submitted a few typo and standardization suggestions: https://github.com/super3/invictus.io/pull/50

  • bitshares-pts.php - It kept alternating between "ProtoShares", "Protoshares" and "protoshares" where the rest of the site just used "Protoshares".  Fixed capitalization of "Bitshares". Added missing period
  • bitshares-ags.php - Typo: "donators" -> "donors".  Standardized capitalization of "Bitshares".
  • funding-philosophy.php - I don't think "minable" is a word and "mineable" look odd, so I changed "is minable" to "can be mined".  Typo: too many "n"s in "technology".  Fixed capitalization of "Website" to be consistent.
  • keyhotee.php - "unstability" isn't a word, but "instability" is.


Suggestions: make a guideline of what capitalization to use for "Protoshares".  Also, from an HTML perspective, I saw "<br>", "<br/>", and "<br />" all used in the code.

My PTS address is Pstkk1gZCxc4GEwS1eBAykYwVmcubU1P8L
Send whatever you think is appropriate.



edit: Site footer had an HTML typo.  It used "&ampl;" instead of "&amp;" in a URL.  Also, for consistency, if you're going to spell out "Incorporated" in the address, you can probably afford to spell out "Drive" as well.  ;D



edit2: You guys should totally add a favicon.ico file!  The tab looks so bland without it.
« Last Edit: January 22, 2014, 10:39:52 PM by gigawatt »
BTC: 1E2egHUcLDAmcxcqZqpL18TPLx9Xj1akcV
PTS: Pstkk1gZCxc4GEwS1eBAykYwVmcubU1P8L

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12339
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BTS: xeroc
  • GitHub: xeroc
Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #8 on: January 23, 2014, 07:40:39 AM »
edit2: You guys should totally add a favicon.ico file!  The tab looks so bland without it.
+1

Nice work gigawatt
Give BitShares a try! Use the http://testnet.bitshares.eu provided by http://bitshares.eu powered by ChainSquad GmbH

Offline mint chocolate chip

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #9 on: January 23, 2014, 08:16:16 AM »
Calls Loan
when collateral
looses value.

http://invictus.io/bitsharesx.php under foreclosure sign
looses should be loses

Offline mint chocolate chip

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #10 on: January 23, 2014, 08:30:04 AM »
Lends Dollars into existance on collateral. Repays Loan to take dollars out of existance. ---------> existence (two mistakes here http://invictus.io/bitsharesx.php)

---------------------
on http://invictus.io/bitshares-pts.php ...

A BitShare is a stake in what we like to call a decentralized autonomous company and Invictus has many innovative blockchains on our roadmap. ----> roadmap should be road map.

ProtoShare" is a registered trademark of Site9, Inc. for its prototyping and mockup software product, ProtoShare. ---> mockup should be mock-up

The pool combines the power of all connected nodes and pays you proportionally for your sharerate. ----> sharerate should be share rate

Pay Per Share http://ypool.net - 6% fee, multicoin pool, ... ----> multicoin is not a word (Multicoin is a coin i believe), multiple coin or maybe dash between the two words

Blockchain explorer - View transactions by pts adress ----> adress should be address + capitalize pts

Offline HackFisher

  • Hero Member
  • *****
  • Posts: 883
    • View Profile
Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #11 on: January 23, 2014, 08:30:48 AM »
Bazinga - found one :-)
https://github.com/super3/invictus.io/pull/46

PTS: PdbNaeWMsB2JXWWURwxVNA2jdZEmpuUaME

EDIT: you might want to add the project to http://tip4commit.com/projects and donate a few mBTC - same result .. less effort

Interesting... once Arlen starts full time we may use this.

Cool...
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline jernau

  • Full Member
  • ***
  • Posts: 78
    • View Profile
Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #12 on: January 23, 2014, 08:41:12 AM »
Find a typo, a glitch, or some other cosmetic bug with invictus.io, submit a pull request and get paid.  If you don't know how to use github, then post in this thread and split the bounty with someone who can manage github.

https://github.com/super3/invictus.io

Was just wondering if I'd get any reward. As far as I know, I was one of the first to start submitting pull requests - 3 of them - (username themanifold on github) for invictus.io.. :)

Address: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW
PTS: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW

Offline bytemaster

Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #13 on: January 23, 2014, 01:38:33 PM »
Find a typo, a glitch, or some other cosmetic bug with invictus.io, submit a pull request and get paid.  If you don't know how to use github, then post in this thread and split the bounty with someone who can manage github.

https://github.com/super3/invictus.io

Was just wondering if I'd get any reward. As far as I know, I was one of the first to start submitting pull requests - 3 of them - (username themanifold on github) for invictus.io.. :)

Address: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW

I am looking for your name in the commit log as it appears Super3 closed your pull request.   Looking through the commit history I do not see your requests... very curious.

If we pulled in your requests then I will make sure you get paid.      Ping me back after Miami Conference and I will get to the bottom of these missing commits.

For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline gigawatt

  • Jr. Member
  • **
  • Posts: 27
    • View Profile
Re: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io
« Reply #14 on: January 23, 2014, 02:10:58 PM »
Sweet!  Looks like my pull request got merged.  :D
https://github.com/super3/invictus.io/pull/50
BTC: 1E2egHUcLDAmcxcqZqpL18TPLx9Xj1akcV
PTS: Pstkk1gZCxc4GEwS1eBAykYwVmcubU1P8L

 

Google+