Thanks, here's my PTS address: Ps8KJ5mJEszeYAhuGhdMPH4EbSiVFqNTFQ
FYI, the things I had to fix since last time:
- some cmake build flags were not completely correct, seems like they were introduced when your guys did the work for the static linux build. No biggie, and I imagine once you're gonna have the Jenkins CI running, this won't happen again
- in fc, you should never
forward-declare the std::hash for custom types (ie: fc::sha256 as in https://github.com/InvictusInnovations/fc/pull/13/files
but also all the other types, fc::ip::endpoint, etc...). Forward-declaring it, even for only one type, will shadow the declaration from the std lib and all the std::hash template specializations in fc will fail to compile. Not sure if it's a bug in clang or whether clang is stricter than GCC, but that's how it is...
Hope this helps!