Market Fees not updating in RC1?

FearlessAsian · December 24, 2018, 02:33:18 AM

Quote from: startail on December 23, 2018, 06:44:02 PM
Yes, these two issues have been fixed recently. The misspelling was merged a few days ago and the market fee will be in the next release.
https://github.com/bitshares/bitshares-ui/issues/2375

Done. Locked for further discussion and will be moved to Graveyard in 3 days.

Chee®s

startail · December 23, 2018, 06:44:02 PM

Yes, these two issues have been fixed recently. The misspelling was merged a few days ago and the market fee will be in the next release.
https://github.com/bitshares/bitshares-ui/issues/2375

FearlessAsian · December 23, 2018, 06:05:31 PM

Quote from: iamredbar on December 23, 2018, 05:49:13 PM
Quote from: Digital Lucifer on December 23, 2018, 05:41:51 PM
What about the missing fee calculation ?

I have not done anything with that. Looks like it's been brought up a couple times: https://github.com/bitshares/bitshares-ui/issues/2375

Thanks, dev from my team is looking into it now.

Chee®s

iamredbar · December 23, 2018, 05:49:13 PM

Quote from: Digital Lucifer on December 23, 2018, 05:41:51 PM
What about the missing fee calculation ?

I have not done anything with that. Looks like it's been brought up a couple times: https://github.com/bitshares/bitshares-ui/issues/2375

FearlessAsian · December 23, 2018, 05:41:51 PM

Quote from: iamredbar on December 23, 2018, 03:46:56 PM
I fixed the spelling, it is already merged with the development branch.

What about the missing fee calculation ?

iamredbar · December 23, 2018, 03:46:56 PM

I fixed the spelling, it is already merged with the development branch.

FearlessAsian · December 23, 2018, 03:20:30 PM

Quote from: startail on December 23, 2018, 02:58:42 PM
These have been reported on the GitHub repo, and will be taken care of.

Please if possible, when issue is closed inform us here. I'll then lock and move to graveyard.

Quote from: NeoReel on December 04, 2018, 05:47:34 PM
Hello,

I'm using the Bitshares UI version 181121-rc1 and I'm wondering why the market fees are not updating as I type in values when placing an order.
For instance, selling BTS in the BTS/BitUSD market should have 0.1% market fee, but it remains 0.

Can anyone let me know if the Market fee is taken even though not displayed?

Also, please fix this typo in the "Deposit USD" button:

Thanks,

Thanks for report of the issue! :)

Chee®s

startail · December 23, 2018, 02:58:42 PM

These have been reported on the GitHub repo, and will be taken care of.

NeoReel · December 04, 2018, 05:47:34 PM

Hello,

I'm using the Bitshares UI version 181121-rc1 and I'm wondering why the market fees are not updating as I type in values when placing an order.
For instance, selling BTS in the BTS/BitUSD market should have 0.1% market fee, but it remains 0.

Can anyone let me know if the Market fee is taken even though not displayed?

Also, please fix this typo in the "Deposit USD" button:

Thanks,