Author [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] Topic: emfrias是兼职人员吗.按他的代码提交进度10天半月WIN32 的编译能通过不..  (Read 657 times)

0 Members and 1 Guest are viewing this topic.

Offline cdryan

  • Sr. Member
  • ****
  • Posts: 357
    • View Profile

emfrias是兼职人员吗.按他的代码提交进度10天半月WIN32 的编译能通过不..
 void create_asset_operation::evaluate( transaction_evaluation_state& eval_state )
     { try {
 -      if( not is_power_of_ten( this->precision ) )
 +      if( !is_power_of_ten( this->precision ) )
           FC_CAPTURE_AND_THROW( invalid_precision, (precision) );
 
 -      if( not eval_state._current_state->is_valid_symbol_name( this->symbol ) )
 +      if( !eval_state._current_state->is_valid_symbol_name( this->symbol ) )
           FC_CAPTURE_AND_THROW( invalid_asset_symbol, (symbol) );
 
        if( this->maximum_share_supply <= 0 )
 @@ -27,10 +27,10 @@ namespace bts { namespace blockchain {
        if( issuer_account_id != asset_record::market_issued_asset )
        {
           auto issuer_account_record = eval_state._current_state->get_account_record( this->issuer_account_id );
 -         if( not issuer_account_record )
 +         if( !issuer_account_record )
              FC_CAPTURE_AND_THROW( unknown_account_id, (issuer_account_id) );
 
 -         if( not eval_state.check_signature( issuer_account_record->active_address() ) )
 +         if( !eval_state.check_signature( issuer_account_record->active_address() ) )
              FC_CAPTURE_AND_THROW( missing_signature, (issuer_account_record) );
        }
 
 @@ -60,25 +60,25 @@ namespace bts { namespace blockchain {
     void update_asset_operation::evaluate( transaction_evaluation_state& eval_state )
     { try {
        auto current_asset_record = eval_state._current_state->get_asset_record( this->asset_id );
 -      if( not current_asset_record )
 +      if( !current_asset_record )
           FC_CAPTURE_AND_THROW( unknown_asset_id, (asset_id) );
 
        auto issuer_account_record = eval_state._current_state->get_account_record( current_asset_record->issuer_account_id );
 
 -      if( not issuer_account_record )
 +      if( !issuer_account_record )
           FC_CAPTURE_AND_THROW( unknown_account_id, (current_asset_record->issuer_account_id) );
 
 -      if( not eval_state.check_signature(issuer_account_record->active_address()) )
 +      if( !eval_state.check_signature(issuer_account_record->active_address()) )
            FC_CAPTURE_AND_THROW( missing_signature, (issuer_account_record->active_key()) );
 
        if( this->issuer_account_id != current_asset_record->issuer_account_id )
        {
            auto new_issuer_account_record = eval_state._current_state->get_account_record( this->issuer_account_id );
 
 -          if( not new_issuer_account_record )
 +          if( !new_issuer_account_record )
                FC_CAPTURE_AND_THROW( unknown_account_id, (issuer_account_id) );
 
 -          if( not eval_state.check_signature(new_issuer_account_record->active_address()) )
 +          if( !eval_state.check_signature(new_issuer_account_record->active_address()) )
                FC_CAPTURE_AND_THROW( missing_signature, (new_issuer_account_record->active_key()) );
        }
 
 @@ -100,19 +100,19 @@ namespace bts { namespace blockchain {
           FC_CAPTURE_AND_THROW( negative_issue, (amount) );
 
        auto current_asset_record = eval_state._current_state->get_asset_record( this->amount.asset_id );
 -      if( not current_asset_record )
 +      if( !current_asset_record )
           FC_CAPTURE_AND_THROW( unknown_asset_id, (amount.asset_id) );
 
        auto issuer_account_record = eval_state._current_state->get_account_record( current_asset_record->issuer_account_id );
 -      if( not issuer_account_record )
 +      if( !issuer_account_record )
           FC_CAPTURE_AND_THROW( unknown_account_id, (current_asset_record->issuer_account_id) );
 
 -      if( not eval_state.check_signature( issuer_account_record->active_address() ) )
 +      if( !eval_state.check_signature( issuer_account_record->active_address() ) )
        {
           FC_CAPTURE_AND_THROW( missing_signature, (issuer_account_record->active_key()) );
        }
 
 -      if( not current_asset_record->can_issue( this->amount ) )
 +      if( !current_asset_record->can_issue( this->amount ) )
        {
           FC_CAPTURE_AND_THROW( over_issue, (amount)(current_asset_record) );
        }

今天修改就是,not  改称! :'(..看来主要矛盾还是人手...

Offline crazybit

  • Sr. Member
  • ****
  • Posts: 416
    • View Profile
win32一直都能编译通过。

Offline Amazon

  • Hero Member
  • *****
  • Posts: 831
    • View Profile
    • Bitshares Forum
他是全职阿,很猛很猛的,不能就靠一段代码判断
Forum Donation: PforumPLfVQXTi4QpQqKwoChXHkoHcxGuA

Offline sudo

  • Hero Member
  • *****
  • Posts: 2244
    • View Profile
  • BTS: ags
The C keyword 'not' is not friendly on VC++ but we still want to use
 + *  it for readability, so we will have the pre-processor convert it to the
 + *  more traditional form.  The goal here is to make the understanding of
 + *  the validation logic as english-like as possible.

bm说的

https://github.com/BitShares/bitshares_toolkit/commit/c426d21d44e5fe54ac6cdbf4682776cacd7fd6b1

Offline cdryan

  • Sr. Member
  • ****
  • Posts: 357
    • View Profile
他是全职阿,很猛很猛的,不能就靠一段代码判断

 ::) 真没看出来,因为BUG还那么多.WIN 的版本钱包测试也没释放...应该有很多活.

Offline muse-umum

  • Hero Member
  • *****
  • Posts: 717
  • BitShares everything
    • View Profile
他就是Eric吧?

我记得某次月报里说过他是网络编程方面的专家,Dan Notestein把他挖来的,当时给予了他非常高的评价。toolkit的p2p网络架构就是他设计的。toast之前说过他加入bitshares开发团队之后才知道他离BM和Eric的差距是有多么的大。

其他的就不清楚了,他貌似很低调的,之前bitshares官网里团队介绍的页面上,就他是没有头像的,现在干脆不出现在上面了。
« Last Edit: June 10, 2014, 04:11:41 PM by heyD »

Offline cdryan

  • Sr. Member
  • ****
  • Posts: 357
    • View Profile
他就是Eric吧?

我记得某次月报里说过他是网络编程方面的专家,Dan Notestein把他挖来的,当时给予了他非常高的评价。toolkit的p2p网络架构就是他设计的。toast之前说过他加入bitshares开发团队之后才知道他离BM和Eric的差距是有多么的大。

其他的就不清楚了,他貌似很低调的,之前bitshares官网里团队介绍的页面上,就他是没有头像的,现在干脆不出现在上面了。

希望如此,很久没看代码提交了,就看了最近几天.感觉BM是顶梁柱.

Offline gyhy

  • Hero Member
  • *****
  • Posts: 851
    • View Profile

 

Google+