Author [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] Topic: Bids not executing against shorts  (Read 858 times)

0 Members and 1 Guest are viewing this topic.

Offline theoretical

Bids not executing against shorts
« on: September 08, 2014, 06:36:51 PM »


I made a short at the top of the book, 26.75 which was above median and average price.  The short showed up in the GUI order list confirming it is OK price-feed-wise.

Then I made a bid for the same quantity at price of 26.7501.  The bid did not execute.  Why?
BTS- theoretical / PTS- PZxpdC8RqWsdU3pVJeobZY7JFKVPfNpy5z / BTC- 1NfGejohzoVGffAD1CnCRgo9vApjCU2viY / the delegate formerly known as drltc / Nothing said on these forums is intended to be legally binding / All opinions are my own unless otherwise noted / Take action due to my posts at your own risk

Offline bytemaster

Re: Bids not executing against shorts
« Reply #1 on: September 08, 2014, 06:41:43 PM »

I made a short at the top of the book, 26.75 which was above median and average price.  The short showed up in the GUI order list confirming it is OK price-feed-wise.

Then I made a bid for the same quantity at price of 26.7501.  The bid did not execute.  Why?

Known issue, grumble grumble.... fix has already been implemented.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline tonyk

  • Hero Member
  • *****
  • Posts: 3309
    • View Profile
Re: Bids not executing against shorts
« Reply #2 on: September 08, 2014, 06:43:46 PM »
Code: [Select]
>> blockchain_market_order_book BTC BTSX

                  BIDS (* Short Order)                                       |                                   ASKS                                 
TOTAL                     QUANTITY                                     PRICE | PRICE                                        QUANTITY                     TOTAL   COLLATERAL
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.99999999 BTC            12,775.99990 BTSX               0.000078271760 BTC*| 0.000078263933 BTC                  12,777.27760 BTSX            0.99999999 BTC
0.99999999 BTC            12,776.00000 BTSX               0.000078271760 BTC*| 0.000080000000 BTC                  12,500.00000 BTSX            1.00000000 BTC
0.00999999 BTC            135.00000 BTSX                  0.000074074074 BTC*| 0.000083333333 BTC                   4,318.56954 BTSX            0.35988079 BTC

Is this known too?
Lack of arbitrage is the problem, isn't it. And this 'should' solves it.

Offline GaltReport

Re: Bids not executing against shorts
« Reply #3 on: September 08, 2014, 06:45:43 PM »

I made a short at the top of the book, 26.75 which was above median and average price.  The short showed up in the GUI order list confirming it is OK price-feed-wise.

Then I made a bid for the same quantity at price of 26.7501.  The bid did not execute.  Why?

Same here.  I bid the EXACT price of my short when it was at the top of the sell orders and it sat their more than 5 10 minutes.  This is not a different price with a different ending nonvisible decimal point.  The prices were the same.
« Last Edit: September 08, 2014, 06:47:39 PM by GaltReport »

Offline bytemaster

Re: Bids not executing against shorts
« Reply #4 on: September 08, 2014, 06:45:51 PM »
Code: [Select]
>> blockchain_market_order_book BTC BTSX

                  BIDS (* Short Order)                                       |                                   ASKS                                 
TOTAL                     QUANTITY                                     PRICE | PRICE                                        QUANTITY                     TOTAL   COLLATERAL
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.99999999 BTC            12,775.99990 BTSX               0.000078271760 BTC*| 0.000078263933 BTC                  12,777.27760 BTSX            0.99999999 BTC
0.99999999 BTC            12,776.00000 BTSX               0.000078271760 BTC*| 0.000080000000 BTC                  12,500.00000 BTSX            1.00000000 BTC
0.00999999 BTC            135.00000 BTSX                  0.000074074074 BTC*| 0.000083333333 BTC                   4,318.56954 BTSX            0.35988079 BTC

Is this known too?

Same issue.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline theoretical

Re: Bids not executing against shorts
« Reply #5 on: September 08, 2014, 06:50:45 PM »

I assume is fixed by this commit:  https://github.com/BitShares/bitshares_toolkit/commit/eec87d8fa136fecea74c68574e4062ab63559846

That inequality flipping from <= to > makes me nervous...
BTS- theoretical / PTS- PZxpdC8RqWsdU3pVJeobZY7JFKVPfNpy5z / BTC- 1NfGejohzoVGffAD1CnCRgo9vApjCU2viY / the delegate formerly known as drltc / Nothing said on these forums is intended to be legally binding / All opinions are my own unless otherwise noted / Take action due to my posts at your own risk

Offline toast

Re: Bids not executing against shorts
« Reply #6 on: September 08, 2014, 06:59:20 PM »
Do not use this post as information for making any important decisions. The only agreements I ever make are informal and non-binding. Take the same precautions as when dealing with a compromised account, scammer, sockpuppet, etc.

Offline GaltReport

Re: Bids not executing against shorts
« Reply #7 on: September 08, 2014, 07:12:47 PM »

Offline tonyk

  • Hero Member
  • *****
  • Posts: 3309
    • View Profile
Re: Bids not executing against shorts
« Reply #8 on: September 08, 2014, 10:19:21 PM »
There is no way, this is the best way to place your orders...  ;)

As fun as this exercise was and as funny as toast's post is, I have to ask:

"Is 0.4.12-RC2 coming soon?"
« Last Edit: September 08, 2014, 10:28:16 PM by tonyk »
Lack of arbitrage is the problem, isn't it. And this 'should' solves it.

Offline jsidhu

  • Hero Member
  • *****
  • Posts: 1337
    • View Profile
Re: Bids not executing against shorts
« Reply #9 on: September 08, 2014, 11:32:25 PM »

I assume is fixed by this commit:  https://github.com/BitShares/bitshares_toolkit/commit/eec87d8fa136fecea74c68574e4062ab63559846

That inequality flipping from <= to > makes me nervous...

I think at the very least update the block comment... thats the hard part of having meaningful comments that change as logic changes..  I like to name my variables as descriptive as possible.

Looking at the code... the primary logic comparison (mtrx.bid_price > max_short_bid) that the current bid price is greater than 1h average or median is true regardless of what max_short_bid is because if the secondary comparison is true (mtrx.ask_price > max_short_bid) than the primary is true by extension of the check to ensure bid_price > ask_price.

Thus we have reverted the logic from if mtrx.ask_price <= max_short_bid then don't execute this order,  to the opposite of mtrx.ask_price > max_short_bid then don't execute this order.

So isn't this code saying now, for a short order, that if the bid&ask are > than the median/average then don't execute this order? Is that the intended behaviour?
« Last Edit: September 09, 2014, 12:32:13 AM by jsidhu »
Hired by blockchain | Developer
delegate: dev.sidhujag

Offline emski

  • Hero Member
  • *****
  • Posts: 1283
    • View Profile
    • http://lnkd.in/nPbhxG
Re: Bids not executing against shorts
« Reply #10 on: September 09, 2014, 05:41:33 AM »
There is no way, this is the best way to place your orders...  ;)

As fun as this exercise was and as funny as toast's post is, I have to ask:

"Is 0.4.12-RC2 coming soon?"

0.4.12 is already out. RC means release candidate and 0.4.12-RC1 precedes 0.4.12. The next version should be 0.4.13-RC1 (or 0.4.14-RC1 due to superstitions). -RC suffix might be omitted  if developers feel there is no need for testing.

And for the question "where is the next version?" - It should be out by Tuesday (assuming interest is scheduled for Wednesday).

Offline tonyk

  • Hero Member
  • *****
  • Posts: 3309
    • View Profile
Re: Bids not executing against shorts
« Reply #11 on: September 09, 2014, 06:05:51 AM »
There is no way, this is the best way to place your orders...  ;)

As fun as this exercise was and as funny as toast's post is, I have to ask:

"Is 0.4.12-RC2 coming soon?"

0.4.12 is already out. RC means release candidate and 0.4.12-RC1 precedes 0.4.12. The next version should be 0.4.13-RC1 (or 0.4.14-RC1 due to superstitions). -RC suffix might be omitted  if developers feel there is no need for testing.

And for the question "where is the next version?" - It should be out by Tuesday (assuming interest is scheduled for Wednesday).
Thanks for the lesson. Will keep it mind the next time I ask.
So, to the point, you think then next version  is coming Today (Tuesday) ?
Lack of arbitrage is the problem, isn't it. And this 'should' solves it.

Offline emski

  • Hero Member
  • *****
  • Posts: 1283
    • View Profile
    • http://lnkd.in/nPbhxG
Re: Bids not executing against shorts
« Reply #12 on: September 09, 2014, 06:28:44 AM »
I'm not that sure anymore. The interest can be included in any future version. There is no need to upgrade now for it to work starting Wednesday. So my new answer is: Ask Bytemaster.

Offline tonyk

  • Hero Member
  • *****
  • Posts: 3309
    • View Profile
Re: Bids not executing against shorts
« Reply #13 on: September 09, 2014, 06:35:54 AM »
I'm not that sure anymore. The interest can be included in any future version. There is no need to upgrade now for it to work starting Wednesday. So my new answer is: Ask Bytemaster.

Ask Bytemaster
He is sick/ill, as far as I know... and my losses/winning are swinging at 1/4 -1/1 my monthly salary every 2-3 hours, because I can not place/execute my orders...
« Last Edit: September 09, 2014, 06:39:53 AM by tonyk »
Lack of arbitrage is the problem, isn't it. And this 'should' solves it.

Offline emski

  • Hero Member
  • *****
  • Posts: 1283
    • View Profile
    • http://lnkd.in/nPbhxG
Re: Bids not executing against shorts
« Reply #14 on: September 09, 2014, 06:52:38 AM »
I'm not that sure anymore. The interest can be included in any future version. There is no need to upgrade now for it to work starting Wednesday. So my new answer is: Ask Bytemaster.

Ask Bytemaster
He is sick/ill, as far as I know... and my losses/winning are swinging at 1/4 -1/1 my monthly salary every 2-3 hours, because I can not place/execute my orders...

You must be having a lot of fun then (:. This must be pretty exciting ...

 

Google+