BitShares Forum

Main => Stakeholder Proposals => Topic started by: xeroc on February 09, 2015, 03:43:59 pm

Title: xeroc's price feed broken
Post by: xeroc on February 09, 2015, 03:43:59 pm
I just realized that my current implementation for the price feeds is broken unless you have funds in the delegates account:
The wallet used to have a 'payee' option for wallet_publish_fees, which is no more with 0.6.0 .. very unfortunate!

I recommend everyone using my script to fund your delegates with some BTS .. the drawback with this is that due to disabled TITAN scanning, your delegate will not be able to see your funds unless you enable scanning and rescan the blockchain .. sucks

paging @vikram : what's the reason for this change?
Title: Re: xeroc's price feed broken
Post by: jsidhu on February 09, 2015, 05:00:49 pm
publishing fees costs money? How much do we need in our account.. im still a standby delegate maybe thats why i cant publish anymore. cause my balance ran out lol

Anyways will the payout function not work now because it cant see the funds? How about if wallet is unlocked for a long time?
Title: Re: xeroc's price feed broken
Post by: onceuponatime on February 09, 2015, 06:39:20 pm
publishing fees costs money? How much do we need in our account.. im still a standby delegate maybe thats why i cant publish anymore. cause my balance ran out lol

Anyways will the payout function not work now because it cant see the funds? How about if wallet is unlocked for a long time?

Nope. You've been elected. Congratulations!
Title: Re: xeroc's price feed broken
Post by: jsidhu on February 09, 2015, 06:55:05 pm
publishing fees costs money? How much do we need in our account.. im still a standby delegate maybe thats why i cant publish anymore. cause my balance ran out lol

Anyways will the payout function not work now because it cant see the funds? How about if wallet is unlocked for a long time?

Nope. You've been elected. Congratulations!

Thanks!.. just upgrading to 0.6.. everytime I redownload the blockchain my client seems to crash.. i only have 2 gigs ram maybe thats not enough.. so it takes me a while to resync.
Title: Re: xeroc's price feed broken
Post by: cube on February 09, 2015, 07:25:47 pm
publishing fees costs money? How much do we need in our account.. im still a standby delegate maybe thats why i cant publish anymore. cause my balance ran out lol

Anyways will the payout function not work now because it cant see the funds? How about if wallet is unlocked for a long time?

Nope. You've been elected. Congratulations!

Thanks!.. just upgrading to 0.6.. everytime I redownload the blockchain my client seems to crash.. i only have 2 gigs ram maybe thats not enough.. so it takes me a while to resync.

Congraz! and thanks for the hard work. :)
Title: Re: xeroc's price feed broken
Post by: vikram on February 09, 2015, 07:34:54 pm
I just realized that my current implementation for the price feeds is broken unless you have funds in the delegates account:
The wallet used to have a 'payee' option for wallet_publish_fees, which is no more with 0.6.0 .. very unfortunate!

I recommend everyone using my script to fund your delegates with some BTS .. the drawback with this is that due to disabled TITAN scanning, your delegate will not be able to see your funds unless you enable scanning and rescan the blockchain .. sucks

paging @vikram : what's the reason for this change?

I am looking at the diff between 0.5.3 and 0.6.0 and see no change to that API (warning, big page): https://github.com/BitShares/bitshares/compare/bts/0.5.3...bts/0.6.0#diff-26273b9b3121b3f8645168381d032dcf

Do you know the last time that this worked?
Title: Re: xeroc's price feed broken
Post by: xeroc on February 10, 2015, 07:46:01 am
I just realized that my current implementation for the price feeds is broken unless you have funds in the delegates account:
The wallet used to have a 'payee' option for wallet_publish_fees, which is no more with 0.6.0 .. very unfortunate!

I recommend everyone using my script to fund your delegates with some BTS .. the drawback with this is that due to disabled TITAN scanning, your delegate will not be able to see your funds unless you enable scanning and rescan the blockchain .. sucks

paging @vikram : what's the reason for this change?

I am looking at the diff between 0.5.3 and 0.6.0 and see no change to that API (warning, big page): https://github.com/BitShares/bitshares/compare/bts/0.5.3...bts/0.6.0#diff-26273b9b3121b3f8645168381d032dcf

Do you know the last time that this worked?
It seems I messed this up from the beginning and no one noticed .. I wonder if a.delegate.charity every published a feed!?
Gonna add this to the README .. delegates need funds to publish slates ..
Title: Re: xeroc's price feed broken
Post by: emski on February 10, 2015, 08:09:09 am
It seems I messed this up from the beginning and no one noticed .. I wonder if a.delegate.charity every published a feed!?
Gonna add this to the README .. delegates need funds to publish slates ..

My version of the script is OK. My payaccount is empty though. Are you sure your environment is OK ?
Title: Re: xeroc's price feed broken
Post by: xeroc on February 10, 2015, 08:14:47 am
It seems I messed this up from the beginning and no one noticed .. I wonder if a.delegate.charity every published a feed!?
Gonna add this to the README .. delegates need funds to publish slates ..

My version of the script is OK. My payaccount is empty though. Are you sure your environment is OK ?
I was doing some work on the scripts and noticed that my script runs:
Code: [Select]
272   request = {
273    "method": "wallet_publish_feeds",                                                                                                                                                               
274    "params": [delegate, assets, payee],
275    "jsonrpc": "2.0",
276    "id": 1
277   }

while the API is documented as:
Code: [Select]
delegate (locked) >>> help wallet_publish_feeds
Usage:
wallet_publish_feeds <delegate_account> <symbol_to_price_map>                                         publishes a set of feeds for BitAssets, only active delegates may do this

Though it seems my old script still runs .. I wonder how the client pays for feed updates as both accounts are unfunded ..

//edit: the 'payee' in my case is delegate.xeroc which is funded ..
Title: Re: xeroc's price feed broken
Post by: vikram on February 10, 2015, 08:17:54 am
Though it seems my old script still runs .. I wonder how the client pays for feed updates from "delegate.charity" and "a.delegate.charity" as both accounts are unfunded ..

//edit: the 'payee' in my case is delegate.xeroc which is funded ..

wallet_publish_feeds will pay fee directly via delegate pay balance if funded, otherwise it will pay from account funds.
Title: Re: xeroc's price feed broken
Post by: xeroc on February 10, 2015, 08:44:33 am
wallet_publish_feeds will pay fee directly via delegate pay balance if funded, otherwise it will pay from account funds.
Ah .. so my erorr above resulted from having wiped the delegate pay into a foreign account just minutes earlier .. makes sense ..