BitShares 0.9.2 Feedback

[vikram]

I have some concerns about the bts/0.9.2 release as I do not see the code previously released to the dvs/0.9.x network for testing.  It is my understanding that all code in BitShares will go through DevShares first for testing.

DevShares:
20 APR 2015 | Latest commit [1]

BitShares:
18 MAY 2015 | bts/0.9.2 [2]
04 MAY 2015 | bts/0.9.1
24 APR 2015 | bts/0.9.0

Request:
Please help me understand the decision process used to release the bts/0.9.2 code into the BitShares network. 

References:
[1] https://github.com/BitShares/DevShares/commits/master
[2] https://github.com/BitShares/bitshares/commits/master

DevShares is a tool to help prevent problems with BitShares upgrades. It is not a perfect tool, and cannot help with some parts of the upgrade process because the DevShares network has a completely different state from the BitShares network, and hardforks happen at different times between the two networks. So we use this tool at our discretion, but by definition the code will never be exactly the same between the two networks.

In particular, the BitShares 0.9.2 release contains changes to code which is not executed in DevShares: https://github.com/BitShares/bitshares/compare/bts/0.9.1...bts/0.9.2

[svk]

In v.0.9.2 on Windows 7 when you navigate to Delegates->My Votes and start playing with the thumb up/down icon the list of delegates goes "crazy" - the items on the delegate list get duplicated several times.
Reloading the page (with a right-click) sometimes helps and navigating away from this page and coming back to it always helps so I guess this is purely a display issue.

(and I can see that the "invalid asset amount" error is still there which in some cases prevents people from being able to vote, please fix it if it's possible in this release)

The first one is a stupid error on my part, I'll fix it when I get home.

Edit: For now please just use the delegates overview tables to adjust votes, not the "My Votes" tab, they should work.

[jakub]

In v.0.9.2 on Windows 7 when you navigate to Delegates->My Votes and start playing with the thumb up/down icon the list of delegates goes "crazy" - the items on the delegate list get duplicated several times.
Reloading the page (with a right-click) sometimes helps and navigating away from this page and coming back to it always helps so I guess this is purely a display issue.

(and I can see that the "invalid asset amount" error is still there which in some cases prevents people from being able to vote, please fix it if it's possible in this release)

[Tuck Fheman]

It is my understanding that all code in BitShares will go through DevShares first for testing.

I'm not sure if this is related to the dev's currently doing everything in private, but it could be. I'm sure you'll get a better answer soon.

[Fox]

I have some concerns about the bts/0.9.2 release as I do not see the code previously released to the dvs/0.9.x network for testing.  It is my understanding that all code in BitShares will go through DevShares first for testing.

DevShares:
20 APR 2015 | Latest commit [1]

BitShares:
18 MAY 2015 | bts/0.9.2 [2]
04 MAY 2015 | bts/0.9.1
24 APR 2015 | bts/0.9.0

Request:
Please help me understand the decision process used to release the bts/0.9.2 code into the BitShares network. 

References:
[1] https://github.com/BitShares/DevShares/commits/master
[2] https://github.com/BitShares/bitshares/commits/master

[roadscape]

Client is much more stable, UI is looking great, just two issues bother me:

1. The price graph scrolls on its own and follows my cursor. Sometimes it dances around for a while when I simply leave the cursor over it.
2. My transaction history does not show (this is not new in 0.9). Relevant error:

2015-05-18T18:38:34        th_a:?unnamed?          log_message ] Message from GUI: rpc error: JSON Parse error: Unterminated string (undefined)
                        Utilities.cpp:36
2015-05-18T18:38:44 bitshares:rebroadcast_pending rebroadcast_pending_ ] rebroadcasting 0                       client.cpp:730
2015-05-18T18:38:44        th_a:?unnamed?          log_message ] Message from GUI: js error: JSON Parse error: Unterminated string
parse@[native code]
 ○ S@http://localhost/js/app.js:5:1792
 ○ ec@http://localhost/js/app.js:6:4265
 ○ http://localhost/js/app.js:6:4692
 ○ f@http://localhost/js/app.js:4:59285
 ○ ic@http://localhost/js/app.js:6:4674
 ○ e@http://localhost/js/app.js:6:10036
 ○ i@http://localhost/js/app.js:6:46035
 ○ http://localhost/js/app.js:6:46207
 ○ $eval@http://localhost/js/app.js:6:82585
 ○ $digest@http://localhost/js/app.js:6:81099
 ○ $apply@http://localhost/js/app.js:6:82859
 ○ f@http://localhost/js/app.js:6:16838
 ○ r@http://localhost/js/app.js:6:25617
 ○ onload@http://localhost/js/app.js:6:26157                    Utilities.cpp:36
2015-05-18T18:38:44        th_a:?unnamed?          log_message ] Message from GUI: rpc error: JSON Parse error: Unterminated string (undefined)
                        Utilities.cpp:36

[karnal]

I compiled and then stripped the (300MB) binary.

[pc]

Migrating my wallet to a new computer.

Begun two days ago.

6 hangs at seemingly random blocks, cpu fan banging loudly and no apparent progress.
4 times input password and the dots animation keeps on going for 10 mins, at which point I manually kill the process.

Only 14 days left to sync now, and the balance is horribly wrong.


This is Debian 8/x86_64.

Just....

Did you self-compile or use a precompiled version? I have created a BitShares package for Debian-8 (among others), see the link in my .signature.

I think the general suggestion is to use the CLI version for syncing. Let it download the chain, and only then open and unlock your wallet.

[CalabiYau]

...........
I'll have to do it manually because it's the vote button where my problem started - it fails to perform with the 35005 invalid_asset_amount error.
...........

Same here - 0.9.1. / WIN 7/64 - only one account affected.

[jakub]

Thanks Ken.
And after I've done the console command you suggested - do I need to send my BTS to myself on each of my accounts to apply the vote?

I could say that the current implementation of the voting process in the GUI is just a terrible guessing game for the user.
But I will not say that.
Instead I will say this: just imagine how much of the voting apathy will be gone once we have it properly implemented in 1.0 GUI (hopefully).

No need to transfer any BTS, the vote will stick as soon as you cast it.
 
The voting is a mess, agreed. Accountability here is a mess. Too much complaining, laziness and not enough action...
 
I am working hard to make this company unbeatable though.
Hang in there jakub please, I'm not giving up just yet. I'm doing everything I can to show people what needs to be done around here to start growing this DAC. Like fuzzy said, I'm the "chicken with his head cut off".

On the contrary, you need to either manually make a transfer to yourself or use the vote now button (which is just a shortcut for making a transfer of your entire balance to yourself) after having approved the delegates you want.

I've fixed the broken thumbs up/down in the develop branch but it's not live yet unfortunately.

Thanks, svk.
I'll have to do it manually because it's the vote button where my problem started - it fails to perform with the 35005 invalid_asset_amount error.
(The manual way might be a bit scary thing to do if you have a bigger balance)
When do you expect to release an upgrade with the 35005 error fixed?

[svk]

Thanks Ken.
And after I've done the console command you suggested - do I need to send my BTS to myself on each of my accounts to apply the vote?

I could say that the current implementation of the voting process in the GUI is just a terrible guessing game for the user.
But I will not say that.
Instead I will say this: just imagine how much of the voting apathy will be gone once we have it properly implemented in 1.0 GUI (hopefully).

No need to transfer any BTS, the vote will stick as soon as you cast it.
 
The voting is a mess, agreed. Accountability here is a mess. Too much complaining, laziness and not enough action...
 
I am working hard to make this company unbeatable though.
Hang in there jakub please, I'm not giving up just yet. I'm doing everything I can to show people what needs to be done around here to start growing this DAC. Like fuzzy said, I'm the "chicken with his head cut off".

On the contrary, you need to either manually make a transfer to yourself or use the vote now button (which is just a shortcut for making a transfer of your entire balance to yourself) after having approved the delegates you want.

I've fixed the broken thumbs up/down in the develop branch but it's not live yet unfortunately.

[kenCode]

Thanks Ken.
And after I've done the console command you suggested - do I need to send my BTS to myself on each of my accounts to apply the vote?

I could say that the current implementation of the voting process in the GUI is just a terrible guessing game for the user.
But I will not say that.
Instead I will say this: just imagine how much of the voting apathy will be gone once we have it properly implemented in 1.0 GUI (hopefully).

No need to transfer any BTS, the vote will stick as soon as you cast it.
 
The voting is a mess, agreed. Accountability here is a mess. Too much complaining, laziness and not enough action...
 
I am working hard to make this company unbeatable though.
Hang in there jakub please, I'm not giving up just yet. I'm doing everything I can to show people what needs to be done around here to start growing this DAC. Like fuzzy said, I'm the "chicken with his head cut off".

[jakub]

I get the same error when I try to vote (i.e. when I press the "Vote" button in the "Vote" tab of one my accounts).
This prevents me from voting.
Is there a workaround for this in version 0.9.1?

I gave up on the thumbs up thing, it's tough to tell if it stuck or not.
I just do this:
Open Wallet > Advanced > Console > approve delegate.kencode true
 
Just edit delegate.kencode to whomever you want to vote for. Change true to false if you want to downvote a delegate.
 
Hope that helps
  -ken

Thanks Ken.
And after I've done the console command you suggested - do I need to send my BTS to myself on each of my accounts to apply the vote?

I could say that the current implementation of the voting process in the GUI is just a terrible guessing game for the user.
But I will not say that.
Instead I will say this: just imagine how much of the voting apathy will be gone once we have it properly implemented in 1.0 GUI (hopefully).

[kenCode]

I get the same error when I try to vote (i.e. when I press the "Vote" button in the "Vote" tab of one my accounts).
This prevents me from voting.
Is there a workaround for this in version 0.9.1?

I gave up on the thumbs up thing, it's tough to tell if it stuck or not.
I just do this:
Open Wallet > Advanced > Console > approve delegate.kencode true
 
Just edit delegate.kencode to whomever you want to vote for. Change true to false if you want to downvote a delegate.
 
Hope that helps
  -ken

[jakub]

0.9.1 still has 35005 invalid_asset_amount error, when I try to buy MOONFUND

Code: [Select]

35005 invalid_asset_amount: invalid asset amount

    {"share_string":"0.869412","max_rhs_size":5}
    bitshares  asset_record.cpp:93 bts::blockchain::asset_record::share_string_to_satoshi

    {"share_string":"0.869412","precision":100000}
    bitshares  asset_record.cpp:109 bts::blockchain::asset_record::share_string_to_satoshi

    {"amount":"0.869412"}
    bitshares  asset_record.cpp:114 bts::blockchain::asset_record::asset_from_string

    {"amount":"0.869412","symbol":"BTS"}
    bitshares  chain_interface.cpp:241 bts::blockchain::chain_interface::to_ugly_asset

    {"from_account_name":"clayop","real_quantity":"0.869412","quantity_symbol":"BTS","quote_price":"1.1500000230000005","quote_symbol":"MOONFUND","sign":true}
    bitshares  wallet.cpp:3495 bts::wallet::wallet::submit_bid

    {}
    bitshares  common_api_client.cpp:5279 bts::rpc_stubs::common_api_client::wallet_market_submit_bid

Buy

Code: [Select]

0.86941instead of

Code: [Select]

0.869412

I get the same error when I try to vote (i.e. when I press the "Vote" button in the "Vote" tab of one my accounts).
This prevents me from voting.
Is there a workaround for this in version 0.9.1?