Author Topic: Rate Limited Free Transactions Feature Implemented  (Read 16181 times)

0 Members and 1 Guest are viewing this topic.

Offline CLains

  • Hero Member
  • *****
  • Posts: 2606
    • View Profile
  • BitShares: clains
+5% +5% Don't know much about coding but you seem to be doing great fast work, abit, well done!

 +5%

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12922
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc
chinese still pissed off

fees still too expensive

you must send 100 BTC randsom to china or else suffer the wrath of the monkey new year (all chinese dump
all BitShares!)


按百分比计算转账手续费功能,开发完成
只要降低,就支持,降得越低越支持







sarc



actually, props to the red dragon for showing us that we can have our cake and eat it too.

subsidized microtransactions and happy Long Term Members!!
Cool thing is .. we dont need to put this on every asset .. but maybe just USD and CNY .. we can keep BTS transferes (comparable) expensive

Offline Musewhale

  • Hero Member
  • *****
  • Posts: 2881
  • 丑,实在是太丑了 !
    • View Profile
MUSE witness:mygoodfriend     vote for me

Offline giant middle finger

  • Full Member
  • ***
  • Posts: 99
    • View Profile
chinese still pissed off

fees still too expensive

you must send 100 BTC randsom to china or else suffer the wrath of the monkey new year (all chinese dump
all BitShares!)


按百分比计算转账手续费功能,开发完成
只要降低,就支持,降得越低越支持







sarc



actually, props to the red dragon for showing us that we can have our cake and eat it too.

subsidized microtransactions and happy Long Term Members!!


Offline sudo

  • Hero Member
  • *****
  • Posts: 2255
    • View Profile
  • BitShares: ags
 +5% +5% +5% +5% +5% +5% cool  awesome
I like it  becacuse  I lock my bts 8) 8) 8)

TravelsAsia

  • Guest
awesome job!

for your next project ... could you please fork from graphene/develop? that would make it way easier to integrate this into MUSE or the testnet!!!

+5% anyway

 +5%

Great initiative.

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 4664
    • View Profile
    • Abit's Hive Blog
  • BitShares: abit
  • GitHub: abitmore
I did a quick review of the implementation and believe it accomplishes 90% of what I wanted to accomplish. The only thing this doesn't do is dynamically adjust the fee in response to load.

Assuming this gets properly tested I would support integrating it.
Thanks.
It's a bit hard to make it dynamic, so I made a simpler implementation first.
Still testing..
BitShares committee member: abit
BitShares witness: in.abit

Offline Empirical1.2

  • Hero Member
  • *****
  • Posts: 1366
    • View Profile
 +5% +5% Don't know much about coding but you seem to be doing great fast work, abit, well done!
If you want to take the island burn the boats

Offline merivercap

  • Hero Member
  • *****
  • Posts: 661
    • View Profile
    • BitCash
 +5%

Great to hear..

Thanks for the review @bytemaster!

Fantastic job @abit
BitCash - http://www.bitcash.org 
Beta: bitCash Wallet / p2p Gateway: (https://m.bitcash.org)
Beta: bitCash Trade (https://trade.bitcash.org)

Offline svk

Awesome stuff @abit, you're on a roll! :)
Worker: dev.bitsharesblocks

Offline bytemaster

I did a quick review of the implementation and believe it accomplishes 90% of what I wanted to accomplish. The only thing this doesn't do is dynamically adjust the fee in response to load.

Assuming this gets properly tested I would support integrating it.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline Thom

I really like how you implemented this abit  +5%. I understand the comment about the approach being a "bandaid", but actually the approach you took makes a lot of sense and allows the system to function exactly as it does now, should there be a bottleneck or bug in the process of adding to or paying out of the "accumulated fees" (i.e. rate limiting) holdings. This is an enhancement in the purest sense of the word.

I take it if an operation requires a fee and there is a balance of accumulated fees, the cost of the operation will automatically be supplied from the accumulated fees holdings?

I do seem to recall BM commenting somewhere that such operation should not be allowed. I could be wrong about that. I believe it has to do with whales exceeding the available network bandwidth?

Am I also correct in assuming that there are no prohibitions, stoppages, "sorry, can't do that" aspects to your approach? For example using a std account with a 1000 BTS balance performing some op (say in a python loop) that requires 1 BTS, there is nothing that would restrict the speed of that loop right? If there were no rate limiting, the loop would terminate after 1000 iterations (assuming the op didn't impact account balance). With rate limiting perhaps a few more iterations could be possible, due to accumulated fees being non-zero + the original 1000 BTS balance that both contribute to fees.
Injustice anywhere is a threat to justice everywhere - MLK |  Verbaltech2 Witness Reports: https://bitsharestalk.org/index.php/topic,23902.0.html

Xeldal

  • Guest

The "accumulated fees" can only be used to pay fees. Or say it's budgets. When you're running out of budgets, you can pay fee in the original way. Make sense?

And fees paid with coin-days wont go to referral program (or cash back for LTM), they are eliminated.

Yes that makes sense.  Thank you.
I like that you've left available the option to pay fee if beyond coin-days budget. : ) very nice!

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 4664
    • View Profile
    • Abit's Hive Blog
  • BitShares: abit
  • GitHub: abitmore

I haven't looked at the code but I'm glad to see this sort of input. Great way to set an example for others to follow, Abit.
Example of developing back-end, or GUI, or example of using it? I will post my CLI commands here while testing through it.

By the way, my worker hasn't started yet, perhaps svk hasn't have time to work on related GUI.
BitShares committee member: abit
BitShares witness: in.abit