Author Topic: New BSIP's about market engine improvements  (Read 3158 times)

0 Members and 1 Guest are viewing this topic.


Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 4664
    • View Profile
    • Abit's Hive Blog
  • BitShares: abit
  • GitHub: abitmore
I guess we build these groups:

Your's
* BSIP32 + BSIP33
* BSIP31 + BSIP34
* BSIP35

Alfredo's:
* BSIP36
* BSIP37
There is also BSIP30.

I'd recommend creating a poll for each BSIP. If I think grouping is better, I would have combined several BSIP's into one.
« Last Edit: February 27, 2018, 06:08:06 pm by abit »
BitShares committee member: abit
BitShares witness: in.abit

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12922
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc
I guess we build these groups:

Your's
* BSIP32 + BSIP33
* BSIP31 + BSIP34
* BSIP35

Alfredo's:
* BSIP36
* BSIP37

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 4664
    • View Profile
    • Abit's Hive Blog
  • BitShares: abit
  • GitHub: abitmore
Note that the BBF can set up the voting proposal workers for you, they have a special type of workers for that (see bsip29)
Please do when it's time. Thanks!
Erm, just to confirm, do i read you right that i wait until you give a go?
Actually I'm not sure is it better to start polling on all BSIP's at once, or start polling on each one when that one is ready. Generally, I want better voter turnout.

Currently, from me, BSIP 30-34 are ready, but BSIP 35 may need more work. Besides that, there are also other BSIP's need to be voted on, and some still to be written.

What's your opinion?
BitShares committee member: abit
BitShares witness: in.abit

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12922
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc
Note that the BBF can set up the voting proposal workers for you, they have a special type of workers for that (see bsip29)
Please do when it's time. Thanks!
Erm, just to confirm, do i read you right that i wait until you give a go?

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 4664
    • View Profile
    • Abit's Hive Blog
  • BitShares: abit
  • GitHub: abitmore
Note that the BBF can set up the voting proposal workers for you, they have a special type of workers for that (see bsip29)
Please do when it's time. Thanks!
BitShares committee member: abit
BitShares witness: in.abit

Offline R

  • Hero Member
  • *****
  • Posts: 1004
    • View Profile
These BSIPs look great @abit, I'll vote to support their implementation. Keep up the great work  :)

Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12922
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc
@fav, can you please move this ibto stakeholder subforum, i am currently on mobile/business trip

As for the proposals, I actually like them a lot since they "fix" behavior that is "usually" different from what bitshares currently does.

I need to go thru the impact on margin calls again to be sure there are no side effects, but so far, this is looking good!

Excellent work!

Note that the BBF can set up the voting proposal workers for you, they have a special type of workers for that (see bsip29)

Offline abit

  • Committee member
  • Hero Member
  • *
  • Posts: 4664
    • View Profile
    • Abit's Hive Blog
  • BitShares: abit
  • GitHub: abitmore
Changing of behavior requires approval of stake holders.

BSIP's (BitShares Improvement Protocols) are documents those should clearly describe the changes, then to be voted on by stake holders, then to be coded/implemented and tested and then deployed.

Here are changes about the market engine that will need to be voted on in the near future:

* BSIP 30: Always Allow Increasing Collateral Ratio If Debt Not Increased, https://github.com/bitshares/bsips/blob/master/bsip-0030.md

* BSIP 31: Update Short Position's Margin Call Price After Partially Called Or Settled, https://github.com/bitshares/bsips/blob/master/bsip-0031.md

* BSIP 32: Always Match Orders At Maker Price, https://github.com/bitshares/bsips/pull/56

* BSIP 33: Maker Orders With Better Prices Take Precedence, https://github.com/bitshares/bsips/pull/57

* BSIP 34: Always Trigger Margin Call When Call Price Above Or At Price Feed, https://github.com/bitshares/bsips/pull/58

* BSIP 35: A Solution To Something-For-Nothing Issue, https://github.com/bitshares/bsips/pull/59

(BSIP 26, 27 and 29 are considered as approved already so not listed here)

(There are other topics not included in this list, E.G. stop-loss order, since IMHO we need to improve step by step, and IMHO at this moment we're not ready to make those changes.)

In order to make the voting process as smooth as possible, it's best to thoroughly discuss the details before starting to vote.

Please participate.

(Perhaps should post this to proposals board? If yes, please help move it.)
BitShares committee member: abit
BitShares witness: in.abit