Author Topic: Market Fees not updating in RC1?  (Read 343 times)

0 Members and 1 Guest are viewing this topic.

Offline NeoReel

  • Jr. Member
  • **
  • Posts: 47
  • Entrepreneur
    • View Profile
    • NeoReel
  • BitShares: neoreel-1
Market Fees not updating in RC1?
« on: December 04, 2018, 05:47:34 pm »
Hello,

I'm using the Bitshares UI version 181121-rc1 and I'm wondering why the market fees are not updating as I type in values when placing an order.
For instance, selling BTS in the BTS/BitUSD market should have 0.1% market fee, but it remains 0.



Can anyone let me know if the Market fee is taken even though not displayed?

Also, please fix this typo in the "Deposit USD" button:



Thanks,
« Last Edit: December 04, 2018, 05:55:35 pm by NeoReel »
President - NeoReel.com
CTO- MoClip.com
CEO- Relinked.com

Offline startail

Re: Market Fees not updating in RC1?
« Reply #1 on: December 23, 2018, 02:58:42 pm »
These have been reported on the GitHub repo, and will be taken care of.

Offline Digital Lucifer

  • Global Moderator
  • Full Member
  • *****
  • Posts: 192
  • 13 years of being Slackware abUser
    • View Profile
    • BitShares 2.0
  • BitShares: steem-not
  • GitHub: dls-cipher
Re: Market Fees not updating in RC1?
« Reply #2 on: December 23, 2018, 03:20:30 pm »
These have been reported on the GitHub repo, and will be taken care of.

Please if possible, when issue is closed inform us here. I'll then lock and move to graveyard.

Hello,

I'm using the Bitshares UI version 181121-rc1 and I'm wondering why the market fees are not updating as I type in values when placing an order.
For instance, selling BTS in the BTS/BitUSD market should have 0.1% market fee, but it remains 0.



Can anyone let me know if the Market fee is taken even though not displayed?

Also, please fix this typo in the "Deposit USD" button:



Thanks,

Thanks for report of the issue! :)


Chee®s
Milos (DL) Preocanin
Owner and manager of bitshares.org through Consensus
Move Institute - RN: 2098555000
Murska Sobota, Slovenia, SI.

Offline iamredbar

Re: Market Fees not updating in RC1?
« Reply #3 on: December 23, 2018, 03:46:56 pm »
I fixed the spelling, it is already merged with the development branch.

Offline Digital Lucifer

  • Global Moderator
  • Full Member
  • *****
  • Posts: 192
  • 13 years of being Slackware abUser
    • View Profile
    • BitShares 2.0
  • BitShares: steem-not
  • GitHub: dls-cipher
Re: Market Fees not updating in RC1?
« Reply #4 on: December 23, 2018, 05:41:51 pm »
I fixed the spelling, it is already merged with the development branch.

What about the missing fee calculation ?
Milos (DL) Preocanin
Owner and manager of bitshares.org through Consensus
Move Institute - RN: 2098555000
Murska Sobota, Slovenia, SI.

Offline iamredbar

Re: Market Fees not updating in RC1?
« Reply #5 on: December 23, 2018, 05:49:13 pm »
What about the missing fee calculation ?

I have not done anything with that. Looks like it’s been brought up a couple times: https://github.com/bitshares/bitshares-ui/issues/2375

Offline Digital Lucifer

  • Global Moderator
  • Full Member
  • *****
  • Posts: 192
  • 13 years of being Slackware abUser
    • View Profile
    • BitShares 2.0
  • BitShares: steem-not
  • GitHub: dls-cipher
Re: Market Fees not updating in RC1?
« Reply #6 on: December 23, 2018, 06:05:31 pm »
What about the missing fee calculation ?

I have not done anything with that. Looks like it’s been brought up a couple times: https://github.com/bitshares/bitshares-ui/issues/2375

Thanks, dev from my team is looking into it now.

Chee®s
Milos (DL) Preocanin
Owner and manager of bitshares.org through Consensus
Move Institute - RN: 2098555000
Murska Sobota, Slovenia, SI.

Offline startail

Re: Market Fees not updating in RC1?
« Reply #7 on: December 23, 2018, 06:44:02 pm »
Yes, these two issues have been fixed recently. The misspelling was merged a few days ago and the market fee will be in the next release.
https://github.com/bitshares/bitshares-ui/issues/2375

Offline Digital Lucifer

  • Global Moderator
  • Full Member
  • *****
  • Posts: 192
  • 13 years of being Slackware abUser
    • View Profile
    • BitShares 2.0
  • BitShares: steem-not
  • GitHub: dls-cipher
Re: Market Fees not updating in RC1?
« Reply #8 on: December 24, 2018, 02:33:18 am »
Yes, these two issues have been fixed recently. The misspelling was merged a few days ago and the market fee will be in the next release.
https://github.com/bitshares/bitshares-ui/issues/2375

Done. Locked for further discussion and will be moved to Graveyard in 3 days.


Chee®s
Milos (DL) Preocanin
Owner and manager of bitshares.org through Consensus
Move Institute - RN: 2098555000
Murska Sobota, Slovenia, SI.