Author [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] Topic: Typo in comments in momentum.cpp  (Read 455 times)

0 Members and 1 Guest are viewing this topic.

Offline dga

  • Full Member
  • ***
  • Posts: 122
    • View Profile
Typo in comments in momentum.cpp
« on: January 13, 2014, 12:52:51 PM »

Hi, FreeTrade -

Line 94 of momentum.cpp has an incorrect comment:

//use last 4 bits of first cache as next location

4 should be 14 (or abstracted in terms of the other constants).

Offline isaacgoldbourne

  • Sr. Member
  • ****
  • Posts: 322
    • View Profile
Re: Typo in comments in momentum.cpp
« Reply #1 on: January 13, 2014, 01:57:47 PM »
Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it
MemoryDice now available! https://bitsharestalk.org/index.php?topic=1886.0
 Vote for me to be CNO of memorycoin if you want these services. Just send 1 satoshi!
CNO: MVTEcno2tbsJWj7AQEyEjgk72j94hbPHFm

Offline dga

  • Full Member
  • ***
  • Posts: 122
    • View Profile
Re: Typo in comments in momentum.cpp
« Reply #2 on: January 13, 2014, 04:43:52 PM »
Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it

Yup, It's just a comment typo.  :)  It just makes it a little harder to understand the PoW function when reading the source.

Offline barwizi

  • Hero Member
  • *****
  • Posts: 764
  • Noirbits, NoirShares, NoirEx.....lol, noir anyone?
    • View Profile
    • Noirbitstalk.org
Re: Typo in comments in momentum.cpp
« Reply #3 on: January 13, 2014, 05:17:40 PM »
Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it

Yup, It's just a comment typo.  :)  It just makes it a little harder to understand the PoW function when reading the source.

the typo can affect how devs perceive the PoW
--Bar--  PiNEJGUv4AZVZkLuF6hV4xwbYTRp5etWWJ

The magical land of crypto, no freebies people.

Offline isaacgoldbourne

  • Sr. Member
  • ****
  • Posts: 322
    • View Profile
Re: Typo in comments in momentum.cpp
« Reply #4 on: January 13, 2014, 07:21:54 PM »
Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it

Yup, It's just a comment typo.  :)  It just makes it a little harder to understand the PoW function when reading the source.

the typo can affect how devs perceive the PoW
Not too hard to realize the mistake, I can't speak for every dev but I use comments to see what does what, and then I read the code to see the how.
MemoryDice now available! https://bitsharestalk.org/index.php?topic=1886.0
 Vote for me to be CNO of memorycoin if you want these services. Just send 1 satoshi!
CNO: MVTEcno2tbsJWj7AQEyEjgk72j94hbPHFm

 

Google+