Typo in comments in momentum.cpp

isaacgoldbourne · January 13, 2014, 07:21:54 PM

Quote from: barwizi on January 13, 2014, 05:17:40 PM
Quote from: dga on January 13, 2014, 04:43:52 PM
Quote from: isaacgoldbourne on January 13, 2014, 01:57:47 PM
Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it

Yup, It's just a comment typo. :) It just makes it a little harder to understand the PoW function when reading the source.

the typo can affect how devs perceive the PoW

Not too hard to realize the mistake, I can't speak for every dev but I use comments to see what does what, and then I read the code to see the how.

barwizi · January 13, 2014, 05:17:40 PM

Quote from: dga on January 13, 2014, 04:43:52 PM
Quote from: isaacgoldbourne on January 13, 2014, 01:57:47 PM
Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it

Yup, It's just a comment typo. :) It just makes it a little harder to understand the PoW function when reading the source.

the typo can affect how devs perceive the PoW

dga · January 13, 2014, 04:43:52 PM

Quote from: isaacgoldbourne on January 13, 2014, 01:57:47 PM
Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it

Yup, It's just a comment typo. :) It just makes it a little harder to understand the PoW function when reading the source.

isaacgoldbourne · January 13, 2014, 01:57:47 PM

Not too much of a big deal, still functional. Although well done for pointing it out I'm sure he will appreciate it

dga · January 13, 2014, 12:52:51 PM

Hi, FreeTrade -

Line 94 of momentum.cpp has an incorrect comment:

//use last 4 bits of first cache as next location

4 should be 14 (or abstracted in terms of the other constants).