Author [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] [EN] [ZH] [ES] [PT] [IT] [DE] [FR] [NL] [TR] [SR] [AR] [RU] Topic: 100 PTS - ProtoShares-Qt wallet that will send change to a specified [PAID]  (Read 2425 times)

0 Members and 1 Guest are viewing this topic.

Offline bytemaster


I would like an update to the ProtoShares-Qt wallet that gives users the ability to specify the change address when they send.

To claim this bounty you must have a pull request accepted and merged by FreeTrade who will the build a Windows executable.  FreeTrade, you volunteered to do this from time to time for us, but I am more than willing to pay you some PTS as a tip for helping in this way.

« Last Edit: January 09, 2014, 08:04:46 PM by bytemaster »
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline barwizi

  • Hero Member
  • *****
  • Posts: 764
  • Noirbits, NoirShares, NoirEx.....lol, noir anyone?
    • View Profile
    • Noirbitstalk.org
To understand more about change and change addresses please read this https://bitcoinspakistan.com/blog/all-about-change-and-change-addresses/

This may require more work than i thought

ok, so we need to Coin control to the wallet. bytemaster, care to x10 the bounty amount?
« Last Edit: January 04, 2014, 07:58:37 PM by barwizi »
--Bar--  PiNEJGUv4AZVZkLuF6hV4xwbYTRp5etWWJ

The magical land of crypto, no freebies people.

Offline barwizi

  • Hero Member
  • *****
  • Posts: 764
  • Noirbits, NoirShares, NoirEx.....lol, noir anyone?
    • View Profile
    • Noirbitstalk.org
https://github.com/bitcoin/bitcoin/pull/2343/files

is what we have to do basically. i am going to start now. does anyone want to help?
--Bar--  PiNEJGUv4AZVZkLuF6hV4xwbYTRp5etWWJ

The magical land of crypto, no freebies people.

Offline 5chdn

  • Sr. Member
  • ****
  • Posts: 487
  • i wonder how many chars i can put in this field 50
    • View Profile
    • Votesapp
  • GitHub: 5chdn
This is a huge change in the client and protocol how transactions are processed.

I think this topic is worth ~ 500 PTS. A good approach would be to implement the experimental coin control from bitcoin client.

Read more on "bitcoin coin control" on google.
https://bitcointalk.org/index.php?topic=144331.0
https://github.com/bitcoin/bitcoin/pull/2343

Offline bytemaster

This is a huge change in the client and protocol how transactions are processed.

I think this topic is worth ~ 500 PTS. A good approach would be to implement the experimental coin control from bitcoin client.

Read more on "bitcoin coin control" on google.
https://bitcointalk.org/index.php?topic=144331.0
https://github.com/bitcoin/bitcoin/pull/2343

It should just be replacing the change address and nothing on the protocol layer.   I will up the bounty slightly.
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline toast

It should just be replacing the change address and nothing on the protocol layer.   I will up the bounty slightly.
So will there be separate clients for people that want the usual change behavior and people that want change to come back to the same address?
(giving the user the option to choose is basically re-implementing coincontrol)
Do not use this post as information for making any important decisions. The only agreements I ever make are informal and non-binding. Take the same precautions as when dealing with a compromised account, scammer, sockpuppet, etc.

Offline bytemaster

It should just be replacing the change address and nothing on the protocol layer.   I will up the bounty slightly.
So will there be separate clients for people that want the usual change behavior and people that want change to come back to the same address?
(giving the user the option to choose is basically re-implementing coincontrol)

I think it could be as simple as a single extra field in the sending field.  No need to control inputs, just the change address. 
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline barwizi

  • Hero Member
  • *****
  • Posts: 764
  • Noirbits, NoirShares, NoirEx.....lol, noir anyone?
    • View Profile
    • Noirbitstalk.org
I had already started putting Coin Control, should i stop? I'm half way done.
--Bar--  PiNEJGUv4AZVZkLuF6hV4xwbYTRp5etWWJ

The magical land of crypto, no freebies people.

Offline bytemaster

I had already started putting Coin Control, should i stop? I'm half way done.

Coin control is fine!  It is even better :)
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline barwizi

  • Hero Member
  • *****
  • Posts: 764
  • Noirbits, NoirShares, NoirEx.....lol, noir anyone?
    • View Profile
    • Noirbitstalk.org
Nearly done adding the code, i however found this draw back commented in

Code: [Select]
// Note: We use a new key here to keep it from being obvious which side is the change.
 +                        //  The drawback is that by not reusing a previous key, the change may be lost if a
 +                        //  backup is restored, if the backup doesn't have the new private key for the change.
 +                        //  If we reused the old key, it would be possible to add code to look for and
 +                        //  rediscover unknown transactions that were written with keys of ours to recover
 +                        //  post-backup change.
--Bar--  PiNEJGUv4AZVZkLuF6hV4xwbYTRp5etWWJ

The magical land of crypto, no freebies people.

Offline 5chdn

  • Sr. Member
  • ****
  • Posts: 487
  • i wonder how many chars i can put in this field 50
    • View Profile
    • Votesapp
  • GitHub: 5chdn
We should carefully consider all pros and cons.

Offline toast

Not sure if this is a healthy attitude but if protoshareholders are supposed to have "the resources, the interest, and the domain knowledge to invest [protoshares] wisely", should we really be doing this much hand-holding?
Do not use this post as information for making any important decisions. The only agreements I ever make are informal and non-binding. Take the same precautions as when dealing with a compromised account, scammer, sockpuppet, etc.

Offline bytemaster


Not sure if this is a healthy attitude but if protoshareholders are supposed to have "the resources, the interest, and the domain knowledge to invest [protoshares] wisely", should we really be doing this much hand-holding?

I want this tool to simplify my life as well. 


Sent from my iPhone using Tapatalk
For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline barwizi

  • Hero Member
  • *****
  • Posts: 764
  • Noirbits, NoirShares, NoirEx.....lol, noir anyone?
    • View Profile
    • Noirbitstalk.org
Not sure if this is a healthy attitude but if protoshareholders are supposed to have "the resources, the interest, and the domain knowledge to invest [protoshares] wisely", should we really be doing this much hand-holding?

toast, would you mind testing it out, am short on linux at the moment.

you'll find i commented some areas as //unsure since i could not make heads or tails of it, some files were very different.

https://drive.google.com/folderview?id=0BxCtiOzdwvPyZmtfM2llZWhSOU0&usp=sharing

the version of protshares i have has no makefile.am, weird. you will need to replace

Code: [Select]
clientversion.h compat.h core.h crypter.h db.h hash.h init.h \
with

Code: [Select]
clientversion.h coincontrol.h compat.h core.h crypter.h db.h hash.h init.h \
in src/makefile.am

and

Code: [Select]
forms/askpassphrasedialog.ui forms/editaddressdialog.ui forms/intro.ui \

with


Code: [Select]
forms/askpassphrasedialog.ui forms/coincontroldialog.ui forms/editaddressdialog.ui forms/intro.ui \
in src/qt/Makefile.am
« Last Edit: January 04, 2014, 10:45:52 PM by barwizi »
--Bar--  PiNEJGUv4AZVZkLuF6hV4xwbYTRp5etWWJ

The magical land of crypto, no freebies people.

Offline toast

Can you put it on github?

Make an account, click "fork" on the I3 protoshares repo.
Code: [Select]
git clone <YOUR protoshares repo>
## make your changes
git add -u
git commit -m "coincontrol"
git push
Do not use this post as information for making any important decisions. The only agreements I ever make are informal and non-binding. Take the same precautions as when dealing with a compromised account, scammer, sockpuppet, etc.

 

Google+