Author Topic: Worker Proposal - Alfredo Garcia - Core Developer for the second half of 2017  (Read 17420 times)

0 Members and 1 Guest are viewing this topic.

Offline fav

  • Hero Member
  • *****
  • Posts: 4278
  • No Pain, No Gain
    • View Profile
    • Follow Me!
  • BitShares: fav
any chance to focus on a working block explorer first? 

cryptofresh seems to be gone for good now

Offline oxarbitrage

Hello Bitshares community, i was not able to post the weekly report of the worker during the weekend so i am posting it today Monday for work done last week.

- https://github.com/bitshares/bitshares-core/pull/335

i requested the help of peter conrad(@pc) to solving this issue. he made a patch into my repo, i just pulled it to bitshares and finally merged to the develop branch after testing.

issue will be closed in 24 hours if there is no objections as the problem is solved: https://github.com/bitshares/bitshares-core/issues/325

- https://github.com/bitshares/bitshares-core/issues/329

at this issue i sent instructions to the issuer on how to do what he was trying to do with what was currently available. issue was closed and later reopened requesting a small modification in the get_trade_history results.

request was considered and patch was sent to the bitshares develop branch:
https://github.com/bitshares/bitshares-core/pull/344

this is now under review of the bitshares developer community.

- https://github.com/bitshares/bitshares-core/pull/336

in this patch submitted by peter conrad part of the problem of issue 303(https://github.com/bitshares/bitshares-core/issues/303) gets solved. the issue in the node output is fixed with the patch but the unit tests are not. trying to make a fix to both cases before approving it.

- https://github.com/bitshares/bitshares-core/pull/332

changes were made to patch to consider when api-access file does not exist in the filesystem.
this is for issue https://github.com/bitshares/bitshares-core/issues/331 that will be closed in 24 hs if there are no objections.

- Explorer TODO: https://github.com/oxarbitrage/bitshares-explorer/blob/master/TODO.md and roadmap for a 1 month plan has been released: https://github.com/oxarbitrage/bitshares-explorer/blob/master/Roadmap1.md

Also in the past week some of the checked items in the TODO were done.

Finally, there is a lot of stuff going on with implementation of bsip-018, the bitshares hardfork and a recent steem post that introduced some new(and some not so new) issues in the chain. I am currently working at some of this but no enough advances to put it in the report, more on this next week.

thank you very much for reading ;)

Offline oxarbitrage

- https://github.com/bitshares/bitshares-core/issues/325
i am having some problems with this one, i sent it to @pc who will take a look in the next days. i think he may be the right person to change the flat_index we have left. i may came back to it if he can't make it but i had to move on.

I've created a PR on your personal repo: https://github.com/oxarbitrage/bitshares-core/pulls


awesome, thanks, i am testing it now and ill send it to bitshares. very appreciated. lets continue with it in the github. many thanks again :)

Offline pc

  • Hero Member
  • *****
  • Posts: 1530
    • View Profile
    • Bitcoin - Perspektive oder Risiko?
  • BitShares: cyrano
- https://github.com/bitshares/bitshares-core/issues/325
i am having some problems with this one, i sent it to @pc who will take a look in the next days. i think he may be the right person to change the flat_index we have left. i may came back to it if he can't make it but i had to move on.

I've created a PR on your personal repo: https://github.com/oxarbitrage/bitshares-core/pulls
Bitcoin - Perspektive oder Risiko? ISBN 978-3-8442-6568-2 http://bitcoin.quisquis.de

Offline oxarbitrage

Folks, the following are the last github issues and contributions made by this worker during the last week in the bitshares network:

- https://github.com/bitshares/bitshares-core/issues/328
discussed, implemented, tested, merged and closed.

- https://github.com/bitshares/bitshares-core/issues/325
i am having some problems with this one, i sent it to @pc who will take a look in the next days. i think he may be the right person to change the flat_index we have left. i may came back to it if he can't make it but i had to move on.

- https://github.com/bitshares/bitshares-core/issues/331
reproduced the problem, sent instructions to issuer. accepted suggestion of log msg for api-access file and made pull request here:  https://github.com/bitshares/bitshares-core/pull/332 , changed main README to clarify how to use thie api-access file, sent changes to documentation at: https://github.com/BitSharesEurope/docs.bitshares.eu/pull/12

the idea is to make the documentation repo more active and update it with pull requests as errors/changes are found. please any documentation issue in http://docs.bitshares.org/ submit a pull request to the docs repo or just point it to me and i will do it.

- new pull request: https://github.com/bitshares/bitshares-core/pull/334 for issue https://github.com/bitshares/bitshares-core/issues/298 , this is a replace of pull https://github.com/bitshares/bitshares-core/pull/305

- explorer 1 month roadmap. still on it, will try to release the roadmap Monday to get the project resumed this starting week.

Offline oxarbitrage

Folks, as usual here are the last github issues and other areas i was working on during the last week:

- created "develop" branch to bitshares-core. this is part of our efforts to professionalize the development in bitshares. all pull requests(except for very special cases exceptions) will go into this branch before going to the master. develop branch is less rigorous in merging of code than the master. this will encourage new pull requests from outside developers while will introduce less buggy and more tested code into the main branch.

- https://github.com/bitshares/bitshares-core/issues/325

this issue was opened to find root cause and to fix future problems after the crash in the network we had Monday. as soon as @abit noticed the problem and posted in the telegram developer channel a huge effort started from devs, witnesses, community members controlling public opinion and others to get the network up again. this problem exposed the very fast and big response team the bitshares community haves to handle critical situations, a big thanks to everything who participated in the recovery at any level.

@pc found the root cause in a bad proposal sent to the network, the technical details are in the issue. he also created a test unit and pulled to the develop branch:
https://github.com/bitshares/bitshares-core/pull/326
i tested and merged the pull request.

as the original problem is in the use of flat_index containers in our code, we all agree that we need to remove the other flat_indexes in our repo to avoid any future problem of the same kind. the only flat_index left is at block_summary_object. i am in the process of replacing this index in the code but i am having some problems and got stuck. as there is so many things to do and i don't want to stay too much time in the same thing i asked some advice today to @ElMato. he will review, in case problems remain there are other community members that may help just as @pc or @abit, the community is pretty rich to ask technical advice.

more updates on this issue will be posted to issue #326 and a pull request with the changed index as well.

- https://github.com/bitshares/bitshares-core/issues/329

closed issue helping to get the data needed with current api calls.

- https://github.com/bitshares/bitshares-core/issues/328

self assigned issue, this should be an easy one, i will upload patch tomorrow(monday).

- http://bitshares-explorer.io:9009/#/dashboard

resuming the work in the explorer, I have a huge TODO list that will be converted to a roadmap, trying to put everything inside a 4 weeks period to have a first version open source released in 1 month.

Offline oxarbitrage

Here are some updates of last week github issues of the bitshares core that i worked on:

- https://github.com/bitshares/bitshares-core/issues/322
help xeroc to subscribe after changes made in #231.

- https://github.com/bitshares/bitshares-core/issues/323
open ticket with polo in order to fix this problem. the error has now gone but not response from polo side yet.

- https://github.com/bitshares/bitshares-core/issues/320
helping user with installation in slackware.

- https://github.com/bitshares/bitshares-core/issues/29
in order to get started the organizing efforts of the bitshares code i identified and make a task list of all the TODO inside the core code.

Offline oxarbitrage

thank you for the post @pc , i agree with everything you stated. i want to ask here if i can get privileges in the bitshares repos as i currently don't have any. i will like to create branch, add people to tasks, add tags to issues, close issues, review pull requests, etc.

Quote
* We should apply a proper development process on the github repo, like gitflow. Currently, everything goes right into master, which is generally a bad idea.

i agree fully with this, pull requests against master directly is not a good idea, it saves time but it is unprofessional. gitflows seems to be the way to have feature branches, versioned releases and such. it will bring our code to a next level.

Quote
* Perhaps we should integrate @xeroc's testnet branch into the main repo.

Can  take care if i can get the privs, i know you had synchronized this project for xeroc so we should do that now.

Quote
* Create a set of rules for development, like
1. PR's are always to be made against develop.
2. PR's have to be ACKed by at least two "important" devs (apart from the submitter).
3. Merging develop into master is only allowed after develop has been tested successfully in testnet.
4. Merging into master requires ACK from at least three "important" devs.
(where an "important" dev is someone who has shown sufficient knowledge of the codebase, for example by submitting PRs).

i agree with the rules and with the testnet step. i think the "important" devs active now are:
- @pc
- @ElMato
- @abit
- @xeroc
- @oxarbitrage

so if one of this members is submitting a pull request i think it should be maybe 1 approve to the dev branch and 2 to the master until we have at least one more active "important" member. if the requester is from outside this 5 numbers then he is going to need approve by 2 of the main members to add to the dev and 3 to the master.

Quote
* Create a set of rules for releases, especially wrt time frames in the case of a hard fork.

i am not sure if this will be an example of this but the last release doc made by @abit had missing important upgrades that were made. if we do all code in dev branches we can create versioned releases when we agree that enough or significant changes were made. this way all code between release and release will be added at once and nothing will be missed in the release doc. let me know if that is the idea.

Quote
* Back in BTS-1 I set up an automatic build process complete with generation of test coverage metrics and the like. PRs should only be accepted if they fulfill certain quality metrics. Perhaps set up https://about.sonarcloud.io/ or something like that?

sounds interesting as well, i never tried but i was taking a quick look to sonarcloud, looks good to consider. i will give a further look at it and get back here to talk about it.

your ideas for this @pc are very good and very inline with i was thinking to propose specially in code approval and development branches. gitflow helps in the process by managing feature branches organized, i think that is just what we need.


Offline pc

  • Hero Member
  • *****
  • Posts: 1530
    • View Profile
    • Bitcoin - Perspektive oder Risiko?
  • BitShares: cyrano
Since you're now (or will soon be) the officially employed core developer, may I suggest a few things:

* We should apply a proper development process on the github repo, like gitflow. Currently, everything goes right into master, which is generally a bad idea.
* Perhaps we should integrate @xeroc's testnet branch into the main repo.
* Create a set of rules for development, like
1. PR's are always to be made against develop.
2. PR's have to be ACKed by at least two "important" devs (apart from the submitter).
3. Merging develop into master is only allowed after develop has been tested successfully in testnet.
4. Merging into master requires ACK from at least three "important" devs.
(where an "important" dev is someone who has shown sufficient knowledge of the codebase, for example by submitting PRs).
* Create a set of rules for releases, especially wrt time frames in the case of a hard fork.
* Back in BTS-1 I set up an automatic build process complete with generation of test coverage metrics and the like. PRs should only be accepted if they fulfill certain quality metrics. Perhaps set up https://about.sonarcloud.io/ or something like that?

IMO we need to get more professional.
Bitcoin - Perspektive oder Risiko? ISBN 978-3-8442-6568-2 http://bitcoin.quisquis.de

Offline oxarbitrage

Hello guys, as you may already know the worker proposal has enough votes now to be approved, this was not easy job to get the needed votes but it was a huge learning experience on how the bitshares community governance works and a confirmation that i am in good track with my work here.

It will be impossible for me to thank each of the persons i contacted and all that supported me throw getting this worker proposal passed. during the voting process i asked for help or advice to everyone i know inside this community. a big thanks to all.

The worker starts formally Jul 12 but i am already making work as usual. As the previous worker ended more than a month ago i never stopped the work. Money from the first worker with bitshares appreciation helped me finish a big house remodeling i was on for more than a year, this ended up yesterday with a brand new office for me just in time to start with the new worker in a lot more comfortable environment to face the new challenges ahead. In the last 2 weeks while submitting the new worker proposal and making the all the needed stuff to get voted in had me busy as well.

From now on with all that sorted lets get into some quick updates:

- i configured the alfredo-worker account with the multisig accounts from my escrows:
http://cryptofresh.com/u/alfredo-worker
the 5 escrows plus my account(oxarbitrage.a699) are in place as owner and active, each with the same weight.
threshold of 4 from the total of 6 accounts is needed to move any fund.

i think 4 accounts(me + 3) from 6 is good enough to approve a transaction just in case some of the escrow is on vacation or unreachable but if anyone think this should be different please let me know.

- updates of work done will be posted in this thread once a week every weekend starting with this next weekend.

- working in a roadmap for the open source explorer project that could bring a clear picture to he community of how long we will have something usable and what to expect.

Again thanks to all  your for your support and any question, suggestion, comment please just let me know.

« Last Edit: July 07, 2017, 08:29:22 pm by oxarbitrage »


Offline sahkan

  • Sr. Member
  • ****
  • Posts: 247
    • View Profile
    • BitShares DEX
Voted! But as a reminder to ALL BTS holders, anyone that supports this worker should head out to their "Voting page for workers" and vote on this proposed worker.

Offline oxarbitrage

added a total of 5 escrow accounts to worker proposal document, all good people, what a crew!

chainsquad
dev.bitsharesblocks
elmato
fox
lin9uxis

thanks to the 5 for supporting me!




Offline oxarbitrage

thank you all guys for the support, i am still needing a lot of votes to get approved but i am working on it, hope i can make it :)

Offline Chronos