Author Topic: 1 PTS per Typo-Fix Pull Request Submitted to invictus.io  (Read 24066 times)

0 Members and 1 Guest are viewing this topic.

Offline jernau

  • Full Member
  • ***
  • Posts: 78
    • View Profile
In the page
http://invictus.io/bitshares-pts.php

Most pools have their own optimized miners, so do check out there get started pages.

pull request:
https://github.com/super3/invictus.io/pull/56

My two pull requests
https://github.com/super3/invictus.io/pull/55
https://github.com/super3/invictus.io/pull/56
got merged, yet no news on the bounty front.

Are these not eligible? I am confused.

I think bytemaster is away at the moment. Check his earlier posts in this thread: https://bitsharestalk.org/index.php?topic=2510.msg31456#msg31456
PTS: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW

Offline lakerta06

On page http://invictus.io/bitshares-ags.php, I think the following statement should be changed:

"You must send all donations from a wallet where for which you control the Private Key such as Bitcoin-Qt"

https://github.com/super3/invictus.io/pull/70
Shouldn't it be called 'address' instead of wallet .. wallets only exist in the reference bitcoin-qt/protoshare-qt implementation .. addresses exist in the protocol
Well, currently you can't even manage from which address you send the PTS from. If you have multiple addresses in your wallet, it just sends from one of them, or even with multiple input addresses.

Or can you manage it by the way?


Offline xeroc

  • Board Moderator
  • Hero Member
  • *****
  • Posts: 12922
  • ChainSquad GmbH
    • View Profile
    • ChainSquad GmbH
  • BitShares: xeroc
  • GitHub: xeroc
On page http://invictus.io/bitshares-ags.php, I think the following statement should be changed:

"You must send all donations from a wallet where for which you control the Private Key such as Bitcoin-Qt"

https://github.com/super3/invictus.io/pull/70
Shouldn't it be called 'address' instead of wallet .. wallets only exist in the reference bitcoin-qt/protoshare-qt implementation .. addresses exist in the protocol

Offline lakerta06

On page http://invictus.io/bitshares-ags.php, I think the following statement should be changed:

"You must send all donations from a wallet where for which you control the Private Key such as Bitcoin-Qt"

https://github.com/super3/invictus.io/pull/70

Offline nametooshort

  • Jr. Member
  • **
  • Posts: 46
    • View Profile
Even if writing Protoshare address in signature is not something good,
PvDZqsSyAsCDYNyYCfwZmy19EVohxnbnKB

Offline lakerta06

In the page
http://invictus.io/bitshares-pts.php

Most pools have their own optimized miners, so do check out there get started pages.

pull request:
https://github.com/super3/invictus.io/pull/56

My two pull requests
https://github.com/super3/invictus.io/pull/55
https://github.com/super3/invictus.io/pull/56
got merged, yet no news on the bounty front.

Are these not eligible? I am confused.

38PTSWarrior

  • Guest
I changed "Report Problems with Invictus.io" to
"Report problems with Invictus.io"

My name at Github is 38PTSjuggler, thank you and good luck in Miami

Modify:

I changed the capitalization of words that should normally be without capitalization.
For example: "Transparent Blockchains" to "Transparent blockchains"

Or: "Income from Transaction Fees" to "Income from transaction fees"
Or: "Slow Confirmations"to "Slow confirmations" because for example here:

All revenue spent on security
Additional 12% security tax
Slow Confirmations
Consumes Billions Annually

you could either write: "All Revenue Spent On Security" and follow this style, or do the changes I did.

After I started to change things I found out that I have to do this everywhere to make it consistent. I see that changing "Our Studio" to "Our studio" does not look so good but anyway, thanks for introducing me to GitHub and open-source feeling.
« Last Edit: January 25, 2014, 07:48:24 pm by 38PTSWarrior »


Offline toast

  • Hero Member
  • *****
  • Posts: 4001
    • View Profile
  • BitShares: nikolai
Do not use this post as information for making any important decisions. The only agreements I ever make are informal and non-binding. Take the same precautions as when dealing with a compromised account, scammer, sockpuppet, etc.

Offline lakerta06

In the page
http://invictus.io/bitshares-pts.php

Most pools have their own optimized miners, so do check out there get started pages.

pull request:
https://github.com/super3/invictus.io/pull/56

Offline lakerta06

Hi,

In the header.php there is a reference to http://alvarez.is/demo/newfirm/assets/js/twitterFetcher_v10_min.js javascript file which does not exist.

I have removed the reference and created a pull request: https://github.com/super3/invictus.io/pull/55

Offline gigawatt

  • Jr. Member
  • **
  • Posts: 27
    • View Profile
BTC: 1E2egHUcLDAmcxcqZqpL18TPLx9Xj1akcV
PTS: Pstkk1gZCxc4GEwS1eBAykYwVmcubU1P8L

Offline bytemaster

Find a typo, a glitch, or some other cosmetic bug with invictus.io, submit a pull request and get paid.  If you don't know how to use github, then post in this thread and split the bounty with someone who can manage github.

https://github.com/super3/invictus.io

Was just wondering if I'd get any reward. As far as I know, I was one of the first to start submitting pull requests - 3 of them - (username themanifold on github) for invictus.io.. :)

Address: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW

I am looking for your name in the commit log as it appears Super3 closed your pull request.   Looking through the commit history I do not see your requests... very curious.

If we pulled in your requests then I will make sure you get paid.      Ping me back after Miami Conference and I will get to the bottom of these missing commits.

For the latest updates checkout my blog: http://bytemaster.bitshares.org
Anything said on these forums does not constitute an intent to create a legal obligation or contract between myself and anyone else.   These are merely my opinions and I reserve the right to change them at any time.

Offline jernau

  • Full Member
  • ***
  • Posts: 78
    • View Profile
Find a typo, a glitch, or some other cosmetic bug with invictus.io, submit a pull request and get paid.  If you don't know how to use github, then post in this thread and split the bounty with someone who can manage github.

https://github.com/super3/invictus.io

Was just wondering if I'd get any reward. As far as I know, I was one of the first to start submitting pull requests - 3 of them - (username themanifold on github) for invictus.io.. :)

Address: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW
PTS: PgiEykg2RATYwWYhFtyNRqwSxQyEApLSmW