@svk: I've been meaning to comment on the last release and offer additional feedback, just been so busy lately. But great job with the latest changes to the horizontal order book layout. Also, the expand and contract buttons on the chart are very helpful. And the chart timeframes make more sense now (e.g. there was no need for 5s). Although if it's a relatively easy matter to add them, I would go ahead and add 1m, 2h, 6h, 12h and 1w. If it's time consuming to add each one, I would add 1m immediately and hold off on the others for now.
Also with respect to the chart, something has changed where the volume bars now obscure view of the candlesticks. It was definitely much better before. And final point about the chart...we once had a crosshair, and now it is just a vertical line. Can you make it a cross hair again, and have the price of the vertical line's position show on the vertical axis as the crosshair moves? That would mimic standard behavior.
By the way, while the horizontal layout is much improved now, the vertical layout has taken a step backwards with the ticker (price history) now pushed further down. For the very same reasons the price history has been moved immediately below the chart in the horizontal layout, the same should be true on the vertical layout.
Also, when you click on the order book, it is adding the cumulative available orders and putting a value into the order box, but it's not calculating properly. Can you take a look at that?
Beyond that, we really need to start working toward having some basic position management. I mentioned in a previous post that the Open Orders box could be modified to include a Current Positions view. So the box could have 2 tabs for the user to choose between. The tab headers could include the number of items in the list like below. Also, Open Positions could show the P/L (% gain or loss) for each position. And each position could be hyperlinked so the user can click to load that market into the current view in order to assess the situation and/or close out or add to their position.
| Open Orders (1) | Current Positions (5) |
Finally, there is still some strange behavior with the Find Markets tab. For example, if I enter "OPEN.EUR", it returns the OPEN.EUR pairs with BTS, BTC, USD, CNY...but not EUR. Do you know why that is?
I put the volume bars and the candlesticks on the same y-axis, it gives more space to each one so I prefer it that way at least. In the process the axis indexes changed which is why the crosshair disappeared, I hadn't even noticed but I'll put them back in.
I've been meaning to respond to this for some time, but I've been so busy. In any event, I appreciate your reasoning here. Having both on the same y-axis works well on Poloniex and TradingView, to name a couple. But I guess with the colors those sites use, the volume bars don't obscure the candlesticks nearly as much. And in TradingView you can easily hide and unhide the volume with the click of the mouse. I often wish I could do that on Poloniex as well. Maybe you can add that capability on the DEX. It would be helpful.
The chart timeframes are defined in the backend, but I decided to filter out anything below 5 minutes because with the low volume we have it just doesn't show anything useful atm. If you really think 1m is useful I can set the cutoff there.
Once we start getting much more active trading in some of these markets, there will be traders who scalp that will need 1m charts.
Clicking on the orderbook appears correct to me, I tried to be very careful when I refactored it and checking now I can't find anything wrong. It uses the Total and the Price for that order to calculate the corresponding Amount. That's how it works on Polo as well as far as I can tell. If you think it should work differently, can you give me an example please?
This is definitely not working properly. What we want is for the total price of the buy/sell order to be populated with the sum of the prices of each row up to the one clicked. What you're doing is taking the cumulative number of shares and dividing it by the price of the row clicked. But that doesn't give the actual number of shares available.
Poloniex, on the other hand, adds the number of shares row by row the way I'm suggesting. That's what's good about how they auto-populate the order information. But then unfortunately, when it comes to the price, they do something similar to what you're doing i.e. they calculate the total buy/sell price by multiplying the total number of shares by the price of the row clicked. That overestimates the cost of the trade when they could easily give the exact total price of the actual shares available on the order book up to the row clicked.
In summary, to be as useful as possible, both values (amount of shares to buy/sell, and total price of the transaction) should be sums of the corresponding values in each of the rows up to the one clicked. This is another case where if we get it right, we'll be superior to the others. That should bode well for us once we get what I hope will soon be an influx of people looking to trade LISK (and hopefully other assets) here on the DEX.