Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.


Messages - oxarbitrage

Pages: 1 2 3 4 5 6 [7] 8 9 10 11 12 13
91
Many users would also feel more comfortable using this if a BitShares dev peer reviewed the code.  That would also help iron out any bugs and speed development.  Perhaps Alfredo or Abit could help with this?
yea, no problem, if it gets accepted i will help them in what i can. did not readed fully yet but good luck!

92
General Discussion / Re: nano ledger S/trezor compaitibility?
« on: December 19, 2017, 09:08:45 pm »
the most close to solving this is the experimental code made by @xeroc and @svk for a hackaton where they integrate trezor with steem, this code can be found at https://github.com/chainsquad

it should be possible with some effort to make this work for bitshares,  this topic is always bumped from time to time. if i remember correctly the development stopped mainly because bitshares was waiting for an upgrade from trezor on their api that will make this thing a lot easier than it is now. Now it needs to be done in C, the new api will allow to do everything from python. new api was never released from trezor, not sure how is that at this days.

kencode also was starting a project for ledger-nano, a device similar to trezor as far as i know. initial code can be found at https://github.com/Agorise/ledger-nano-s-bitshares but i think it was stopped for lack of funding.

if the bitshares community really targets this as a priority we will have a better view on what is needed than what we have now. probably need to hire someone with proven skills in trezor that had integrated other cryptos to it and work together with some of the bitshares devs to get what he needs, not sure, need to be planned first to have an idea of how much in $, time and in human resources this will need.


93
General Discussion / Re: open sourcing the explorer.
« on: December 19, 2017, 08:24:29 pm »
Thank you very much.

- explorer unthemed: https://github.com/oxarbitrage/open-explorer.io
That link does not work?


they are all closed repos until we check everything is in good shape to open source it in regards to licences. that is the repo i will actually open source after this review i am requesting. can send you access if you want, just send me your github username.

94
General Discussion / Re: open sourcing the explorer.
« on: December 19, 2017, 05:01:16 pm »
http://open-explorer.io/ looking better than the one with theme in my opinion :)

i think the same, it haves only what matters. after i release i will be able to resume the work in the issues it haves that are the same than in the themed version(https://github.com/oxarbitrage/bitshares-explorer/issues). will also get help  from the UI team in exchange for some work i am making for tradingview integration on the UI. also will get help from any that want to participate. i think it will be cool to have a github pages version that updates as code is merged.

95
General Discussion / Re: open sourcing the explorer.
« on: December 19, 2017, 02:16:40 pm »
if you think you can collaborate with this please drop me your github user and ill add you as collaborator of the 3 repos. i need to release the code of this asap.

Please add ryanRfox to the repos and I will review with you. I appreciate your efforts in making this code open source.

added you to the 3 repos, thanks.

To be honest, this explorer looks very good  +5%

I've spotted something that may be an error. Over here

http://open-explorer.io/#/assets

top left table says

Quote
24H MARKET CAP IN MILLION BTS
24H MARKET CAP IN MILLION USD
24H MARKET CAP IN MILLION CNY

but the numbers look like it is in BTS, USD, CNY, not million of BTS, USD, CNY. Please, check the units.


thank you for that, changed it in here: http://bitshares-explorer.io/#/assets and http://open-explorer.io/#/assets

please use https://github.com/oxarbitrage/bitshares-explorer/issues for issues.

97
General Discussion / open sourcing the explorer.
« on: December 18, 2017, 10:17:25 pm »
new unthemed opensource candidate online version: http://open-explorer.io/

i am releasing an open source version of the explorer. to refresh, i made an initial mistake and used a purchased theme to make the project http://bitshares-explorer.io/ and now i removed all theme related stuff to make an open source version(much more harder to do than to say). i am sharing the 3 private repos in order to make sure the MIT version is good enough to don't bring any license trouble to bitshares.

after trying to contact the vendor by email asking how much he will charge to release the code under MIT without response i actually started a new project using  https://github.com/angular/angular-seed and added my code  into it, i followed some of the original purchased template rules like using grunt, bower and such but everything could be done without the theme in the first place so i think it should be fine.

just trying to make sure by having more eyes watching it.

- original theme: https://github.com/oxarbitrage/original-theme-explorer - online: http://bitshares-explorer.io/orig/#/
- explorer with theme: https://github.com/oxarbitrage/bitshares-explorer.io - online: http://bitshares-explorer.io/
- explorer unthemed: https://github.com/oxarbitrage/open-explorer.io - online: http://open-explorer.io/

if you think you can collaborate with this please drop me your github user and ill add you as collaborator of the 3 repos. i need to release the code of this asap.

thank you very much.

98
i like the idea of having a fund for small and specific tasks. an example is the bitshares wikipedia page made by @Ravid and many others. It will encourage more workers without the need of the full formal process for stuff that could be smaller or relative smaller in cost than the process of setting up itself.

99
Stakeholder Proposals / Re: proposal to create bitXCD
« on: December 12, 2017, 08:22:50 pm »
wow, this really looks amazing for bitshares, its the kind of business i personally love to see. many thanks @bitcrab for bringing them on and i hope we can give all the support they need starting by creating the asset  :)

100
this is not for traders, is for developers.

101
Quote
Bitshares does a horrible job of reporting / P&L anyway (for now), as you can't export your trade histories more than a few blocks back.

This is true, and this is pita. If this proposal would address P&L reporting issue, I would support this worker without asking no more questions, plus offer a donation on top.


This is not true anymore :) even if we have no infrastructure developed for ElasticSearch plugin yet ...

I have a working wrapper for it here: https://github.com/oxarbitrage/bitshares-es-wrapper with some sample urls on what can be done.

API call can be constructed to get all the FILL ORDERS from an account , check the last sample of the readme. By scraping the operation and the amounts inside i suppose the p&l can be obtained.

102
Stakeholder Proposals / Re: Poll: BSIP 26 & 27
« on: December 04, 2017, 03:15:26 pm »
i just saw BSIP38 thanks to this post and i added some comments on it: https://github.com/bitshares/bsips/issues/38#issuecomment-348991034

103
General Discussion / Re: Wikipedia page is live
« on: December 04, 2017, 03:00:37 pm »
very nice work, i can contribute translating it to spanish.

104
Dear bitshares stakeholders and general public that may be reading, here is a report of the documented work done in the last 15 days by this worker.

bitshares-core:

- https://github.com/bitshares/bitshares-core/pull/488 - @xeroc submitted a fix for his docker configurations that was merged into the develop branch.

- @xeroc new docker codes replaces https://github.com/bitshares/bitshares-core/pull/376 so it was closed.

- merged docker config by xeroc to fix curl dependency of develop branch(needed for elasticsearch plugin): https://github.com/bitshares/bitshares-core/pull/498

- closed docker related issue: https://github.com/bitshares/bitshares-core/issues/318

- https://github.com/bitshares/bitshares-core/issues/358 - @pc suggested that exposing the whole elasticsearch database to the internet may be risky. for this reason i am working on a small python wrapper so the UI and other apps can make queries to that instead of directly the database. This wrapper is work in progress just started and it is located by now here: https://github.com/oxarbitrage/bitshares-es-wrapper

- a small deprecated text was found by a contributor in the p2p code of bitshares. his change was merged to the develop branch: https://github.com/bitshares/bitshares-core/pull/489

- https://github.com/bitshares/bitshares-core/issues/484 - some assitance was provided to a new developer trying to work with bitshares in this issue and in telegram developer channel.

- https://github.com/bitshares/bitshares-core/pull/478 - After testing this by setting up nodes and others we finally merged the changes made by @abit that deal with extreme values in market history data that were making charts to look very bad. This pull allowed to close several issues, after reviews by @sivek, myself and other contributors from telegram we merged the code. Big improvement here.

- https://github.com/bitshares/bitshares-core/pull/494 - merged small typo pull request.

- https://github.com/bitshares/bitshares-core/issues/499 - tested, was not able to find memory leak issuer presents following his steps, memory remains the same, closing the issue.

- https://github.com/bitshares/bitshares-core/pull/500 - in addition to the former ES plugin that saves account history data to the database we created a new plugin that saves additional data, needed to fix several issues and make queries of some data easier. It is in progress and not merged yet, related discussion and more info can be found in the pull.

- https://github.com/bitshares/bitshares-core/pull/507 - 2 new functions were proposed in the pull to create and read memos in the cli_wallet. After testing and reviewing the code it was concluded that it works good so the pull was merged.

- https://github.com/bitshares/bitshares-core/issues/126 - closed as issue is too old and part of it is solved at present time.

- fixed https://github.com/bitshares/bitshares-core/issues/66 with https://github.com/bitshares/bitshares-core/pull/508

- https://github.com/bitshares/bitshares-core/issues/514 - trying to bring some light to this new bitshares enthusiast on how the system works.

bsips:

- some small technical additions were added to bsip28 proposed by @bill butler. https://github.com/bitshares/bsips/pull/41

explorer:

- https://github.com/oxarbitrage/bitshares-explorer/pull/13 -> added pull with link to bitshares explorer api backend.

- https://github.com/oxarbitrage/bitshares-explorer/issues/12 - this is very important so i have it as the highest priority for the explorer even if i know there are other issues in charting,  more data, presentation of data, etc people want to see; the release of the code will bring contributions from outside that will make the whole thing go faster.

This will be easy if it was not by the theme restrictions it haves and the initial error i made of building the explorer on top of it. I contacted the theme owner several days ago to see if it could be a possibility to open source it(for a price). No response yet.

In the last few days i had been in conversations with the UI team in order to develop an UDF wrapper needed to add trading view charts to the reference UI. The issue for it is at https://github.com/bitshares/bitshares-ui/issues/773 and had been assigned to me with 20 hours.
As i already have a position in bitshares i will not be getting this 20 hours in cash but instead i am going to exchange it by work in the explorer. A first option will be to get some help in the release of the project, i already discussed with Calvin and he can help here. Another option is to make that work myself and invest the 20 hours(or more, as i am not sure how much the UDF thing will take) for other explorer work. Open to suggestions here.

105
Nice work. I would personally like to see a chart on your new Explorer that shows Dex BitUSD - equivalent volume on a scalable basis (and filterable for Smartcoins vs UIA, for example, or by single asset pairing)

Hey @renko, sorry i didn't saw your message before. Can you please open an issue for it at https://github.com/oxarbitrage/bitshares-explorer/issues
I will be happy to do it, please also include some more details about it like where in the explorer you will want that placed. assets page(http://bitshares-explorer.io/#/assets)? bitusd page(http://bitshares-explorer.io/#/assets/1.3.121)?  and what do you want to be charted more specifically as i don't fully understand it. thanks!

Pages: 1 2 3 4 5 6 [7] 8 9 10 11 12 13